From: Teng Long <dyroneteng@gmail.com>
To: dyroneteng@gmail.com
Cc: avarab@gmail.com, git@vger.kernel.org, gitster@pobox.com,
sunshine@sunshineco.com, tenglong.tl@alibaba-inc.com
Subject: [PATCH 0/6] notes.c: introduce "--separator" option
Date: Tue, 25 Apr 2023 21:34:35 +0800 [thread overview]
Message-ID: <cover.1682429602.git.dyroneteng@gmail.com> (raw)
In-Reply-To: <cover.1680012650.git.dyroneteng@gmail.com>
From: Teng Long <dyroneteng@gmail.com>
Diff since v7:
1. Fix problems that Junio's replies in last patch, except:
* array of strbufs -> string_list (in [1]): the message may from
a binary file which may contain '\0' in middle, string will be
cut off then make a unexpected result.
2. New commit [3/6] for adding test cases about stripspace behavior.
3. New commit [6/6] for supporting "--[no-]stripspace".
[1] https://public-inbox.org/git/xmqq5yakhoo9.fsf@gitster.g/
Thanks.
Teng Long (6):
notes.c: cleanup 'strbuf_grow' call in 'append_edit'
notes.c: use designated initializers for clarity
t3321: add test cases about the notes stripspace behavior
notes.c: introduce '--separator=<paragraph-break>' option
notes.c: append separator instead of insert by pos
notes.c: introduce "--[no-]stripspace" option
Documentation/git-notes.txt | 42 ++-
builtin/notes.c | 144 +++++++---
t/t3301-notes.sh | 126 +++++++++
t/t3321-notes-stripspace.sh | 521 ++++++++++++++++++++++++++++++++++++
4 files changed, 791 insertions(+), 42 deletions(-)
create mode 100755 t/t3321-notes-stripspace.sh
Range-diff against v7:
1: ea9c199e ! 1: 0634434e notes.c: cleanup 'strbuf_grow' call in 'append_edit'
@@ builtin/notes.c: static int parse_msg_arg(const struct option *opt, const char *
strbuf_addch(&d->buf, '\n');
strbuf_addstr(&d->buf, arg);
@@ builtin/notes.c: static int append_edit(int argc, const char **argv, const char *prefix)
- enum object_type type;
- char *prev_buf = read_object_file(note, &type, &size);
+ char *prev_buf = repo_read_object_file(the_repository, note,
+ &type, &size);
- strbuf_grow(&d.buf, size + 1);
if (d.buf.len && prev_buf && size)
2: 9dc123c8 ! 2: 4ad78405 notes.c: cleanup for "designated init"
@@ Metadata
Author: Teng Long <dyroneteng@gmail.com>
## Commit message ##
- notes.c: cleanup for "designated init"
+ notes.c: use designated initializers for clarity
The "struct note_data d = { 0, 0, NULL, STRBUF_INIT };" style could be
- replaced with designated init format.
+ replaced with designated initializer for clarity.
Signed-off-by: Teng Long <dyroneteng@gmail.com>
+ Signed-off-by: Junio C Hamano <gitster@pobox.com>
## builtin/notes.c ##
@@ builtin/notes.c: static int add(int argc, const char **argv, const char *prefix)
-: -------- > 3: 6dfb5bf2 t3321: add test cases about the notes stripspace behavior
3: d1febf86 ! 4: be86f9ca notes.c: introduce '--separator=<paragraph-break>' option
@@ Commit message
The default behavour sometimes is not enough, the user may want
to use a custom delimiter between paragraphs, like when
- specifiy '-m', '-F', '-C', '-c' options. So this commit
+ specifying '-m', '-F', '-C', '-c' options. So this commit
introduce a new '--separator' option for 'git notes add' and
- 'git notes append', for example when execute:
+ 'git notes append', for example when executing:
$ git notes add -m foo -m bar --separator="-"
$ git notes show HEAD | cat
@@ Commit message
-
bar
- A newline is added to the value given to --separator if it
- does not end with one already. So execute:
+ a newline is added to the value given to --separator if it
+ does not end with one already. So when executing:
$ git notes add -m foo -m bar --separator="-"
and
@@ Commit message
"
$ git notes add -m foo -m bar --separator="-$LF"
- Running A and B produces the same result.
+ Both the two exections produce the same result.
+
+ The reason we use a "strbuf" array to concat but not "string_list", is
+ that the binary file content may contain '\0' in the middle, this will
+ cause the corrupt result if using a string to save.
Signed-off-by: Teng Long <dyroneteng@gmail.com>
@@ Documentation/git-notes.txt: OPTIONS
## builtin/notes.c ##
@@
- #include "notes-utils.h"
+ */
+
+ #include "cache.h"
++#include "alloc.h"
+ #include "config.h"
+ #include "builtin.h"
+ #include "gettext.h"
+@@
#include "worktree.h"
+ #include "write-or-die.h"
+static char *separator = NULL;
static const char * const git_notes_usage[] = {
@@ builtin/notes.c
N_("git notes [--ref <notes-ref>] edit [--allow-empty] [<object>]"),
N_("git notes [--ref <notes-ref>] show [<object>]"),
N_("git notes [--ref <notes-ref>] merge [-v | -q] [-s <strategy>] <notes-ref>"),
-@@ builtin/notes.c: struct note_data {
+@@ builtin/notes.c: static const char * const git_notes_get_ref_usage[] = {
+ static const char note_template[] =
+ N_("Write/edit the notes for the following object:");
+
++struct note_msg {
++ int stripspace;
++ struct strbuf buf;
++};
++
+ struct note_data {
+ int given;
int use_editor;
char *edit_path;
struct strbuf buf;
-+ struct strbuf **messages;
++ struct note_msg **messages;
+ size_t msg_nr;
+ size_t msg_alloc;
};
static void free_note_data(struct note_data *d)
+@@ builtin/notes.c: static void free_note_data(struct note_data *d)
+ free(d->edit_path);
+ }
+ strbuf_release(&d->buf);
++
++ while (d->msg_nr) {
++ --d->msg_nr;
++ strbuf_release(&d->messages[d->msg_nr]->buf);
++ free(d->messages[d->msg_nr]);
++ }
++ free(d->messages);
+ }
+
+ static int list_each_note(const struct object_id *object_oid,
@@ builtin/notes.c: static void write_note_data(struct note_data *d, struct object_id *oid)
}
}
@@ builtin/notes.c: static void write_note_data(struct note_data *d, struct object_
+ strbuf_insertf(message, pos, "%s%s", separator, "\n");
+}
+
-+/* Consume messages and append them into d->buf, then free them */
+static void concat_messages(struct note_data *d)
+{
+ struct strbuf msg = STRBUF_INIT;
@@ builtin/notes.c: static void write_note_data(struct note_data *d, struct object_
+ for (i = 0; i < d->msg_nr ; i++) {
+ if (d->buf.len)
+ insert_separator(&d->buf, d->buf.len);
-+ strbuf_add(&msg, d->messages[i]->buf, d->messages[i]->len);
++ strbuf_add(&msg, d->messages[i]->buf.buf, d->messages[i]->buf.len);
+ strbuf_addbuf(&d->buf, &msg);
++ if (d->messages[i]->stripspace)
++ strbuf_stripspace(&d->buf, 0);
+ strbuf_reset(&msg);
-+ strbuf_release(d->messages[i]);
-+ free(d->messages[i]);
+ }
+ strbuf_release(&msg);
-+ free(d->messages);
+}
+
static int parse_msg_arg(const struct option *opt, const char *arg, int unset)
{
struct note_data *d = opt->value;
-+ struct strbuf *buf;
++ struct note_msg *msg = xmalloc(sizeof(*msg));
BUG_ON_OPT_NEG(unset);
@@ builtin/notes.c: static void write_note_data(struct note_data *d, struct object_
- strbuf_addch(&d->buf, '\n');
- strbuf_addstr(&d->buf, arg);
- strbuf_stripspace(&d->buf, 0);
-+ buf = xmalloc(sizeof(*buf));
-+ strbuf_init(buf, strlen(arg));
-+ strbuf_addstr(buf, arg);
-+ strbuf_stripspace(buf, 0);
-
+-
- d->given = 1;
++ strbuf_init(&msg->buf, strlen(arg));
++ strbuf_addstr(&msg->buf, arg);
+ ALLOC_GROW_BY(d->messages, d->msg_nr, 1, d->msg_alloc);
-+ d->messages[d->msg_nr - 1] = buf;
++ d->messages[d->msg_nr - 1] = msg;
++ msg->stripspace = 1;
return 0;
}
static int parse_file_arg(const struct option *opt, const char *arg, int unset)
{
struct note_data *d = opt->value;
-+ struct strbuf *buf;
++ struct note_msg *msg = xmalloc(sizeof(*msg));
BUG_ON_OPT_NEG(unset);
- if (d->buf.len)
- strbuf_addch(&d->buf, '\n');
-+ buf = xmalloc(sizeof(*buf));
-+ strbuf_init(buf, 0);
-+
++ strbuf_init(&msg->buf , 0);
if (!strcmp(arg, "-")) {
- if (strbuf_read(&d->buf, 0, 1024) < 0)
-+ if (strbuf_read(buf, 0, 1024) < 0)
++ if (strbuf_read(&msg->buf, 0, 1024) < 0)
die_errno(_("cannot read '%s'"), arg);
- } else if (strbuf_read_file(&d->buf, arg, 1024) < 0)
-+ } else if (strbuf_read_file(buf, arg, 1024) < 0)
++ } else if (strbuf_read_file(&msg->buf, arg, 1024) < 0)
die_errno(_("could not open or read '%s'"), arg);
- strbuf_stripspace(&d->buf, 0);
-+ strbuf_stripspace(buf, 0);
- d->given = 1;
-+ // we will note stripspace the buf here, because the file maybe
-+ // is a binary and it maybe contains multiple continuous line breaks.
+ ALLOC_GROW_BY(d->messages, d->msg_nr, 1, d->msg_alloc);
-+ d->messages[d->msg_nr - 1] = buf;
++ d->messages[d->msg_nr - 1] = msg;
++ msg->stripspace = 1;
return 0;
}
@@ builtin/notes.c: static void write_note_data(struct note_data *d, struct object_
{
struct note_data *d = opt->value;
- char *buf;
-+ struct strbuf *buf;
++ struct note_msg *msg = xmalloc(sizeof(*msg));
++ char *value;
struct object_id object;
enum object_type type;
unsigned long len;
@@ builtin/notes.c: static void write_note_data(struct note_data *d, struct object_
- if (d->buf.len)
- strbuf_addch(&d->buf, '\n');
-
-+ buf = xmalloc(sizeof(*buf));
- if (get_oid(arg, &object))
++ strbuf_init(&msg->buf, 0);
+ if (repo_get_oid(the_repository, arg, &object))
die(_("failed to resolve '%s' as a valid ref."), arg);
-- if (!(buf = read_object_file(&object, &type, &len)))
-+ if (!(buf->buf = read_object_file(&object, &type, &len)))
+- if (!(buf = repo_read_object_file(the_repository, &object, &type, &len)))
++ if (!(value = repo_read_object_file(the_repository, &object, &type, &len)))
die(_("failed to read object '%s'."), arg);
if (type != OBJ_BLOB) {
-+ strbuf_release(buf);
- free(buf);
+- free(buf);
++ strbuf_release(&msg->buf);
++ free(value);
++ free(msg);
die(_("cannot read note data from non-blob object '%s'."), arg);
}
- strbuf_add(&d->buf, buf, len);
- free(buf);
- d->given = 1;
-+ // The reuse object maybe is a binary content which could
-+ // contains '\0' in the middle, so let's set the correct
-+ // lenth of strbuf to concat all of content.
-+ buf->len = len;
++ strbuf_add(&msg->buf, value, len);
++ free(value);
++
++ msg->buf.len = len;
+ ALLOC_GROW_BY(d->messages, d->msg_nr, 1, d->msg_alloc);
-+ d->messages[d->msg_nr - 1] = buf;
++ d->messages[d->msg_nr - 1] = msg;
++ msg->stripspace = 0;
return 0;
}
- static int parse_reedit_arg(const struct option *opt, const char *arg, int unset)
- {
- struct note_data *d = opt->value;
-+
- BUG_ON_OPT_NEG(unset);
- d->use_editor = 1;
- return parse_reuse_arg(opt, arg, unset);
@@ builtin/notes.c: static int add(int argc, const char **argv, const char *prefix)
- struct notes_tree *t;
struct object_id object, new_note;
const struct object_id *note;
-- struct note_data d = { .buf = STRBUF_INIT };
-+ struct note_data d = { .buf = STRBUF_INIT, .messages = NULL };
+ struct note_data d = { .buf = STRBUF_INIT };
+
struct option options[] = {
OPT_CALLBACK_F('m', "message", &d, N_("message"),
@@ builtin/notes.c: static int add(int argc, const char **argv, const char *prefix)
+
object_ref = argc > 1 ? argv[1] : "HEAD";
- if (get_oid(object_ref, &object))
-@@ builtin/notes.c: static int append_edit(int argc, const char **argv, const char *prefix)
- const struct object_id *note;
- char *logmsg;
- const char * const *usage;
-- struct note_data d = { .buf = STRBUF_INIT };
-+ struct note_data d = { .buf = STRBUF_INIT, .messages = NULL };
-+
- struct option options[] = {
- OPT_CALLBACK_F('m', "message", &d, N_("message"),
- N_("note contents as a string"), PARSE_OPT_NONEG,
+ if (repo_get_oid(the_repository, object_ref, &object))
@@ builtin/notes.c: static int append_edit(int argc, const char **argv, const char *prefix)
parse_reuse_arg),
OPT_BOOL(0, "allow-empty", &allow_empty,
@@ builtin/notes.c: static int append_edit(int argc, const char **argv, const char
fprintf(stderr, _("The -m/-F/-c/-C options have been deprecated "
"for the 'edit' subcommand.\n"
@@ builtin/notes.c: static int append_edit(int argc, const char **argv, const char *prefix)
- char *prev_buf = read_object_file(note, &type, &size);
+ &type, &size);
if (d.buf.len && prev_buf && size)
- strbuf_insertstr(&d.buf, 0, "\n");
@@ builtin/notes.c: static int append_edit(int argc, const char **argv, const char
free(prev_buf);
## t/t3301-notes.sh ##
-@@
-
- test_description='Test commit notes'
-
-+TEST_PASSES_SANITIZE_LEAK=true
- . ./test-lib.sh
-
- write_script fake_editor <<\EOF
@@ t/t3301-notes.sh: test_expect_success 'do not create empty note with -m ""' '
'
4: b9d12f0c < -: -------- notes.c: don't do stripespace when parse file arg
-: -------- > 5: ef40e0ef notes.c: append separator instead of insert by pos
-: -------- > 6: f60f7432 notes.c: introduce "--[no-]stripspace" option
--
2.40.0.358.g931d6dc6
next prev parent reply other threads:[~2023-04-25 13:35 UTC|newest]
Thread overview: 186+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 5:56 [RFC PATCH 0/2] notes.c: introduce "--no-blankline" option Teng Long
2022-10-13 5:56 ` [RFC PATCH 1/2] " Teng Long
2022-10-13 6:06 ` Junio C Hamano
2022-10-17 13:19 ` Teng Long
2022-10-13 9:31 ` Ævar Arnfjörð Bjarmason
2022-10-17 13:33 ` Teng Long
2022-10-13 5:56 ` [RFC PATCH 2/2] notes.c: fixed tip when target and append note are both empty Teng Long
2022-10-13 9:36 ` Ævar Arnfjörð Bjarmason
2022-10-13 10:10 ` Phillip Wood
2022-10-13 10:23 ` Ævar Arnfjörð Bjarmason
2022-10-15 19:40 ` Phillip Wood
2022-10-18 3:25 ` Teng Long
2022-10-18 8:08 ` Teng Long
2022-10-18 3:11 ` Teng Long
2022-10-18 9:23 ` Ævar Arnfjörð Bjarmason
2022-11-07 13:57 ` [PATCH v2 0/3] notes.c: introduce "--blank-line" option Teng Long
2022-11-07 13:57 ` [PATCH v2 1/3] " Teng Long
2022-11-07 14:45 ` Ævar Arnfjörð Bjarmason
2022-11-07 15:45 ` Eric Sunshine
2022-11-07 17:22 ` Ævar Arnfjörð Bjarmason
2022-11-07 21:46 ` Taylor Blau
2022-11-07 22:36 ` Ævar Arnfjörð Bjarmason
2022-11-08 0:32 ` Taylor Blau
2022-11-08 3:45 ` Teng Long
2022-11-08 13:06 ` Teng Long
2022-11-08 13:22 ` Ævar Arnfjörð Bjarmason
2022-11-09 6:35 ` Teng Long
2022-11-07 15:06 ` Ævar Arnfjörð Bjarmason
2022-11-08 6:32 ` Teng Long
2022-11-07 21:47 ` Taylor Blau
2022-11-08 7:36 ` Teng Long
2022-11-07 13:57 ` [PATCH v2 2/3] notes.c: fixed tip when target and append note are both empty Teng Long
2022-11-07 14:40 ` Ævar Arnfjörð Bjarmason
2022-11-07 21:51 ` Taylor Blau
2022-11-07 22:33 ` Ævar Arnfjörð Bjarmason
2022-11-07 22:45 ` Taylor Blau
2022-11-08 8:55 ` Teng Long
2022-11-07 13:57 ` [PATCH v2 3/3] notes.c: drop unreachable code in "append_edit()" Teng Long
2022-11-07 14:41 ` Ævar Arnfjörð Bjarmason
2022-11-07 14:57 ` [PATCH v2 0/3] notes.c: introduce "--blank-line" option Ævar Arnfjörð Bjarmason
2022-11-09 7:05 ` Teng Long
2022-11-09 7:06 ` Teng Long
2022-11-09 9:06 ` [PATCH v3 0/5] notes.c: introduce "--no-blank-line" option Teng Long
2022-11-09 9:06 ` [PATCH v3 1/5] notes.c: cleanup 'strbuf_grow' call in 'append_edit' Teng Long
2022-11-09 9:06 ` [PATCH v3 2/5] notes.c: cleanup for "designated init" and "char ptr init" Teng Long
2022-11-09 9:06 ` [PATCH v3 3/5] notes.c: drop unreachable code in 'append_edit()' Teng Long
2022-11-09 9:06 ` [PATCH v3 4/5] notes.c: provide tips when target and append note are both empty Teng Long
2022-11-09 9:06 ` [PATCH v3 5/5] notes.c: introduce "--no-blank-line" option Teng Long
2022-11-28 14:20 ` [PATCH v3 0/5] " Teng Long
2022-11-29 1:10 ` Junio C Hamano
2022-11-29 22:53 ` Taylor Blau
2022-11-29 12:57 ` Teng Long
2022-11-29 13:19 ` Junio C Hamano
2022-12-15 12:48 ` Teng Long
2022-12-19 3:03 ` Eric Sunshine
2022-12-21 9:16 ` Teng Long
2022-12-21 11:35 ` Junio C Hamano
2022-12-22 9:30 ` Teng Long
2022-12-23 1:36 ` Eric Sunshine
2023-01-12 2:48 ` [PATCH v4 0/5] notes.c: introduce "--separator" optio Teng Long
2023-01-12 2:48 ` [PATCH v4 1/5] notes.c: cleanup 'strbuf_grow' call in 'append_edit' Teng Long
2023-01-15 4:53 ` Eric Sunshine
2023-01-28 11:22 ` Teng Long
2023-01-12 2:48 ` [PATCH v4 2/5] notes.c: cleanup for "designated init" and "char ptr init" Teng Long
2023-01-12 9:51 ` Ævar Arnfjörð Bjarmason
2023-01-28 11:33 ` Teng Long
2023-01-12 2:48 ` [PATCH v4 3/5] notes.c: drop unreachable code in 'append_edit()' Teng Long
2023-01-15 20:59 ` Eric Sunshine
2023-01-15 21:10 ` Eric Sunshine
2023-01-28 11:50 ` Teng Long
2023-01-30 5:38 ` Eric Sunshine
2023-02-01 8:08 ` Teng Long
2023-01-12 2:48 ` [PATCH v4 4/5] notes.c: provide tips when target and append note are both empty Teng Long
2023-01-12 9:52 ` Ævar Arnfjörð Bjarmason
2023-01-15 21:28 ` Eric Sunshine
2023-01-12 2:48 ` [PATCH v4 5/5] notes.c: introduce "--separator" option Teng Long
2023-01-12 9:53 ` Ævar Arnfjörð Bjarmason
2023-01-15 22:04 ` Eric Sunshine
2023-01-15 22:15 ` Eric Sunshine
2023-02-16 13:05 ` [PATCH v5 0/3] " Teng Long
2023-02-16 13:05 ` [PATCH v5 1/3] notes.c: cleanup 'strbuf_grow' call in 'append_edit' Teng Long
2023-02-16 18:39 ` Junio C Hamano
2023-02-20 3:34 ` Teng Long
2023-02-16 13:05 ` [PATCH v5 2/3] notes.c: cleanup for "designated init" Teng Long
2023-02-16 18:39 ` Junio C Hamano
2023-02-16 13:05 ` [PATCH v5 3/3] notes.c: introduce "--separator" option Teng Long
2023-02-16 23:22 ` Junio C Hamano
2023-02-20 14:00 ` Teng Long
2023-02-21 21:31 ` Junio C Hamano
2023-02-22 8:17 ` Teng Long
2023-02-22 23:15 ` Junio C Hamano
2023-02-23 7:29 ` [PATCH v6 0/3] " Teng Long
2023-02-23 7:29 ` [PATCH v6 1/3] notes.c: cleanup 'strbuf_grow' call in 'append_edit' Teng Long
2023-02-23 7:29 ` [PATCH v6 2/3] notes.c: cleanup for "designated init" Teng Long
2023-02-23 7:29 ` [PATCH v6 3/3] notes.c: introduce '--separator=<paragraph-break>' option Teng Long
2023-02-23 18:21 ` Junio C Hamano
2023-02-28 14:11 ` Teng Long
2023-02-25 21:30 ` Junio C Hamano
2023-02-28 14:14 ` Teng Long
2023-03-27 13:13 ` [PATCH v6 0/3] notes.c: introduce "--separator" option Teng Long
2023-03-28 14:28 ` [PATCH v7 0/4] " Teng Long
2023-03-28 14:28 ` [PATCH v7 1/4] notes.c: cleanup 'strbuf_grow' call in 'append_edit' Teng Long
2023-03-28 14:28 ` [PATCH v7 2/4] notes.c: cleanup for "designated init" Teng Long
2023-03-29 22:17 ` Junio C Hamano
2023-03-28 14:28 ` [PATCH v7 3/4] notes.c: introduce '--separator=<paragraph-break>' option Teng Long
2023-03-28 15:37 ` Junio C Hamano
2023-03-29 14:15 ` Teng Long
2023-03-29 21:48 ` Junio C Hamano
2023-04-13 9:36 ` Teng Long
2023-03-28 14:28 ` [PATCH v7 4/4] notes.c: don't do stripespace when parse file arg Teng Long
2023-03-28 15:54 ` Junio C Hamano
2023-03-29 12:06 ` Teng Long
2023-03-29 16:21 ` Junio C Hamano
2023-04-25 13:34 ` Teng Long [this message]
2023-04-25 13:34 ` [PATCH v8 1/6] notes.c: cleanup 'strbuf_grow' call in 'append_edit' Teng Long
2023-04-25 13:34 ` [PATCH v8 2/6] notes.c: use designated initializers for clarity Teng Long
2023-04-25 13:34 ` [PATCH v8 3/6] t3321: add test cases about the notes stripspace behavior Teng Long
2023-04-25 16:25 ` Junio C Hamano
2023-04-27 3:47 ` Teng Long
2023-04-25 13:34 ` [PATCH v8 4/6] notes.c: introduce '--separator=<paragraph-break>' option Teng Long
2023-04-25 17:34 ` Junio C Hamano
2023-04-27 7:21 ` Teng Long
2023-04-27 18:21 ` Junio C Hamano
2023-04-25 17:35 ` Junio C Hamano
2023-04-25 13:34 ` [PATCH v8 5/6] notes.c: append separator instead of insert by pos Teng Long
2023-04-25 17:47 ` Junio C Hamano
2023-04-27 7:51 ` Teng Long
2023-04-25 13:34 ` [PATCH v8 6/6] notes.c: introduce "--[no-]stripspace" option Teng Long
2023-04-25 17:49 ` Junio C Hamano
2023-04-28 7:40 ` Teng Long
2023-04-28 18:21 ` Junio C Hamano
2023-04-28 9:23 ` [PATCH v9 0/6] notes.c: introduce "--separator" option Teng Long
2023-04-28 9:23 ` [PATCH v9 1/6] notes.c: cleanup 'strbuf_grow' call in 'append_edit' Teng Long
2023-04-28 9:23 ` [PATCH v9 2/6] notes.c: use designated initializers for clarity Teng Long
2023-04-28 9:23 ` [PATCH v9 3/6] t3321: add test cases about the notes stripspace behavior Teng Long
2023-04-28 9:23 ` [PATCH v9 4/6] notes.c: introduce '--separator=<paragraph-break>' option Teng Long
2023-04-28 20:44 ` Junio C Hamano
2023-05-06 9:12 ` Teng Long
2023-05-06 9:22 ` Teng Long
2023-05-10 19:19 ` Kristoffer Haugsbakk
2023-05-12 4:07 ` Teng Long
2023-05-12 7:29 ` Kristoffer Haugsbakk
2023-05-16 17:00 ` Junio C Hamano
2023-05-17 3:58 ` Teng Long
2023-05-17 15:32 ` Junio C Hamano
2023-06-14 1:02 ` Junio C Hamano
2023-06-14 1:10 ` [PATCH] notes: do not access before the beginning of an array Junio C Hamano
2023-06-14 1:41 ` [PATCH v9 4/6] notes.c: introduce '--separator=<paragraph-break>' option Eric Sunshine
2023-06-14 2:07 ` Junio C Hamano
2023-06-15 7:13 ` Jeff King
2023-06-15 19:15 ` Junio C Hamano
2023-06-19 6:08 ` Teng Long
2023-06-20 20:36 ` Junio C Hamano
2023-06-21 2:50 ` Teng Long
2023-04-28 9:23 ` [PATCH v9 5/6] notes.c: append separator instead of insert by pos Teng Long
2023-04-28 9:23 ` [PATCH v9 6/6] notes.c: introduce "--[no-]stripspace" option Teng Long
2023-04-28 20:46 ` [PATCH v9 0/6] notes.c: introduce "--separator" option Junio C Hamano
2023-05-01 22:29 ` Junio C Hamano
2023-05-18 12:02 ` [PATCH v10 " Teng Long
2023-05-18 12:02 ` [PATCH v10 1/6] notes.c: cleanup 'strbuf_grow' call in 'append_edit' Teng Long
2023-05-18 12:02 ` [PATCH v10 2/6] notes.c: use designated initializers for clarity Teng Long
2023-05-18 12:02 ` [PATCH v10 3/6] t3321: add test cases about the notes stripspace behavior Teng Long
2023-05-18 12:02 ` [PATCH v10 4/6] notes.c: introduce '[--[no-]separator|--separator=<paragraph-break>]' option Teng Long
2023-05-18 14:34 ` Kristoffer Haugsbakk
2023-05-20 10:41 ` Teng Long
2023-05-20 16:12 ` Kristoffer Haugsbakk
2023-05-19 0:54 ` Jeff King
2023-05-27 7:17 ` Teng Long
2023-05-27 17:19 ` Jeff King
2023-05-29 11:48 ` Teng Long
2023-05-18 12:02 ` [PATCH v10 5/6] notes.c: append separator instead of insert by pos Teng Long
2023-05-18 12:02 ` [PATCH v10 6/6] notes.c: introduce "--[no-]stripspace" option Teng Long
2023-05-18 13:56 ` [PATCH v10 0/6] notes.c: introduce "--separator" option Kristoffer Haugsbakk
2023-05-20 10:22 ` Teng Long
2023-05-18 15:17 ` Junio C Hamano
2023-05-20 10:59 ` Teng Long
2023-05-27 7:57 ` [PATCH v11 0/7] notes.c: introduce "--separator" Teng Long
2023-05-27 7:57 ` [PATCH v11 1/7] notes.c: cleanup 'strbuf_grow' call in 'append_edit' Teng Long
2023-05-27 7:57 ` [PATCH v11 2/7] notes.c: use designated initializers for clarity Teng Long
2023-05-27 7:57 ` [PATCH v11 3/7] t3321: add test cases about the notes stripspace behavior Teng Long
2023-05-27 7:57 ` [PATCH v11 4/7] notes.c: introduce '--separator=<paragraph-break>' option Teng Long
2023-05-27 7:57 ` [PATCH v11 5/7] notes.c: append separator instead of insert by pos Teng Long
2023-05-27 7:57 ` [PATCH v11 6/7] notes.c: introduce "--[no-]stripspace" option Teng Long
2023-05-27 7:57 ` [PATCH v11 7/7] notes: introduce "--no-separator" option Teng Long
2023-06-01 5:50 ` [PATCH v11 0/7] notes.c: introduce "--separator" Junio C Hamano
2023-06-03 10:01 ` Teng Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1682429602.git.dyroneteng@gmail.com \
--to=dyroneteng@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
--cc=tenglong.tl@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).