From: Teng Long <dyroneteng@gmail.com>
To: dyroneteng@gmail.com
Cc: avarab@gmail.com, git@vger.kernel.org, sunshine@sunshineco.com,
tenglong.tl@alibaba-inc.com, gitster@pobox.com
Subject: [PATCH v6 0/3] notes.c: introduce "--separator" option
Date: Thu, 23 Feb 2023 15:29:44 +0800 [thread overview]
Message-ID: <cover.1677136319.git.dyroneteng@gmail.com> (raw)
In-Reply-To: <cover.1676551077.git.dyroneteng@gmail.com>
From: Teng Long <dyroneteng@gmail.com>
Diff since v5:
1. Optimized and fixed the commit-message problems.
2. Optimized and fixed the related documentation.
3. the order of "-m" and -F should matter, but not, it was newly
introduced problem in v4, now fixed in v5.
By the way, In order to add a separator when parsing '-F and
'-m', I used 'string_list' to save all messages for subsequent
processing instead of processing in callback, because the value
of '--separator' has not been initialized and set at this time and
I have not found a similar "OPT_XXX" API for doing this. I'm not
sure if it's worth adding a similar API to parse the value of an
option in advance and initialize it for this scenario. If so, it
may not be suitable to continue to incubate in the current patch
series, but I will try to contribute it.
Thanks.
Teng Long (3):
notes.c: cleanup 'strbuf_grow' call in 'append_edit'
notes.c: cleanup for "designated init"
notes.c: introduce '--separator=<paragraph-break>' option
Documentation/git-notes.txt | 20 ++++++--
builtin/notes.c | 78 ++++++++++++++++++----------
t/t3301-notes.sh | 100 ++++++++++++++++++++++++++++++++++++
3 files changed, 168 insertions(+), 30 deletions(-)
Range-diff against v5:
1: 9a450669 ! 1: b029ee0b notes.c: cleanup 'strbuf_grow' call in 'append_edit'
@@ Commit message
needed, but actually when inserting, "strbuf_insertstr(&d.buf, 0,
"\n");" will do the "grow" for us.
- Best guess may be that the author originally inserted "\n" manually by
- direct manipulation of the strbuf rather than employing a strbuf
- function, but then switched to strbuf_insert() before submitting the
- series and forgot to remove the now-unnecessary strbuf_grow().
+ 348f199b (builtin-notes: Refactor handling of -F option to allow
+ combining -m and -F, 2010-02-13) added these to mimic the code
+ introduced by 2347fae5 (builtin-notes: Add "append" subcommand for
+ appending to note objects, 2010-02-13) that reads in previous note
+ before the message. And the resulting code with explicit sizing is
+ carried to this day.
+
+ In the context of reading an existing note in, exact sizing may have
+ made sense, but because the resulting note needs cleansing with
+ stripspace() when appending with this option, such an exact sizing
+ does not buy us all that much in practice.
+
+ It may help avoiding overallocation due to ALLOC_GROW() slop, but
+ nobody can feed so many long messages for it to matter from the
+ command line.
Signed-off-by: Teng Long <dyroneteng@gmail.com>
Helped-by: Eric Sunshine <sunshine@sunshineco.com>
+ Helped-by: Junio C Hamano <gitster@pobox.com>
## builtin/notes.c ##
@@ builtin/notes.c: static int parse_msg_arg(const struct option *opt, const char *arg, int unset)
2: e7bc6060 ! 2: 043db631 notes.c: cleanup for "designated init"
@@ Commit message
The "struct note_data d = { 0, 0, NULL, STRBUF_INIT };" style could be
replaced with designated init format.
+ Signed-off-by: Teng Long <dyroneteng@gmail.com>
+
## builtin/notes.c ##
@@ builtin/notes.c: static int add(int argc, const char **argv, const char *prefix)
struct notes_tree *t;
3: a74c96d6 ! 3: d5a6c747 notes.c: introduce "--separator" option
@@ Metadata
Author: Teng Long <dyroneteng@gmail.com>
## Commit message ##
- notes.c: introduce "--separator" option
+ notes.c: introduce '--separator=<paragraph-break>' option
- When appending to a given notes object and the appended note is not
- empty too, we will insert a blank line at first which separates the
- existing note and the appended one, which as the separator.
+ When adding new notes or appending to an existing notes, we will
+ insert a blank line between the paragraphs, like:
- Sometimes, we want to use a specified <separator> as the separator. For
- example, if we specify as:
+ $ git notes add -m foo -m bar
+ $ git notes show HEAD | cat
+ foo
- * --separator='------': we will insert "------\n" as the separator,
- because user do not provide the line break char at last, we will add
- the trailing '\n' compatibly.
+ bar
- * --separator='------\n': we will insert as-is because it contains
- the line break at last.
+ The default behavour sometimes is not enough, the user may want
+ to use a custom delimiter between paragraphs, like when
+ specifiy one or more '-m' or '-F' options. So this commit
+ introduces a new '--separator' option for 'git-notes-add' and
+ 'git-notes-append', for example when execute:
- * not specified --separator option: will use '\n' as the separator
- when do appending and this is the default behavour.
+ $ git notes add -m foo -m bar --separator="-"
+ $ git notes show HEAD | cat
+ foo
+ -
+ bar
- * --separator='': we specify an empty separator which has the same
- behavour with --separator='\n' and or not specified the option.
+ We will check the option value and if the value doesn't contail
+ a trailing '\n', will add it automatically, so execute
- In addition, if a user specifies multple "-m" with "--separator", the
- separator should be inserted between the messages too, so we use
- OPT_STRING_LIST instead of OPT_CALLBACK_F to parse "-m" option, make
- sure the option value of "--separator" been parsed already when we need
- it.
+ $ git notes add -m foo -m bar --separator="-"
+ and
+ $ export LF="
+ "
+ $ git notes add -m foo -m bar --separator="-$LF"
+
+ have the same behavour.
Signed-off-by: Teng Long <dyroneteng@gmail.com>
## Documentation/git-notes.txt ##
@@ Documentation/git-notes.txt: SYNOPSIS
+ --------
+ [verse]
'git notes' [list [<object>]]
- 'git notes' add [-f] [--allow-empty] [-F <file> | -m <msg> | (-c | -C) <object>] [<object>]
+-'git notes' add [-f] [--allow-empty] [-F <file> | -m <msg> | (-c | -C) <object>] [<object>]
++'git notes' add [-f] [--allow-empty] [--separator=<paragraph-break>] [-F <file> | -m <msg> | (-c | -C) <object>] [<object>]
'git notes' copy [-f] ( --stdin | <from-object> [<to-object>] )
-'git notes' append [--allow-empty] [-F <file> | -m <msg> | (-c | -C) <object>] [<object>]
-+'git notes' append [--allow-empty] [--separator] [-F <file> | -m <msg> | (-c | -C) <object>] [<object>]
++'git notes' append [--allow-empty] [--separator=<paragraph-break>] [-F <file> | -m <msg> | (-c | -C) <object>] [<object>]
'git notes' edit [--allow-empty] [<object>]
'git notes' show [<object>]
'git notes' merge [-v | -q] [-s <strategy> ] <notes-ref>
+@@ Documentation/git-notes.txt: add::
+ However, if you're using `add` interactively (using an editor
+ to supply the notes contents), then - instead of aborting -
+ the existing notes will be opened in the editor (like the `edit`
+- subcommand).
++ subcommand). If you specify multiple `-m` and `-F`, a blank
++ line will be inserted between the messages. Use the `--separator`
++ option to insert other delimiters.
+
+ copy::
+ Copy the notes for the first object onto the second object (defaults to
@@ Documentation/git-notes.txt: the command can read the input given to the `post-rewrite` hook.)
append::
Append to the notes of an existing object (defaults to HEAD).
- Creates a new notes object if needed.
-+ Creates a new notes object if needed. If the note and the
-+ message are not empty, "\n" will be inserted between them.
-+ Use the `--separator` option to insert other delimiters.
++ Creates a new notes object if needed.
++ The default delimiter is a blank line, use the `--separator`
++ option to insert other delimiters. More specifically, if the
++ note and the message are not empty, the delimiter will be
++ inserted between them. If you specify multiple `-m` and `-F`
++ options, the delimiter will be inserted between the messages
++ too.
edit::
Edit the notes for a given object (defaults to HEAD).
@@ Documentation/git-notes.txt: OPTIONS
Allow an empty note object to be stored. The default behavior is
to automatically remove empty notes.
-+--separator <separator>::
-+ The '<separator>' inserted between the note and message
-+ by 'append', "\n" by default. A custom separator can be
-+ provided, if it doesn't end in a "\n", one will be added
-+ implicitly .
++--separator <paragraph-break>::
++ The '<paragraph-break>' inserted between paragraphs.
++ A blank line by default.
+
--ref <ref>::
Manipulate the notes tree in <ref>. This overrides
@@ builtin/notes.c
+static char *separator = NULL;
static const char * const git_notes_usage[] = {
N_("git notes [--ref <notes-ref>] [list [<object>]]"),
- N_("git notes [--ref <notes-ref>] add [-f] [--allow-empty] [-m <msg> | -F <file> | (-c | -C) <object>] [<object>]"),
+- N_("git notes [--ref <notes-ref>] add [-f] [--allow-empty] [-m <msg> | -F <file> | (-c | -C) <object>] [<object>]"),
++ N_("git notes [--ref <notes-ref>] add [-f] [--allow-empty] [--separator=<paragraph-break>] [-m <msg> | -F <file> | (-c | -C) <object>] [<object>]"),
+ N_("git notes [--ref <notes-ref>] copy [-f] <from-object> <to-object>"),
+- N_("git notes [--ref <notes-ref>] append [--allow-empty] [-m <msg> | -F <file> | (-c | -C) <object>] [<object>]"),
++ N_("git notes [--ref <notes-ref>] append [--allow-empty] [--separator=<paragraph-break>] [-m <msg> | -F <file> | (-c | -C) <object>] [<object>]"),
+ N_("git notes [--ref <notes-ref>] edit [--allow-empty] [<object>]"),
+ N_("git notes [--ref <notes-ref>] show [<object>]"),
+ N_("git notes [--ref <notes-ref>] merge [-v | -q] [-s <strategy>] <notes-ref>"),
@@ builtin/notes.c: static void write_note_data(struct note_data *d, struct object_id *oid)
}
}
@@ builtin/notes.c: static void write_note_data(struct note_data *d, struct object_
+ else
+ strbuf_insertf(message, pos, "%s%s", separator, "\n");
+}
++
++static void parse_messages(struct string_list *messages, struct note_data *d)
++{
++ size_t i;
++ for (i = 0; i < messages->nr; i++) {
++ if (d->buf.len)
++ insert_separator(&d->buf, d->buf.len);
++ strbuf_insertstr(&d->buf, d->buf.len,
++ messages->items[i].string);
++ strbuf_stripspace(&d->buf, 0);
++ d->given = 1;
++ }
++}
+
static int parse_msg_arg(const struct option *opt, const char *arg, int unset)
{
- struct note_data *d = opt->value;
-@@ builtin/notes.c: static int append_edit(int argc, const char **argv, const char *prefix)
+- struct note_data *d = opt->value;
++ struct string_list *msg = opt->value;
+
+ BUG_ON_OPT_NEG(unset);
+
+- if (d->buf.len)
+- strbuf_addch(&d->buf, '\n');
+- strbuf_addstr(&d->buf, arg);
+- strbuf_stripspace(&d->buf, 0);
+-
+- d->given = 1;
++ string_list_append(msg, arg);
+ return 0;
+ }
+
++
+ static int parse_file_arg(const struct option *opt, const char *arg, int unset)
+ {
+- struct note_data *d = opt->value;
++ struct string_list *msg = opt->value;
++ struct strbuf buf = STRBUF_INIT;
+
+ BUG_ON_OPT_NEG(unset);
+
+- if (d->buf.len)
+- strbuf_addch(&d->buf, '\n');
+ if (!strcmp(arg, "-")) {
+- if (strbuf_read(&d->buf, 0, 1024) < 0)
++ if (strbuf_read(&buf, 0, 1024) < 0)
+ die_errno(_("cannot read '%s'"), arg);
+- } else if (strbuf_read_file(&d->buf, arg, 1024) < 0)
++ } else if (strbuf_read_file(&buf, arg, 1024) < 0)
+ die_errno(_("could not open or read '%s'"), arg);
+- strbuf_stripspace(&d->buf, 0);
+
+- d->given = 1;
++ string_list_append(msg, buf.buf);
++ strbuf_release(&buf);
+ return 0;
+ }
+
+@@ builtin/notes.c: static int add(int argc, const char **argv, const char *prefix)
+ struct object_id object, new_note;
const struct object_id *note;
+ struct note_data d = { .buf = STRBUF_INIT };
++ struct string_list messages = STRING_LIST_INIT_DUP;
+ struct option options[] = {
+- OPT_CALLBACK_F('m', "message", &d, N_("message"),
++ OPT_CALLBACK_F('m', "message", &messages, N_("message"),
+ N_("note contents as a string"), PARSE_OPT_NONEG,
+ parse_msg_arg),
+- OPT_CALLBACK_F('F', "file", &d, N_("file"),
++ OPT_CALLBACK_F('F', "file", &messages, N_("file"),
+ N_("note contents in a file"), PARSE_OPT_NONEG,
+ parse_file_arg),
+ OPT_CALLBACK_F('c', "reedit-message", &d, N_("object"),
+@@ builtin/notes.c: static int add(int argc, const char **argv, const char *prefix)
+ OPT_BOOL(0, "allow-empty", &allow_empty,
+ N_("allow storing empty note")),
+ OPT__FORCE(&force, N_("replace existing notes"), PARSE_OPT_NOCOMPLETE),
++ OPT_STRING(0, "separator", &separator, N_("separator"),
++ N_("insert <paragraph-break> between paragraphs")),
+ OPT_END()
+ };
+
+@@ builtin/notes.c: static int add(int argc, const char **argv, const char *prefix)
+ usage_with_options(git_notes_add_usage, options);
+ }
+
++ parse_messages(&messages, &d);
+ object_ref = argc > 1 ? argv[1] : "HEAD";
+
+ if (get_oid(object_ref, &object))
+@@ builtin/notes.c: static int append_edit(int argc, const char **argv, const char *prefix)
char *logmsg;
const char * const *usage;
-+ size_t message_idx;
struct note_data d = { .buf = STRBUF_INIT };
-+ struct string_list message = STRING_LIST_INIT_DUP;
++ struct string_list messages = STRING_LIST_INIT_DUP;
struct option options[] = {
- OPT_CALLBACK_F('m', "message", &d, N_("message"),
- N_("note contents as a string"), PARSE_OPT_NONEG,
-- parse_msg_arg),
-+ OPT_STRING_LIST('m', "message", &message, N_("message"),
-+ N_("note contents as a string")),
- OPT_CALLBACK_F('F', "file", &d, N_("file"),
++ OPT_CALLBACK_F('m', "message", &messages, N_("message"),
++ N_("note contents as a string"), PARSE_OPT_NONEG,
+ parse_msg_arg),
+- OPT_CALLBACK_F('F', "file", &d, N_("file"),
++ OPT_CALLBACK_F('F', "file", &messages, N_("file"),
N_("note contents in a file"), PARSE_OPT_NONEG,
parse_file_arg),
+ OPT_CALLBACK_F('c', "reedit-message", &d, N_("object"),
@@ builtin/notes.c: static int append_edit(int argc, const char **argv, const char *prefix)
parse_reuse_arg),
OPT_BOOL(0, "allow-empty", &allow_empty,
N_("allow storing empty note")),
+ OPT_STRING(0, "separator", &separator, N_("separator"),
-+ N_("insert <separator> as separator before appending a message")),
++ N_("insert <paragraph-break> between paragraphs")),
OPT_END()
};
int edit = !strcmp(argv[0], "edit");
@@ builtin/notes.c: static int append_edit(int argc, const char **argv, const char
usage_with_options(usage, options);
}
-+ for (message_idx = 0; message_idx < message.nr; message_idx++) {
-+ if (d.buf.len)
-+ insert_separator(&d.buf, d.buf.len);
-+ strbuf_insertstr(&d.buf, d.buf.len,
-+ message.items[message_idx].string);
-+ strbuf_stripspace(&d.buf, 0);
-+ d.given = 1;
-+ }
++ parse_messages(&messages, &d);
+
if (d.given && edit)
fprintf(stderr, _("The -m/-F/-c/-C options have been deprecated "
@@ builtin/notes.c: static int append_edit(int argc, const char **argv, const char
free(prev_buf);
## t/t3301-notes.sh ##
+@@ t/t3301-notes.sh: test_expect_success 'do not create empty note with -m ""' '
+ '
+
+ test_expect_success 'create note with combination of -m and -F' '
++ test_when_finished git notes remove HEAD &&
+ cat >expect-combine_m_and_F <<-EOF &&
+ foo
+
+@@ t/t3301-notes.sh: test_expect_success 'create note with combination of -m and -F' '
+ test_cmp expect-combine_m_and_F actual
+ '
+
++test_expect_success 'create note with combination of -m and -F and --separator' '
++ cat >expect-combine_m_and_F <<-\EOF &&
++ foo
++ -------
++ xyzzy
++ -------
++ bar
++ -------
++ zyxxy
++ -------
++ baz
++ EOF
++ echo "xyzzy" >note_a &&
++ echo "zyxxy" >note_b &&
++ git notes add -m "foo" -F note_a -m "bar" -F note_b -m "baz" --separator "-------" &&
++ git notes show >actual &&
++ test_cmp expect-combine_m_and_F actual
++
++'
++
+ test_expect_success 'remove note with "git notes remove"' '
+ git notes remove HEAD^ &&
+ git notes remove &&
@@ t/t3301-notes.sh: test_expect_success 'listing non-existing notes fails' '
test_must_be_empty actual
'
@@ t/t3301-notes.sh: test_expect_success 'listing non-existing notes fails' '
+ test_cmp expect actual
+'
+
-+test_expect_success 'append: specify separatoro with line break' '
++test_expect_success 'append: specify separator with line break' '
+ test_when_finished git notes remove HEAD &&
+ cat >expect <<-\EOF &&
+ notes-1
@@ t/t3301-notes.sh: test_expect_success 'listing non-existing notes fails' '
+ git notes show >actual &&
+ test_cmp expect actual
+'
++
++test_expect_success 'append note with combination of -m and -F and --separator' '
++ test_when_finished git notes remove HEAD &&
++ cat >expect-combine_m_and_F <<-\EOF &&
++ m-notes-1
++ -------
++ f-notes-1
++ -------
++ m-notes-2
++ -------
++ f-notes-2
++ -------
++ m-notes-3
++ EOF
++
++ echo "f-notes-1" >note_a &&
++ echo "f-notes-2" >note_b &&
++ git notes append -m "m-notes-1" -F note_a -m "m-notes-2" -F note_b -m "m-notes-3" --separator "-------" &&
++ git notes show >actual &&
++ test_cmp expect-combine_m_and_F actual
++'
+
test_expect_success 'append to existing note with "git notes append"' '
cat >expect <<-EOF &&
--
2.39.2.459.gd5a6c747
next prev parent reply other threads:[~2023-02-23 7:30 UTC|newest]
Thread overview: 186+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 5:56 [RFC PATCH 0/2] notes.c: introduce "--no-blankline" option Teng Long
2022-10-13 5:56 ` [RFC PATCH 1/2] " Teng Long
2022-10-13 6:06 ` Junio C Hamano
2022-10-17 13:19 ` Teng Long
2022-10-13 9:31 ` Ævar Arnfjörð Bjarmason
2022-10-17 13:33 ` Teng Long
2022-10-13 5:56 ` [RFC PATCH 2/2] notes.c: fixed tip when target and append note are both empty Teng Long
2022-10-13 9:36 ` Ævar Arnfjörð Bjarmason
2022-10-13 10:10 ` Phillip Wood
2022-10-13 10:23 ` Ævar Arnfjörð Bjarmason
2022-10-15 19:40 ` Phillip Wood
2022-10-18 3:25 ` Teng Long
2022-10-18 8:08 ` Teng Long
2022-10-18 3:11 ` Teng Long
2022-10-18 9:23 ` Ævar Arnfjörð Bjarmason
2022-11-07 13:57 ` [PATCH v2 0/3] notes.c: introduce "--blank-line" option Teng Long
2022-11-07 13:57 ` [PATCH v2 1/3] " Teng Long
2022-11-07 14:45 ` Ævar Arnfjörð Bjarmason
2022-11-07 15:45 ` Eric Sunshine
2022-11-07 17:22 ` Ævar Arnfjörð Bjarmason
2022-11-07 21:46 ` Taylor Blau
2022-11-07 22:36 ` Ævar Arnfjörð Bjarmason
2022-11-08 0:32 ` Taylor Blau
2022-11-08 3:45 ` Teng Long
2022-11-08 13:06 ` Teng Long
2022-11-08 13:22 ` Ævar Arnfjörð Bjarmason
2022-11-09 6:35 ` Teng Long
2022-11-07 15:06 ` Ævar Arnfjörð Bjarmason
2022-11-08 6:32 ` Teng Long
2022-11-07 21:47 ` Taylor Blau
2022-11-08 7:36 ` Teng Long
2022-11-07 13:57 ` [PATCH v2 2/3] notes.c: fixed tip when target and append note are both empty Teng Long
2022-11-07 14:40 ` Ævar Arnfjörð Bjarmason
2022-11-07 21:51 ` Taylor Blau
2022-11-07 22:33 ` Ævar Arnfjörð Bjarmason
2022-11-07 22:45 ` Taylor Blau
2022-11-08 8:55 ` Teng Long
2022-11-07 13:57 ` [PATCH v2 3/3] notes.c: drop unreachable code in "append_edit()" Teng Long
2022-11-07 14:41 ` Ævar Arnfjörð Bjarmason
2022-11-07 14:57 ` [PATCH v2 0/3] notes.c: introduce "--blank-line" option Ævar Arnfjörð Bjarmason
2022-11-09 7:05 ` Teng Long
2022-11-09 7:06 ` Teng Long
2022-11-09 9:06 ` [PATCH v3 0/5] notes.c: introduce "--no-blank-line" option Teng Long
2022-11-09 9:06 ` [PATCH v3 1/5] notes.c: cleanup 'strbuf_grow' call in 'append_edit' Teng Long
2022-11-09 9:06 ` [PATCH v3 2/5] notes.c: cleanup for "designated init" and "char ptr init" Teng Long
2022-11-09 9:06 ` [PATCH v3 3/5] notes.c: drop unreachable code in 'append_edit()' Teng Long
2022-11-09 9:06 ` [PATCH v3 4/5] notes.c: provide tips when target and append note are both empty Teng Long
2022-11-09 9:06 ` [PATCH v3 5/5] notes.c: introduce "--no-blank-line" option Teng Long
2022-11-28 14:20 ` [PATCH v3 0/5] " Teng Long
2022-11-29 1:10 ` Junio C Hamano
2022-11-29 22:53 ` Taylor Blau
2022-11-29 12:57 ` Teng Long
2022-11-29 13:19 ` Junio C Hamano
2022-12-15 12:48 ` Teng Long
2022-12-19 3:03 ` Eric Sunshine
2022-12-21 9:16 ` Teng Long
2022-12-21 11:35 ` Junio C Hamano
2022-12-22 9:30 ` Teng Long
2022-12-23 1:36 ` Eric Sunshine
2023-01-12 2:48 ` [PATCH v4 0/5] notes.c: introduce "--separator" optio Teng Long
2023-01-12 2:48 ` [PATCH v4 1/5] notes.c: cleanup 'strbuf_grow' call in 'append_edit' Teng Long
2023-01-15 4:53 ` Eric Sunshine
2023-01-28 11:22 ` Teng Long
2023-01-12 2:48 ` [PATCH v4 2/5] notes.c: cleanup for "designated init" and "char ptr init" Teng Long
2023-01-12 9:51 ` Ævar Arnfjörð Bjarmason
2023-01-28 11:33 ` Teng Long
2023-01-12 2:48 ` [PATCH v4 3/5] notes.c: drop unreachable code in 'append_edit()' Teng Long
2023-01-15 20:59 ` Eric Sunshine
2023-01-15 21:10 ` Eric Sunshine
2023-01-28 11:50 ` Teng Long
2023-01-30 5:38 ` Eric Sunshine
2023-02-01 8:08 ` Teng Long
2023-01-12 2:48 ` [PATCH v4 4/5] notes.c: provide tips when target and append note are both empty Teng Long
2023-01-12 9:52 ` Ævar Arnfjörð Bjarmason
2023-01-15 21:28 ` Eric Sunshine
2023-01-12 2:48 ` [PATCH v4 5/5] notes.c: introduce "--separator" option Teng Long
2023-01-12 9:53 ` Ævar Arnfjörð Bjarmason
2023-01-15 22:04 ` Eric Sunshine
2023-01-15 22:15 ` Eric Sunshine
2023-02-16 13:05 ` [PATCH v5 0/3] " Teng Long
2023-02-16 13:05 ` [PATCH v5 1/3] notes.c: cleanup 'strbuf_grow' call in 'append_edit' Teng Long
2023-02-16 18:39 ` Junio C Hamano
2023-02-20 3:34 ` Teng Long
2023-02-16 13:05 ` [PATCH v5 2/3] notes.c: cleanup for "designated init" Teng Long
2023-02-16 18:39 ` Junio C Hamano
2023-02-16 13:05 ` [PATCH v5 3/3] notes.c: introduce "--separator" option Teng Long
2023-02-16 23:22 ` Junio C Hamano
2023-02-20 14:00 ` Teng Long
2023-02-21 21:31 ` Junio C Hamano
2023-02-22 8:17 ` Teng Long
2023-02-22 23:15 ` Junio C Hamano
2023-02-23 7:29 ` Teng Long [this message]
2023-02-23 7:29 ` [PATCH v6 1/3] notes.c: cleanup 'strbuf_grow' call in 'append_edit' Teng Long
2023-02-23 7:29 ` [PATCH v6 2/3] notes.c: cleanup for "designated init" Teng Long
2023-02-23 7:29 ` [PATCH v6 3/3] notes.c: introduce '--separator=<paragraph-break>' option Teng Long
2023-02-23 18:21 ` Junio C Hamano
2023-02-28 14:11 ` Teng Long
2023-02-25 21:30 ` Junio C Hamano
2023-02-28 14:14 ` Teng Long
2023-03-27 13:13 ` [PATCH v6 0/3] notes.c: introduce "--separator" option Teng Long
2023-03-28 14:28 ` [PATCH v7 0/4] " Teng Long
2023-03-28 14:28 ` [PATCH v7 1/4] notes.c: cleanup 'strbuf_grow' call in 'append_edit' Teng Long
2023-03-28 14:28 ` [PATCH v7 2/4] notes.c: cleanup for "designated init" Teng Long
2023-03-29 22:17 ` Junio C Hamano
2023-03-28 14:28 ` [PATCH v7 3/4] notes.c: introduce '--separator=<paragraph-break>' option Teng Long
2023-03-28 15:37 ` Junio C Hamano
2023-03-29 14:15 ` Teng Long
2023-03-29 21:48 ` Junio C Hamano
2023-04-13 9:36 ` Teng Long
2023-03-28 14:28 ` [PATCH v7 4/4] notes.c: don't do stripespace when parse file arg Teng Long
2023-03-28 15:54 ` Junio C Hamano
2023-03-29 12:06 ` Teng Long
2023-03-29 16:21 ` Junio C Hamano
2023-04-25 13:34 ` [PATCH 0/6] notes.c: introduce "--separator" option Teng Long
2023-04-25 13:34 ` [PATCH v8 1/6] notes.c: cleanup 'strbuf_grow' call in 'append_edit' Teng Long
2023-04-25 13:34 ` [PATCH v8 2/6] notes.c: use designated initializers for clarity Teng Long
2023-04-25 13:34 ` [PATCH v8 3/6] t3321: add test cases about the notes stripspace behavior Teng Long
2023-04-25 16:25 ` Junio C Hamano
2023-04-27 3:47 ` Teng Long
2023-04-25 13:34 ` [PATCH v8 4/6] notes.c: introduce '--separator=<paragraph-break>' option Teng Long
2023-04-25 17:34 ` Junio C Hamano
2023-04-27 7:21 ` Teng Long
2023-04-27 18:21 ` Junio C Hamano
2023-04-25 17:35 ` Junio C Hamano
2023-04-25 13:34 ` [PATCH v8 5/6] notes.c: append separator instead of insert by pos Teng Long
2023-04-25 17:47 ` Junio C Hamano
2023-04-27 7:51 ` Teng Long
2023-04-25 13:34 ` [PATCH v8 6/6] notes.c: introduce "--[no-]stripspace" option Teng Long
2023-04-25 17:49 ` Junio C Hamano
2023-04-28 7:40 ` Teng Long
2023-04-28 18:21 ` Junio C Hamano
2023-04-28 9:23 ` [PATCH v9 0/6] notes.c: introduce "--separator" option Teng Long
2023-04-28 9:23 ` [PATCH v9 1/6] notes.c: cleanup 'strbuf_grow' call in 'append_edit' Teng Long
2023-04-28 9:23 ` [PATCH v9 2/6] notes.c: use designated initializers for clarity Teng Long
2023-04-28 9:23 ` [PATCH v9 3/6] t3321: add test cases about the notes stripspace behavior Teng Long
2023-04-28 9:23 ` [PATCH v9 4/6] notes.c: introduce '--separator=<paragraph-break>' option Teng Long
2023-04-28 20:44 ` Junio C Hamano
2023-05-06 9:12 ` Teng Long
2023-05-06 9:22 ` Teng Long
2023-05-10 19:19 ` Kristoffer Haugsbakk
2023-05-12 4:07 ` Teng Long
2023-05-12 7:29 ` Kristoffer Haugsbakk
2023-05-16 17:00 ` Junio C Hamano
2023-05-17 3:58 ` Teng Long
2023-05-17 15:32 ` Junio C Hamano
2023-06-14 1:02 ` Junio C Hamano
2023-06-14 1:10 ` [PATCH] notes: do not access before the beginning of an array Junio C Hamano
2023-06-14 1:41 ` [PATCH v9 4/6] notes.c: introduce '--separator=<paragraph-break>' option Eric Sunshine
2023-06-14 2:07 ` Junio C Hamano
2023-06-15 7:13 ` Jeff King
2023-06-15 19:15 ` Junio C Hamano
2023-06-19 6:08 ` Teng Long
2023-06-20 20:36 ` Junio C Hamano
2023-06-21 2:50 ` Teng Long
2023-04-28 9:23 ` [PATCH v9 5/6] notes.c: append separator instead of insert by pos Teng Long
2023-04-28 9:23 ` [PATCH v9 6/6] notes.c: introduce "--[no-]stripspace" option Teng Long
2023-04-28 20:46 ` [PATCH v9 0/6] notes.c: introduce "--separator" option Junio C Hamano
2023-05-01 22:29 ` Junio C Hamano
2023-05-18 12:02 ` [PATCH v10 " Teng Long
2023-05-18 12:02 ` [PATCH v10 1/6] notes.c: cleanup 'strbuf_grow' call in 'append_edit' Teng Long
2023-05-18 12:02 ` [PATCH v10 2/6] notes.c: use designated initializers for clarity Teng Long
2023-05-18 12:02 ` [PATCH v10 3/6] t3321: add test cases about the notes stripspace behavior Teng Long
2023-05-18 12:02 ` [PATCH v10 4/6] notes.c: introduce '[--[no-]separator|--separator=<paragraph-break>]' option Teng Long
2023-05-18 14:34 ` Kristoffer Haugsbakk
2023-05-20 10:41 ` Teng Long
2023-05-20 16:12 ` Kristoffer Haugsbakk
2023-05-19 0:54 ` Jeff King
2023-05-27 7:17 ` Teng Long
2023-05-27 17:19 ` Jeff King
2023-05-29 11:48 ` Teng Long
2023-05-18 12:02 ` [PATCH v10 5/6] notes.c: append separator instead of insert by pos Teng Long
2023-05-18 12:02 ` [PATCH v10 6/6] notes.c: introduce "--[no-]stripspace" option Teng Long
2023-05-18 13:56 ` [PATCH v10 0/6] notes.c: introduce "--separator" option Kristoffer Haugsbakk
2023-05-20 10:22 ` Teng Long
2023-05-18 15:17 ` Junio C Hamano
2023-05-20 10:59 ` Teng Long
2023-05-27 7:57 ` [PATCH v11 0/7] notes.c: introduce "--separator" Teng Long
2023-05-27 7:57 ` [PATCH v11 1/7] notes.c: cleanup 'strbuf_grow' call in 'append_edit' Teng Long
2023-05-27 7:57 ` [PATCH v11 2/7] notes.c: use designated initializers for clarity Teng Long
2023-05-27 7:57 ` [PATCH v11 3/7] t3321: add test cases about the notes stripspace behavior Teng Long
2023-05-27 7:57 ` [PATCH v11 4/7] notes.c: introduce '--separator=<paragraph-break>' option Teng Long
2023-05-27 7:57 ` [PATCH v11 5/7] notes.c: append separator instead of insert by pos Teng Long
2023-05-27 7:57 ` [PATCH v11 6/7] notes.c: introduce "--[no-]stripspace" option Teng Long
2023-05-27 7:57 ` [PATCH v11 7/7] notes: introduce "--no-separator" option Teng Long
2023-06-01 5:50 ` [PATCH v11 0/7] notes.c: introduce "--separator" Junio C Hamano
2023-06-03 10:01 ` Teng Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1677136319.git.dyroneteng@gmail.com \
--to=dyroneteng@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
--cc=tenglong.tl@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).