From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Patrick Steinhardt <ps@pks.im>,
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH v2 1/2] for-each-repo: optionally keep going on an error
Date: Fri, 19 Apr 2024 13:56:21 -0400 [thread overview]
Message-ID: <20240419175621.GB14309@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqy199l4qf.fsf@gitster.g>
On Fri, Apr 19, 2024 at 09:03:20AM -0700, Junio C Hamano wrote:
> You mean that it could be a regression that we lose the raw return
> value from run_command_on_repo() when !keep_going?
>
> - git.c:handle_builtin() does exit(run_builtin(builtin, argc, argv));
> In this case, builtin is set to cmd_for_each_repo.
>
> - cmd_for_each_repo does "return result" at its end.
>
> - result comes from run_command_on_repo(), which returns the value
> returned by run_command().
>
> - run_command() returns -1 for "not found".
>
> So if run_command() failed due to missing command, we would have
> exited with 255 (= (unsigned)(-1) & 0xFF), but with this change we
> would now exit with 1.
>
> Passing anything outside 0..255 to exit(3) is a bad manners, and but
> this does change behaviour. Hmmm.
run_command() may also return the exit code of the program run. So
imagine a setup like:
git init
git config alias.foo '!exit 123'
git config repo.paths "$PWD"
git for-each-repo --config=repo.paths foo
echo $?
Before the patch we see "123" and after we see "1".
I do agree that passing -1 to exit is bad; we maybe should normalize to
127 for not found, though I think we could also see -1 for system errors
like fork() failing.
-Peff
next prev parent reply other threads:[~2024-04-19 17:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 8:28 [PATCH 0/2] Use a "best effort" strategy in scheduled maintenance Johannes Schindelin via GitGitGadget
2024-04-17 8:28 ` [PATCH 1/2] for-each-repo: optionally keep going on an error Johannes Schindelin via GitGitGadget
2024-04-17 8:36 ` Eric Sunshine
2024-04-17 15:38 ` Junio C Hamano
2024-04-17 8:28 ` [PATCH 2/2] maintenance: running maintenance should not stop on errors Johannes Schindelin via GitGitGadget
2024-04-17 15:41 ` Junio C Hamano
2024-04-17 15:36 ` [PATCH 0/2] Use a "best effort" strategy in scheduled maintenance Junio C Hamano
2024-04-18 12:53 ` [PATCH v2 " Johannes Schindelin via GitGitGadget
2024-04-18 12:53 ` [PATCH v2 1/2] for-each-repo: optionally keep going on an error Johannes Schindelin via GitGitGadget
2024-04-19 4:24 ` Patrick Steinhardt
2024-04-19 16:03 ` Junio C Hamano
2024-04-19 17:56 ` Jeff King [this message]
2024-04-22 21:39 ` Junio C Hamano
2024-04-18 12:53 ` [PATCH v2 2/2] maintenance: running maintenance should not stop on errors Johannes Schindelin via GitGitGadget
2024-04-24 16:14 ` [PATCH v3 0/2] Use a "best effort" strategy in scheduled maintenance Johannes Schindelin via GitGitGadget
2024-04-24 16:14 ` [PATCH v3 1/2] for-each-repo: optionally keep going on an error Johannes Schindelin via GitGitGadget
2024-04-24 17:02 ` Junio C Hamano
2024-04-24 16:14 ` [PATCH v3 2/2] maintenance: running maintenance should not stop on errors Johannes Schindelin via GitGitGadget
2024-04-25 6:36 ` [PATCH v3 0/2] Use a "best effort" strategy in scheduled maintenance Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240419175621.GB14309@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=ps@pks.im \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).