From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH v2 1/2] for-each-repo: optionally keep going on an error
Date: Fri, 19 Apr 2024 09:03:20 -0700 [thread overview]
Message-ID: <xmqqy199l4qf.fsf@gitster.g> (raw)
In-Reply-To: <ZiHyGFRPm_pwdGgC@tanuki> (Patrick Steinhardt's message of "Fri, 19 Apr 2024 06:24:56 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> On Thu, Apr 18, 2024 at 12:53:02PM +0000, Johannes Schindelin via GitGitGadget wrote:
>> From: Johannes Schindelin <johannes.schindelin@gmx.de>
> [snip]
>> @@ -55,8 +58,9 @@ int cmd_for_each_repo(int argc, const char **argv, const char *prefix)
>> else if (err)
>> return 0;
>>
>> - for (i = 0; !result && i < values->nr; i++)
>> - result = run_command_on_repo(values->items[i].string, argc, argv);
>> + for (i = 0; (keep_going || !result) && i < values->nr; i++)
>> + if (run_command_on_repo(values->items[i].string, argc, argv))
>> + result = 1;
>
> One thing that made me stop and think is whether the change in behaviour
> here may negatively impact some usecases. Before this change we would
> error out with the return code returned by the command that we have ran
> in repositories. It makes total sense that we don't do that anymore with
> `--keep-going`, because the result would likely be useless as all we
> could do was to OR the result codes with each other.
>
> But do we maybe want to make this conditional on whether or not the
> `--keep-going` flag is set? So something like this:
>
> ```
> for (i = 0; (keep_going || !result) && i < values->nr; i++) {
> int ret = run_command_on_repo(values->items[i].string, argc, argv);
> if (ret)
> result = keep_going ? 1 : ret;
> }
> ```
You mean that it could be a regression that we lose the raw return
value from run_command_on_repo() when !keep_going?
- git.c:handle_builtin() does exit(run_builtin(builtin, argc, argv));
In this case, builtin is set to cmd_for_each_repo.
- cmd_for_each_repo does "return result" at its end.
- result comes from run_command_on_repo(), which returns the value
returned by run_command().
- run_command() returns -1 for "not found".
So if run_command() failed due to missing command, we would have
exited with 255 (= (unsigned)(-1) & 0xFF), but with this change we
would now exit with 1.
Passing anything outside 0..255 to exit(3) is a bad manners, and but
this does change behaviour. Hmmm.
next prev parent reply other threads:[~2024-04-19 16:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 8:28 [PATCH 0/2] Use a "best effort" strategy in scheduled maintenance Johannes Schindelin via GitGitGadget
2024-04-17 8:28 ` [PATCH 1/2] for-each-repo: optionally keep going on an error Johannes Schindelin via GitGitGadget
2024-04-17 8:36 ` Eric Sunshine
2024-04-17 15:38 ` Junio C Hamano
2024-04-17 8:28 ` [PATCH 2/2] maintenance: running maintenance should not stop on errors Johannes Schindelin via GitGitGadget
2024-04-17 15:41 ` Junio C Hamano
2024-04-17 15:36 ` [PATCH 0/2] Use a "best effort" strategy in scheduled maintenance Junio C Hamano
2024-04-18 12:53 ` [PATCH v2 " Johannes Schindelin via GitGitGadget
2024-04-18 12:53 ` [PATCH v2 1/2] for-each-repo: optionally keep going on an error Johannes Schindelin via GitGitGadget
2024-04-19 4:24 ` Patrick Steinhardt
2024-04-19 16:03 ` Junio C Hamano [this message]
2024-04-19 17:56 ` Jeff King
2024-04-22 21:39 ` Junio C Hamano
2024-04-18 12:53 ` [PATCH v2 2/2] maintenance: running maintenance should not stop on errors Johannes Schindelin via GitGitGadget
2024-04-24 16:14 ` [PATCH v3 0/2] Use a "best effort" strategy in scheduled maintenance Johannes Schindelin via GitGitGadget
2024-04-24 16:14 ` [PATCH v3 1/2] for-each-repo: optionally keep going on an error Johannes Schindelin via GitGitGadget
2024-04-24 17:02 ` Junio C Hamano
2024-04-24 16:14 ` [PATCH v3 2/2] maintenance: running maintenance should not stop on errors Johannes Schindelin via GitGitGadget
2024-04-25 6:36 ` [PATCH v3 0/2] Use a "best effort" strategy in scheduled maintenance Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy199l4qf.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=ps@pks.im \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).