* [PATCH v2] media: dt-bindings: st-vgxy61: relax data-lanes restriction
@ 2024-03-15 9:03 Julien Massot
2024-03-15 9:22 ` Sakari Ailus
2024-03-15 11:36 ` Krzysztof Kozlowski
0 siblings, 2 replies; 4+ messages in thread
From: Julien Massot @ 2024-03-15 9:03 UTC (permalink / raw)
To: mchehab, sakari.ailus, benjamin.mugnier, sylvain.petinot
Cc: linux-media, kernel, Julien Massot
The ST VGXY61 sensors support multiple lane numbers, as
well as lane mapping.
---
Changes in v2:
Add minimum/maximum items to restrict lane index to 1..4.
---
.../devicetree/bindings/media/i2c/st,st-vgxy61.yaml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml b/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
index 8c28848b226a..a76434ecf23a 100644
--- a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
@@ -67,11 +67,11 @@ properties:
data-lanes:
description:
CSI lanes to use
+ minItems: 1
+ maxItems: 4
items:
- - const: 1
- - const: 2
- - const: 3
- - const: 4
+ minimum: 1
+ maximum: 4
remote-endpoint: true
--
2.44.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] media: dt-bindings: st-vgxy61: relax data-lanes restriction
2024-03-15 9:03 [PATCH v2] media: dt-bindings: st-vgxy61: relax data-lanes restriction Julien Massot
@ 2024-03-15 9:22 ` Sakari Ailus
2024-03-29 8:32 ` Benjamin Mugnier
2024-03-15 11:36 ` Krzysztof Kozlowski
1 sibling, 1 reply; 4+ messages in thread
From: Sakari Ailus @ 2024-03-15 9:22 UTC (permalink / raw)
To: Julien Massot
Cc: mchehab, benjamin.mugnier, sylvain.petinot, linux-media, kernel
Hi Julien,
On Fri, Mar 15, 2024 at 10:03:45AM +0100, Julien Massot wrote:
> The ST VGXY61 sensors support multiple lane numbers, as
> well as lane mapping.
Wow! This is the first time I see this on the sensor side. Should it be
separately mentioned?
The driver appears to be handling this already.
> ---
> Changes in v2:
> Add minimum/maximum items to restrict lane index to 1..4.
> ---
> .../devicetree/bindings/media/i2c/st,st-vgxy61.yaml | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml b/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
> index 8c28848b226a..a76434ecf23a 100644
> --- a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
> @@ -67,11 +67,11 @@ properties:
> data-lanes:
> description:
> CSI lanes to use
> + minItems: 1
> + maxItems: 4
> items:
> - - const: 1
> - - const: 2
> - - const: 3
> - - const: 4
> + minimum: 1
> + maximum: 4
>
> remote-endpoint: true
>
--
Regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] media: dt-bindings: st-vgxy61: relax data-lanes restriction
2024-03-15 9:03 [PATCH v2] media: dt-bindings: st-vgxy61: relax data-lanes restriction Julien Massot
2024-03-15 9:22 ` Sakari Ailus
@ 2024-03-15 11:36 ` Krzysztof Kozlowski
1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-15 11:36 UTC (permalink / raw)
To: Julien Massot, mchehab, sakari.ailus, benjamin.mugnier,
sylvain.petinot
Cc: linux-media, kernel
On 15/03/2024 10:03, Julien Massot wrote:
> The ST VGXY61 sensors support multiple lane numbers, as
> well as lane mapping.
> ---
> Changes in v2:
> Add minimum/maximum items to restrict lane index to 1..4.
> ---
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline), work on fork of kernel
(don't, instead use mainline) or you ignore some maintainers (really
don't). Just use b4 and everything should be fine, although remember
about `b4 prep --auto-to-cc` if you added new patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.
Please kindly resend and include all necessary To/Cc entries.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] media: dt-bindings: st-vgxy61: relax data-lanes restriction
2024-03-15 9:22 ` Sakari Ailus
@ 2024-03-29 8:32 ` Benjamin Mugnier
0 siblings, 0 replies; 4+ messages in thread
From: Benjamin Mugnier @ 2024-03-29 8:32 UTC (permalink / raw)
To: Sakari Ailus, Julien Massot; +Cc: mchehab, sylvain.petinot, linux-media, kernel
Hi Julien and Sakari,
On 3/15/24 10:22, Sakari Ailus wrote:
> Hi Julien,
>
> On Fri, Mar 15, 2024 at 10:03:45AM +0100, Julien Massot wrote:
>> The ST VGXY61 sensors support multiple lane numbers, as
>> well as lane mapping.
>
> Wow! This is the first time I see this on the sensor side. Should it be
> separately mentioned?
>
> The driver appears to be handling this already.
Yes it does :)
You could just add the "The ST VGXY61 sensors support multiple lane
numbers, as well as lane mapping." to the 'description' part.
With that :
Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
I'm not sure about who is required for a device tree patch to be merged
though.
>
>> ---
>> Changes in v2:
>> Add minimum/maximum items to restrict lane index to 1..4.
>> ---
>> .../devicetree/bindings/media/i2c/st,st-vgxy61.yaml | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml b/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
>> index 8c28848b226a..a76434ecf23a 100644
>> --- a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
>> +++ b/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
>> @@ -67,11 +67,11 @@ properties:
>> data-lanes:
>> description:
>> CSI lanes to use
>> + minItems: 1
>> + maxItems: 4
>> items:
>> - - const: 1
>> - - const: 2
>> - - const: 3
>> - - const: 4
>> + minimum: 1
>> + maximum: 4
>>
>> remote-endpoint: true
>>
>
--
Regards,
Benjamin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-29 8:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-15 9:03 [PATCH v2] media: dt-bindings: st-vgxy61: relax data-lanes restriction Julien Massot
2024-03-15 9:22 ` Sakari Ailus
2024-03-29 8:32 ` Benjamin Mugnier
2024-03-15 11:36 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.