From: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Julien Massot <julien.massot@collabora.com>
Cc: <mchehab@kernel.org>, <sylvain.petinot@foss.st.com>,
<linux-media@vger.kernel.org>, <kernel@collabora.com>
Subject: Re: [PATCH v2] media: dt-bindings: st-vgxy61: relax data-lanes restriction
Date: Fri, 29 Mar 2024 09:32:34 +0100 [thread overview]
Message-ID: <fa691a07-0c84-4fe0-8e3f-753e7fc41b7b@foss.st.com> (raw)
In-Reply-To: <ZfQTQ5U_iXEaKUjH@kekkonen.localdomain>
Hi Julien and Sakari,
On 3/15/24 10:22, Sakari Ailus wrote:
> Hi Julien,
>
> On Fri, Mar 15, 2024 at 10:03:45AM +0100, Julien Massot wrote:
>> The ST VGXY61 sensors support multiple lane numbers, as
>> well as lane mapping.
>
> Wow! This is the first time I see this on the sensor side. Should it be
> separately mentioned?
>
> The driver appears to be handling this already.
Yes it does :)
You could just add the "The ST VGXY61 sensors support multiple lane
numbers, as well as lane mapping." to the 'description' part.
With that :
Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
I'm not sure about who is required for a device tree patch to be merged
though.
>
>> ---
>> Changes in v2:
>> Add minimum/maximum items to restrict lane index to 1..4.
>> ---
>> .../devicetree/bindings/media/i2c/st,st-vgxy61.yaml | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml b/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
>> index 8c28848b226a..a76434ecf23a 100644
>> --- a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
>> +++ b/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
>> @@ -67,11 +67,11 @@ properties:
>> data-lanes:
>> description:
>> CSI lanes to use
>> + minItems: 1
>> + maxItems: 4
>> items:
>> - - const: 1
>> - - const: 2
>> - - const: 3
>> - - const: 4
>> + minimum: 1
>> + maximum: 4
>>
>> remote-endpoint: true
>>
>
--
Regards,
Benjamin
next prev parent reply other threads:[~2024-03-29 8:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 9:03 [PATCH v2] media: dt-bindings: st-vgxy61: relax data-lanes restriction Julien Massot
2024-03-15 9:22 ` Sakari Ailus
2024-03-29 8:32 ` Benjamin Mugnier [this message]
2024-03-15 11:36 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa691a07-0c84-4fe0-8e3f-753e7fc41b7b@foss.st.com \
--to=benjamin.mugnier@foss.st.com \
--cc=julien.massot@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sylvain.petinot@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.