From: Eduard Zingerman <eddyz87@gmail.com> To: Pu Lehui <pulehui@huaweicloud.com>, bpf@vger.kernel.org, linux-riscv@lists.infradead.org, netdev@vger.kernel.org Cc: "Björn Töpel" <bjorn@kernel.org>, "Alexei Starovoitov" <ast@kernel.org>, "Daniel Borkmann" <daniel@iogearbox.net>, "Andrii Nakryiko" <andrii@kernel.org>, "Martin KaFai Lau" <martin.lau@linux.dev>, "Song Liu" <song@kernel.org>, "Yonghong Song" <yhs@fb.com>, "John Fastabend" <john.fastabend@gmail.com>, "KP Singh" <kpsingh@kernel.org>, "Stanislav Fomichev" <sdf@google.com>, "Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>, "Mykola Lysenko" <mykolal@fb.com>, "Manu Bretelle" <chantr4@gmail.com>, "Pu Lehui" <pulehui@huawei.com> Subject: Re: [PATCH bpf-next 0/5] Support local vmtest for riscv64 Date: Wed, 03 Apr 2024 02:40:19 +0300 [thread overview] Message-ID: <f20d1e2a2f5fa10f29bf1fddbaf99c3f185e8530.camel@gmail.com> (raw) In-Reply-To: <52117f9c-b691-409f-ad2a-a25f53a9433d@huaweicloud.com> On Sat, 2024-03-30 at 18:12 +0800, Pu Lehui wrote: [...] > > Looks like I won't be able to test this patch-set, unless you have > > some writeup on how to create a riscv64 dev environment at hand. > > Sorry for the noise > > Yeah, environmental issues are indeed a developer's nightmare. I will > try to do something for the newcomers of riscv64 bpf. At present, I have > simply built a docker local vmtest environment [0] based on Bjorn's > riscv-cross-builder. We can directly run vmtest within this environment. > Hopefully it will help. > > Link: https://github.com/pulehui/riscv-cross-builder/tree/vmtest [0] Hi Pu, Thank you for sharing the docker file, I've managed to run the tests using it. In order to avoid creating files with root permissions I had to add the following lines at the end of the Dockerfile: + RUN useradd --no-create-home --uid 1000 eddy + RUN passwd -d eddy + RUN echo 'eddy ALL=(ALL) NOPASSWD:ALL' >> /etc/sudoers + # vmtest.sh does 'mount -o loop', + # ensure there is a loop device in the container + RUN mknod /dev/loop0 b 7 20 Where 'eddy' is my local user with UID 1000. Probably this should be made more generic. I used the following command to start the container: docker run -ti -u 1000:1000 \ --rm -v <path-to-kernel-dir>:/workspace \ -v <path-to-rootfs-image-dir>:/rootfs \ --privileged ubuntu-vmtest:latest /bin/bash Also, I had to add '-d /rootfs/bpf_selftests' option for vmtest.sh in order to avoid polluting user directory inside the container. Maybe OUTPUT_DIR for vmtest.sh should be mounted as a separate volume. I agree with Daniel, it would be great to document all of this somewhere in the repo (or even scripted somehow). Using the specified DENYLIST I get the following stats for test_progs: #3/2 arena_htab/arena_htab_asm:FAIL #3 arena_htab:FAIL #95 get_branch_snapshot:FAIL #172/1 perf_branches/perf_branches_hw:FAIL #172 perf_branches:FAIL #434/3 verifier_arena/basic_alloc3:FAIL #434 verifier_arena:FAIL Summary: 531/3581 PASSED, 64 SKIPPED, 4 FAILED Tested-by: Eduard Zingerman <eddyz87@gmail.com> > PS: Since the current rootfs of riscv64 is not in the INDEX, I simply > modified vmtest.sh to support local rootfs. Could you please add this change to the patch-set? [...] _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Eduard Zingerman <eddyz87@gmail.com> To: Pu Lehui <pulehui@huaweicloud.com>, bpf@vger.kernel.org, linux-riscv@lists.infradead.org, netdev@vger.kernel.org Cc: "Björn Töpel" <bjorn@kernel.org>, "Alexei Starovoitov" <ast@kernel.org>, "Daniel Borkmann" <daniel@iogearbox.net>, "Andrii Nakryiko" <andrii@kernel.org>, "Martin KaFai Lau" <martin.lau@linux.dev>, "Song Liu" <song@kernel.org>, "Yonghong Song" <yhs@fb.com>, "John Fastabend" <john.fastabend@gmail.com>, "KP Singh" <kpsingh@kernel.org>, "Stanislav Fomichev" <sdf@google.com>, "Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>, "Mykola Lysenko" <mykolal@fb.com>, "Manu Bretelle" <chantr4@gmail.com>, "Pu Lehui" <pulehui@huawei.com> Subject: Re: [PATCH bpf-next 0/5] Support local vmtest for riscv64 Date: Wed, 03 Apr 2024 02:40:19 +0300 [thread overview] Message-ID: <f20d1e2a2f5fa10f29bf1fddbaf99c3f185e8530.camel@gmail.com> (raw) In-Reply-To: <52117f9c-b691-409f-ad2a-a25f53a9433d@huaweicloud.com> On Sat, 2024-03-30 at 18:12 +0800, Pu Lehui wrote: [...] > > Looks like I won't be able to test this patch-set, unless you have > > some writeup on how to create a riscv64 dev environment at hand. > > Sorry for the noise > > Yeah, environmental issues are indeed a developer's nightmare. I will > try to do something for the newcomers of riscv64 bpf. At present, I have > simply built a docker local vmtest environment [0] based on Bjorn's > riscv-cross-builder. We can directly run vmtest within this environment. > Hopefully it will help. > > Link: https://github.com/pulehui/riscv-cross-builder/tree/vmtest [0] Hi Pu, Thank you for sharing the docker file, I've managed to run the tests using it. In order to avoid creating files with root permissions I had to add the following lines at the end of the Dockerfile: + RUN useradd --no-create-home --uid 1000 eddy + RUN passwd -d eddy + RUN echo 'eddy ALL=(ALL) NOPASSWD:ALL' >> /etc/sudoers + # vmtest.sh does 'mount -o loop', + # ensure there is a loop device in the container + RUN mknod /dev/loop0 b 7 20 Where 'eddy' is my local user with UID 1000. Probably this should be made more generic. I used the following command to start the container: docker run -ti -u 1000:1000 \ --rm -v <path-to-kernel-dir>:/workspace \ -v <path-to-rootfs-image-dir>:/rootfs \ --privileged ubuntu-vmtest:latest /bin/bash Also, I had to add '-d /rootfs/bpf_selftests' option for vmtest.sh in order to avoid polluting user directory inside the container. Maybe OUTPUT_DIR for vmtest.sh should be mounted as a separate volume. I agree with Daniel, it would be great to document all of this somewhere in the repo (or even scripted somehow). Using the specified DENYLIST I get the following stats for test_progs: #3/2 arena_htab/arena_htab_asm:FAIL #3 arena_htab:FAIL #95 get_branch_snapshot:FAIL #172/1 perf_branches/perf_branches_hw:FAIL #172 perf_branches:FAIL #434/3 verifier_arena/basic_alloc3:FAIL #434 verifier_arena:FAIL Summary: 531/3581 PASSED, 64 SKIPPED, 4 FAILED Tested-by: Eduard Zingerman <eddyz87@gmail.com> > PS: Since the current rootfs of riscv64 is not in the INDEX, I simply > modified vmtest.sh to support local rootfs. Could you please add this change to the patch-set? [...]
next prev parent reply other threads:[~2024-04-02 23:40 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-28 12:49 [PATCH bpf-next 0/5] Support local vmtest for riscv64 Pu Lehui 2024-03-28 12:49 ` Pu Lehui 2024-03-28 12:49 ` [PATCH bpf-next 1/5] selftests/bpf: Enable cross platform testing for local vmtest Pu Lehui 2024-03-28 12:49 ` Pu Lehui 2024-03-28 12:49 ` [PATCH bpf-next 2/5] riscv, bpf: Relax restrictions on Zbb instructions Pu Lehui 2024-03-28 12:49 ` Pu Lehui 2024-03-28 19:34 ` Stefan O'Rear 2024-03-28 19:34 ` Stefan O'Rear 2024-03-28 22:07 ` Conor Dooley 2024-03-28 22:07 ` Conor Dooley 2024-03-29 10:05 ` Pu Lehui 2024-03-29 10:05 ` Pu Lehui 2024-04-02 14:25 ` Björn Töpel 2024-04-02 14:25 ` Björn Töpel 2024-04-02 17:38 ` Conor Dooley 2024-04-02 17:38 ` Conor Dooley 2024-04-02 19:00 ` Björn Töpel 2024-04-02 19:00 ` Björn Töpel 2024-04-03 1:20 ` Conor Dooley 2024-04-03 1:20 ` Conor Dooley 2024-04-03 10:05 ` Pu Lehui 2024-04-03 10:05 ` Pu Lehui 2024-04-03 12:29 ` Conor Dooley 2024-04-03 12:29 ` Conor Dooley 2024-03-29 11:23 ` Conor Dooley 2024-03-29 11:23 ` Conor Dooley 2024-03-30 10:19 ` Pu Lehui 2024-03-30 10:19 ` Pu Lehui 2024-03-30 10:19 ` Pu Lehui 2024-03-30 10:19 ` Pu Lehui 2024-03-31 17:49 ` Samuel Holland 2024-03-31 17:49 ` Samuel Holland 2024-04-02 14:18 ` Björn Töpel 2024-04-02 14:18 ` Björn Töpel 2024-04-02 14:27 ` Björn Töpel 2024-04-02 14:27 ` Björn Töpel 2024-04-02 16:03 ` Daniel Borkmann 2024-04-02 16:03 ` Daniel Borkmann 2024-04-03 10:19 ` Pu Lehui 2024-04-03 10:19 ` Pu Lehui 2024-03-28 12:49 ` [PATCH bpf-next 3/5] selftests/bpf: Add config.riscv64 Pu Lehui 2024-03-28 12:49 ` Pu Lehui 2024-03-28 12:49 ` [PATCH bpf-next 4/5] selftests/bpf: Add DENYLIST.riscv64 Pu Lehui 2024-03-28 12:49 ` Pu Lehui 2024-03-28 12:49 ` [PATCH bpf-next 5/5] selftests/bpf: Add riscv64 configurations to local vmtest Pu Lehui 2024-03-28 12:49 ` Pu Lehui 2024-03-29 9:08 ` [PATCH bpf-next 0/5] Support local vmtest for riscv64 Eduard Zingerman 2024-03-29 9:08 ` Eduard Zingerman 2024-03-29 10:10 ` Pu Lehui 2024-03-29 10:10 ` Pu Lehui 2024-03-29 19:46 ` Eduard Zingerman 2024-03-29 19:46 ` Eduard Zingerman 2024-03-30 10:12 ` Pu Lehui 2024-03-30 10:12 ` Pu Lehui 2024-03-30 10:12 ` Pu Lehui 2024-03-30 10:12 ` Pu Lehui 2024-04-02 23:40 ` Eduard Zingerman [this message] 2024-04-02 23:40 ` Eduard Zingerman 2024-04-03 10:31 ` Pu Lehui 2024-04-03 10:31 ` Pu Lehui
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f20d1e2a2f5fa10f29bf1fddbaf99c3f185e8530.camel@gmail.com \ --to=eddyz87@gmail.com \ --cc=andrii@kernel.org \ --cc=ast@kernel.org \ --cc=bjorn@kernel.org \ --cc=bpf@vger.kernel.org \ --cc=chantr4@gmail.com \ --cc=daniel@iogearbox.net \ --cc=haoluo@google.com \ --cc=john.fastabend@gmail.com \ --cc=jolsa@kernel.org \ --cc=kpsingh@kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=martin.lau@linux.dev \ --cc=mykolal@fb.com \ --cc=netdev@vger.kernel.org \ --cc=pulehui@huawei.com \ --cc=pulehui@huaweicloud.com \ --cc=sdf@google.com \ --cc=song@kernel.org \ --cc=yhs@fb.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.