Re: [PATCH v5 3/3] spi: airoha: add SPI-NAND Flash controller driver

From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-spi@vger.kernel.org, conor@kernel.org, broonie@kernel.org,
	lorenzo.bianconi83@gmail.com,
	linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, nbd@nbd.name, john@phrozen.org,
	dd@embedd.com, catalin.marinas@arm.com, will@kernel.org,
	upstream@airoha.com, angelogioacchino.delregno@collabora.com
Subject: Re: [PATCH v5 3/3] spi: airoha: add SPI-NAND Flash controller driver
Date: Mon, 29 Apr 2024 11:50:47 +0200	[thread overview]
Message-ID: <Zi9tdz_VvhqIHnQI@lore-desk> (raw)
In-Reply-To: <CAHp75Vc0=bKk+D9ULPhfbVkgHpRTST_niNBYo4Jri_71XQa+dg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]

> On Mon, Apr 29, 2024 at 11:13 AM Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> >
> > Introduce support for SPI-NAND driver of the Airoha NAND Flash Interface
> > found on Airoha ARM SoCs.
> 
> FWIW,
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
> 
> ...
> 
> > +static void airoha_snand_cleanup(struct spi_device *spi)
> > +{
> > +       struct airoha_snand_dev *as_dev = spi_get_ctldata(spi);
> 
> > +       struct airoha_snand_ctrl *as_ctrl;
> > +
> > +       as_ctrl = spi_controller_get_devdata(spi->controller);
> 
> You may do it on one line above (the same way as for as_dev).
> Ditto for other similar cases around.

It was to avoid going beyond 79 columns, I do not have a strong opinion about
it.

> 
> > +       dma_unmap_single(as_ctrl->dev, as_dev->dma_addr,
> > +                        as_dev->buf_len, DMA_BIDIRECTIONAL);
> > +       spi_set_ctldata(spi, NULL);
> > +}
> 
> ...
> 
> > +static const struct of_device_id airoha_snand_ids[] = {
> > +       { .compatible   = "airoha,en7581-snand" },
> > +       { /* sentinel */ }
> > +};
> > +MODULE_DEVICE_TABLE(of, airoha_snand_ids);
> 
> No need to keep this block here, the first user is below the ->probe().

ack, I will fix it.

Regards,
Lorenzo

> 
> -- 
> With Best Regards,
> Andy Shevchenko

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]