Re: [PATCH v5 3/3] spi: airoha: add SPI-NAND Flash controller driver

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: linux-spi@vger.kernel.org, conor@kernel.org, broonie@kernel.org,
	 lorenzo.bianconi83@gmail.com,
	linux-arm-kernel@lists.infradead.org,  robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	 devicetree@vger.kernel.org, nbd@nbd.name, john@phrozen.org,
	dd@embedd.com,  catalin.marinas@arm.com, will@kernel.org,
	upstream@airoha.com,  angelogioacchino.delregno@collabora.com
Subject: Re: [PATCH v5 3/3] spi: airoha: add SPI-NAND Flash controller driver
Date: Mon, 29 Apr 2024 12:21:58 +0300	[thread overview]
Message-ID: <CAHp75Vc0=bKk+D9ULPhfbVkgHpRTST_niNBYo4Jri_71XQa+dg@mail.gmail.com> (raw)
In-Reply-To: <6c9db20505b01a66807995374f2af475a23ce5b2.1714377864.git.lorenzo@kernel.org>

On Mon, Apr 29, 2024 at 11:13 AM Lorenzo Bianconi <lorenzo@kernel.org> wrote:
>
> Introduce support for SPI-NAND driver of the Airoha NAND Flash Interface
> found on Airoha ARM SoCs.

FWIW,
Reviewed-by: Andy Shevchenko <andy@kernel.org>

...

> +static void airoha_snand_cleanup(struct spi_device *spi)
> +{
> +       struct airoha_snand_dev *as_dev = spi_get_ctldata(spi);

> +       struct airoha_snand_ctrl *as_ctrl;
> +
> +       as_ctrl = spi_controller_get_devdata(spi->controller);

You may do it on one line above (the same way as for as_dev).
Ditto for other similar cases around.

> +       dma_unmap_single(as_ctrl->dev, as_dev->dma_addr,
> +                        as_dev->buf_len, DMA_BIDIRECTIONAL);
> +       spi_set_ctldata(spi, NULL);
> +}

...

> +static const struct of_device_id airoha_snand_ids[] = {
> +       { .compatible   = "airoha,en7581-snand" },
> +       { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, airoha_snand_ids);

No need to keep this block here, the first user is below the ->probe().

-- 
With Best Regards,
Andy Shevchenko