From: Ingo Molnar <mingo@kernel.org>
To: Rohan McLure <rmclure@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au,
christophe.leroy@csgroup.eu, linux-mm@kvack.org,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, x86@kernel.org
Subject: Re: [PATCH v11 00/11] Support page table check PowerPC
Date: Thu, 28 Mar 2024 10:28:14 +0100 [thread overview]
Message-ID: <ZgU4LoWBXDeJY8VS@gmail.com> (raw)
In-Reply-To: <20240328045535.194800-3-rmclure@linux.ibm.com>
* Rohan McLure <rmclure@linux.ibm.com> wrote:
> Rohan McLure (11):
> Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pud_set"
> Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_set"
> Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pud_clear"
> Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_clear"
> Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pte_clear"
Just a process request: please give these commits proper titles, they
are not really 'reverts' in the classical sense, and this title hides
what is being done in the commit. The typical use of reverts is to
revert a bad change because it broke something. Here the goal is to
reintroduce functionality.
So please name these 5 patches accordingly, to shed light on what is
being reintroduced. You can mention it at the end of the changelog that
it's a functional revert of commit XYZ, but that's not the primary
purpose of the commit.
Thanks,
Ingo
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Rohan McLure <rmclure@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au,
christophe.leroy@csgroup.eu, linux-mm@kvack.org,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, x86@kernel.org
Subject: Re: [PATCH v11 00/11] Support page table check PowerPC
Date: Thu, 28 Mar 2024 10:28:14 +0100 [thread overview]
Message-ID: <ZgU4LoWBXDeJY8VS@gmail.com> (raw)
In-Reply-To: <20240328045535.194800-3-rmclure@linux.ibm.com>
* Rohan McLure <rmclure@linux.ibm.com> wrote:
> Rohan McLure (11):
> Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pud_set"
> Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_set"
> Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pud_clear"
> Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_clear"
> Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pte_clear"
Just a process request: please give these commits proper titles, they
are not really 'reverts' in the classical sense, and this title hides
what is being done in the commit. The typical use of reverts is to
revert a bad change because it broke something. Here the goal is to
reintroduce functionality.
So please name these 5 patches accordingly, to shed light on what is
being reintroduced. You can mention it at the end of the changelog that
it's a functional revert of commit XYZ, but that's not the primary
purpose of the commit.
Thanks,
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Rohan McLure <rmclure@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au,
christophe.leroy@csgroup.eu, linux-mm@kvack.org,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, x86@kernel.org
Subject: Re: [PATCH v11 00/11] Support page table check PowerPC
Date: Thu, 28 Mar 2024 10:28:14 +0100 [thread overview]
Message-ID: <ZgU4LoWBXDeJY8VS@gmail.com> (raw)
In-Reply-To: <20240328045535.194800-3-rmclure@linux.ibm.com>
* Rohan McLure <rmclure@linux.ibm.com> wrote:
> Rohan McLure (11):
> Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pud_set"
> Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_set"
> Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pud_clear"
> Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_clear"
> Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pte_clear"
Just a process request: please give these commits proper titles, they
are not really 'reverts' in the classical sense, and this title hides
what is being done in the commit. The typical use of reverts is to
revert a bad change because it broke something. Here the goal is to
reintroduce functionality.
So please name these 5 patches accordingly, to shed light on what is
being reintroduced. You can mention it at the end of the changelog that
it's a functional revert of commit XYZ, but that's not the primary
purpose of the commit.
Thanks,
Ingo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Rohan McLure <rmclure@linux.ibm.com>
Cc: x86@kernel.org, linux-mm@kvack.org,
linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v11 00/11] Support page table check PowerPC
Date: Thu, 28 Mar 2024 10:28:14 +0100 [thread overview]
Message-ID: <ZgU4LoWBXDeJY8VS@gmail.com> (raw)
In-Reply-To: <20240328045535.194800-3-rmclure@linux.ibm.com>
* Rohan McLure <rmclure@linux.ibm.com> wrote:
> Rohan McLure (11):
> Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pud_set"
> Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_set"
> Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pud_clear"
> Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_clear"
> Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pte_clear"
Just a process request: please give these commits proper titles, they
are not really 'reverts' in the classical sense, and this title hides
what is being done in the commit. The typical use of reverts is to
revert a bad change because it broke something. Here the goal is to
reintroduce functionality.
So please name these 5 patches accordingly, to shed light on what is
being reintroduced. You can mention it at the end of the changelog that
it's a functional revert of commit XYZ, but that's not the primary
purpose of the commit.
Thanks,
Ingo
next prev parent reply other threads:[~2024-03-28 9:28 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 4:55 [PATCH v11 00/11] Support page table check PowerPC Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` [PATCH v11 01/11] Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pud_set" Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` [PATCH v11 02/11] Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_set" Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` [PATCH v11 03/11] mm: Provide addr parameter to page_table_check_pte_set() Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` [PATCH v11 04/11] Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pud_clear" Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` [PATCH v11 05/11] Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_clear" Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` [PATCH v11 06/11] Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pte_clear" Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` [PATCH v11 07/11] mm: Provide address parameter to p{te,md,ud}_user_accessible_page() Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` [PATCH v11 08/11] powerpc: mm: Add pud_pfn() stub Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 5:33 ` Christophe Leroy
2024-03-28 5:33 ` Christophe Leroy
2024-03-28 5:33 ` Christophe Leroy
2024-03-28 5:33 ` Christophe Leroy
2024-03-28 4:55 ` [PATCH v11 09/11] poweprc: mm: Implement *_user_accessible_page() for ptes Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 5:40 ` Christophe Leroy
2024-03-28 5:40 ` Christophe Leroy
2024-03-28 5:40 ` Christophe Leroy
2024-03-28 5:40 ` Christophe Leroy
2024-03-28 5:44 ` Rohan McLure
2024-03-28 5:44 ` Rohan McLure
2024-03-28 5:44 ` Rohan McLure
2024-03-28 5:44 ` Rohan McLure
2024-03-28 4:55 ` [PATCH v11 10/11] powerpc: mm: Use set_pte_at_unchecked() for early-boot / internal usages Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` [PATCH v11 11/11] powerpc: mm: Support page table check Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 4:55 ` Rohan McLure
2024-03-28 6:52 ` [PATCH v11 00/11] Support page table check PowerPC Christophe Leroy
2024-03-28 6:52 ` Christophe Leroy
2024-03-28 6:52 ` Christophe Leroy
2024-03-28 6:52 ` Christophe Leroy
2024-03-28 7:57 ` Christophe Leroy
2024-03-28 7:57 ` Christophe Leroy
2024-03-28 7:57 ` Christophe Leroy
2024-03-28 7:57 ` Christophe Leroy
2024-03-29 8:29 ` Christophe Leroy
2024-03-29 8:29 ` Christophe Leroy
2024-03-29 8:29 ` Christophe Leroy
2024-03-29 8:29 ` Christophe Leroy
2024-03-28 9:28 ` Ingo Molnar [this message]
2024-03-28 9:28 ` Ingo Molnar
2024-03-28 9:28 ` Ingo Molnar
2024-03-28 9:28 ` Ingo Molnar
2024-04-02 3:00 ` Rohan McLure
2024-04-02 3:00 ` Rohan McLure
2024-04-02 3:00 ` Rohan McLure
2024-04-02 3:00 ` Rohan McLure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgU4LoWBXDeJY8VS@gmail.com \
--to=mingo@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=rmclure@linux.ibm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.