From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28DB9C54E67 for ; Thu, 28 Mar 2024 09:28:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ssvtDUlROaXy6YxRMnGVCIXmDR8CNW8z2k/wkpO1Q2Y=; b=4L6VOcy/I0VIkq 1qD1Gp3KczXWdBMxSCsdYyqrdtWFViedUf1h/+h9VFUbL6fZD1GysYzdlzC98P7t3CSjssT54xVVI 9P/pPkpISG0vtdgUX91dpUPTSyn8f6ZjSAjy9ZWH8TZTtN3l6p8t/GtdHFQfsICCM5szM1SUqLpNO Wal87mhB8tbXdWr9cgf4oPLwf3NeQuzIcf/cEkFD94Fq+GLFIjX+NmXAPvMYDucnYNwkTsYYBH0If p54ye6S3dWl48MeFp+/62+jBA/nHU0f61hjjw/3qnILY9/xs9PhsicGMnmy1Ly1UyQvwebH8UBoE3 SlujaOuETh1rBAq7jORA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpm3h-0000000DLC7-1qCm; Thu, 28 Mar 2024 09:28:29 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpm3d-0000000DL7x-3VOY; Thu, 28 Mar 2024 09:28:28 +0000 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-a472f8c6a55so88859266b.0; Thu, 28 Mar 2024 02:28:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711618098; x=1712222898; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=yhDsgsoAO60u3k10g2MJLo0MvaSsM4SCLf4CmYbwMnU=; b=H0sYCOUZfoOdWOeRbpc908I61yGgkps1HPofzhIchPU2KdMQomcqf3lNpcsbHmy+kM Spv3xSSDiSTjvM+Qy9JZ7BogcfPE+x9L0H1ws82mw1oKPadzyFT4qt/oMX2TPsu1yD2v /PLptp9wS6w3a+kWr7u6MHNueuna5PZHakwb3Ey2zZQCukXaawmcTMzCMaDdqoPHky+8 +JrZCFDbQyaR84GiLrMK8BXLRJbeY1/CMhWIyom4815jo8uBuZhU4vVQKWVWE3ZjFZsM jKkWEUJo3A07yoR9vkvQ8P/gSLjczfiib8DrgIfmmvRXAlFQKJQQ5lBZ/gt8iv6mwXAW 7r3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711618098; x=1712222898; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yhDsgsoAO60u3k10g2MJLo0MvaSsM4SCLf4CmYbwMnU=; b=cSjO63En3NiYBOWWoC9Bw+4r6/YoYGWidYR3mrJPS2621LUOuYGg65/sM0jrnjfLYr Wx8CXHnqZNWBfB9LLczz66J3VX9CNxsH+xwN+WyGRw2YVANfD/7+FPv4a27j53bxdpmH 1b+fxtB2cxQPKkOACJUHD1oW3leJuCE9c3bmmd8hD4s+1Q6EjVEzb6IAMl0gjfkOG0vr nCJjMK0y7SeK2BhSEQlOQ94bREDu8D6TK7IWtzYR5/nNwMX+7od4Dd/U/VCa9uRgG6sy bqdJQtUqhanEbaC8Ndm/jCenL03a+ZgekbjDmFKf/Rv+yhyRNlxWCzGsKAgDNdVCRjlJ DA0A== X-Forwarded-Encrypted: i=1; AJvYcCWzbn3dXX13nwHlXZI1hA/yzw6t4GOxxO9DRfpUq4+qxN4M7PMFNCoS2/4pOS0t0bPa+7CwYPd5STigYI14pjRUHw+khzS4wSrQd+qYFCJh6HD+V+vbSA2hUOoHRPdjgzjWlwO9j4dqKN2xDatXcfHKSezIW5g= X-Gm-Message-State: AOJu0YwqTv6tZwzEkESod4pIg/FzrONNJYh6ptcKKIm21MGEmF407y/j 1Nzo+q7kgpLf+w19oLMMb8uR0RDWIacxGN8LNYaDujZakxQKYY95 X-Google-Smtp-Source: AGHT+IF4nGJMSNCV5u3DgVbXNZEHPac9H6U3miurlYMwBj65T7W35FEsQTMN3m6K4hqypNhM2eag0g== X-Received: by 2002:a17:906:41b:b0:a46:8856:e6bf with SMTP id d27-20020a170906041b00b00a468856e6bfmr1287546eja.44.1711618097410; Thu, 28 Mar 2024 02:28:17 -0700 (PDT) Received: from gmail.com (195-38-112-2.pool.digikabel.hu. [195.38.112.2]) by smtp.gmail.com with ESMTPSA id qx27-20020a170906fcdb00b00a4750b2e0f0sm519801ejb.164.2024.03.28.02.28.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 02:28:16 -0700 (PDT) Date: Thu, 28 Mar 2024 10:28:14 +0100 From: Ingo Molnar To: Rohan McLure Cc: linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, christophe.leroy@csgroup.eu, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org Subject: Re: [PATCH v11 00/11] Support page table check PowerPC Message-ID: References: <20240328045535.194800-3-rmclure@linux.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240328045535.194800-3-rmclure@linux.ibm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240328_022825_940924_3977B9C7 X-CRM114-Status: GOOD ( 10.31 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org * Rohan McLure wrote: > Rohan McLure (11): > Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pud_set" > Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_set" > Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pud_clear" > Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_clear" > Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pte_clear" Just a process request: please give these commits proper titles, they are not really 'reverts' in the classical sense, and this title hides what is being done in the commit. The typical use of reverts is to revert a bad change because it broke something. Here the goal is to reintroduce functionality. So please name these 5 patches accordingly, to shed light on what is being reintroduced. You can mention it at the end of the changelog that it's a functional revert of commit XYZ, but that's not the primary purpose of the commit. Thanks, Ingo _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D14D8C54E67 for ; Thu, 28 Mar 2024 09:28:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46B726B0095; Thu, 28 Mar 2024 05:28:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4194E6B0096; Thu, 28 Mar 2024 05:28:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E1AC6B0098; Thu, 28 Mar 2024 05:28:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 10E346B0095 for ; Thu, 28 Mar 2024 05:28:25 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 521698108F for ; Thu, 28 Mar 2024 09:28:22 +0000 (UTC) X-FDA: 81945922044.02.1FE36AE Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf27.hostedemail.com (Postfix) with ESMTP id 8D1834000D for ; Thu, 28 Mar 2024 09:28:19 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XXgzNvQk; spf=pass (imf27.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711618099; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yhDsgsoAO60u3k10g2MJLo0MvaSsM4SCLf4CmYbwMnU=; b=BXqD9uekFvXorsetBMeRSRc0Jxlz4o3NW+vyCbhJZGW15weJLTa02wgjZRopM2IF7m77Zw bejZuIupBBQA1MlMAA0E4DjgS+0kWj+kFvNRzrXwcVDfjN8pL2nW5ezTcBI1gOLt+NGczR TS6lOhnHOM94+ZAtCp38wqeWMge25hY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XXgzNvQk; spf=pass (imf27.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711618099; a=rsa-sha256; cv=none; b=qSs4ZvKv6Ao6bL5ysohP+jFRlRQyX5foJP+ZnKwopwHJPlqyDw4oK6aAv7KJclAn2/2V8O 6MfRXB/mMqRkA0MwaY50Ougk1BzANYNUFdvIEHm90M9b4zToA1WzDDhAQtgI0yudvlHQ/i iEmc/V5QhEvH4Oc2MzfaJIyyH2HuWp8= Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a472f8c6a55so88859366b.0 for ; Thu, 28 Mar 2024 02:28:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711618098; x=1712222898; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=yhDsgsoAO60u3k10g2MJLo0MvaSsM4SCLf4CmYbwMnU=; b=XXgzNvQka/gAYRGaXpPDpV7PYGAaJ77mZV6YEgE/ck1rOInfzvFz/YlxA0ufcmTfZ8 nmcL3Ozo693HX3zXPJ+1orFM2zruwqCXB4Ja8h+FIPH4pIgfO9YmMr5mcwTUL7ZqaYOQ KrkcJQ6rl2pT7KDZ8hP4PXH07m2wxBLS9tq/iSeFdQFQj02fekZ0HRIfo/rsQTGTgu6p Kefh69oUhkkTQHyw/bgRD/8fz2hosxBRn4TOayr5KWgtOQizJsli7lnJah3NTX8Vy/eE hh6wSPl90P7Ub2DqLRyzHtJsT0mCwoYS3N86XFcu1vnvB9wr/MlcxsAlxPJoTWbN76CF oG3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711618098; x=1712222898; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yhDsgsoAO60u3k10g2MJLo0MvaSsM4SCLf4CmYbwMnU=; b=CA9zx3sfBUh6iKQmIw2bmn0sJ6Tj6az0NtKQBBQxvJPUZxCGLul6yED4oGhF6ftYVy Wku9bUwGIRFCJ/pjRNUrzQYs50Nrh3nE/7wYPlmej6eB8nPyfL4mBIENa2xfEtsV6Hfi fYd26qm+GofI06bgNSuNcEUnRITkHaFD6eStgkxXGcaGMG/vUJ632XxXUZt9sS4cRsMN 1Ei/LoZnv6TpUiXqJ7MrCPF1OGcVs62BFW+JtqZbDZfA1cvWV1dVw38aL5eDsyd2/Olw fHDzhVaDQzTUeW7wq9ctxumq/LZqA/YwICag06jRxqGx63UXaIl2JqYSKvU2CD25T+ym 0+LA== X-Forwarded-Encrypted: i=1; AJvYcCXjEaM/ajNs8XJfYLCL+mpmsKPlHnSQJl766/WjCf+0woi+E71V+PQZSFr3kPzIGpdQkUctxtjjvnrUca6AC97ekY0= X-Gm-Message-State: AOJu0YxW6KgreareI/0+scxRHasQBB4+Z4XxfIxHneR8gt9VWCPHQq+D fRde7FIlT2jE9nLx8rwNRMJuMW5rUbjOSF4IPCZ7I7qxdLNNW5+Q X-Google-Smtp-Source: AGHT+IF4nGJMSNCV5u3DgVbXNZEHPac9H6U3miurlYMwBj65T7W35FEsQTMN3m6K4hqypNhM2eag0g== X-Received: by 2002:a17:906:41b:b0:a46:8856:e6bf with SMTP id d27-20020a170906041b00b00a468856e6bfmr1287546eja.44.1711618097410; Thu, 28 Mar 2024 02:28:17 -0700 (PDT) Received: from gmail.com (195-38-112-2.pool.digikabel.hu. [195.38.112.2]) by smtp.gmail.com with ESMTPSA id qx27-20020a170906fcdb00b00a4750b2e0f0sm519801ejb.164.2024.03.28.02.28.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 02:28:16 -0700 (PDT) Date: Thu, 28 Mar 2024 10:28:14 +0100 From: Ingo Molnar To: Rohan McLure Cc: linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, christophe.leroy@csgroup.eu, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org Subject: Re: [PATCH v11 00/11] Support page table check PowerPC Message-ID: References: <20240328045535.194800-3-rmclure@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240328045535.194800-3-rmclure@linux.ibm.com> X-Rspamd-Queue-Id: 8D1834000D X-Rspam-User: X-Stat-Signature: zczwuymch5mrg3ct9kcgd1kyn5qmnmwa X-Rspamd-Server: rspam01 X-HE-Tag: 1711618099-857203 X-HE-Meta: U2FsdGVkX1/Uf7TVu+5Hpb+ufGROqZrorpz9Pu39jrs7BNLI60fFUnm2VBq1x3wS6suMNLwGHJKbxUGLXhIJqBJYDBQOx8CTkHzC3JZt7XT7hHgEBjA2rGrAyGqJk7AjcO9C8rBZmjwEXBDWS5grLDCEesav3YbqP6fyk7R8aCrxEipnvc+0Lo6RWUU0ahWZdeiRtAxGtoe/nsGCLhpeEMIX/dc67EN64Pu/T1DFWnEWH7d4J7Vx99qwi2/UWx74cTUsBx+U/TXfkvmIkcgWKq1CY5JV4OecQYPZ7BYMebZphJmGeYjMaK3vOupe1QSB1F1GY0p2CWT/wKRO/fCG4l5ncA88f/S02nkKp84u8uScWkspOoX+E+Qxw97ScOcX3HSfvDDK/lGUyE19YvYAD46JppVGYg3OXiKI7ayTVX3r4ABbGgkXYWjOTi6tMy4uUHqP+Gy5/VXT8YpD8tlnWUCzL7YDrjBclRc9PlspZRAE8OjfrDlN9ftXat/sY9jj/FlrN/nJPXmEE+5qRxGk3gTb9WlPaURSiiyRCqeoOmTOCbNdSy7AEnQ3ZvEoO/oK1KytYIK5LTzSOeoX7XUzYm3LMUusWfXIY9CK2FVXBsGoeQKy5mgxiQ/Zdc+edpBtAfSihcsRjUILEy6/DteBYC676hHoGaN8LeHh4CA6EnvLt2R6D5a3jOIQjM5y0bgVQObmmOntY9BcYS9zSaAiOT1Io2DiufMAxNftBtTgu77P/RzN/s8dqlC3xrCF0iRSZY2m6HT9at/2+hFWmGHwF/aTpa/nbnxNXU8dVIvJGH4FWTekCkOl7kEOTjOh+f4A/wGWRnq0Nrswsyn5h1tcO0pdV2T1nWm1ILe1wm169UCxpznds6HOrwLvvKYLrdcKR19J+qSEWPesPy8HIxfg2mWePIGbjC5pOouhakVoeyq0u/ByD68QH25dzNAq69x9gjjwj1BS6EKtITfelJd mNMcNDV2 Wvd+LU1rHioItQT9qpSNZh0wrWtFMFV2GKliyA2rn1tCHCtLr/CpZdg9zznxB832Wst5um5qgTwhNgek3BYER1ybtAz/PzuOecVnleJAF/4ijn4PVbuwbr3QXy73Adh1V3C5NZymbCaqdb9j8CFMUfZuADzIrjT7XJH91IRi9oHpxw5/OIe2Oy0OS4nHFw1jgHqsx74yfHlodXF3kL0aK7mIIWDWwcGXN7oQmDvW3DCTDRnrCQyHAAI/9XzfndeDDd1M2N3hFgzyu/DLM8JCG+nhRFrSy0YTJ7F+s X-Bogosity: Ham, tests=bogofilter, spamicity=0.430283, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Rohan McLure wrote: > Rohan McLure (11): > Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pud_set" > Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_set" > Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pud_clear" > Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_clear" > Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pte_clear" Just a process request: please give these commits proper titles, they are not really 'reverts' in the classical sense, and this title hides what is being done in the commit. The typical use of reverts is to revert a bad change because it broke something. Here the goal is to reintroduce functionality. So please name these 5 patches accordingly, to shed light on what is being reintroduced. You can mention it at the end of the changelog that it's a functional revert of commit XYZ, but that's not the primary purpose of the commit. Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D16AC54E67 for ; Thu, 28 Mar 2024 09:28:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sgyzeO5daoA/R/10ze1p33D/NALGNjh81f5AX6RQY1M=; b=1oVqB7225SV49v WRurX7WwwPkbkEp2eqWdmeSkx8YSS7la3bB2RLqefUmTYIRihDOWIO6h2iYKVFo2+dT/yk0w/cVql HtnmvT7phbk2zrzjXvYELSsGDAjZlpMLnbAaMuyC4kVBRLH0PaS2GGPsd2E1HexYUwpmLXeTZP5UO kNQgsYI+Jc4muSrENC9IYW8dQELUKFqGqL1Lhs8HCJZ4vthqQKHeDMpkVdWtPLxHyJ/fM5U1nJ95m cQ+mD+AlKcFeUQUS8qNCCyCRQZPvMicRjgfQyk4RLKk61vpsOq3V6bm05j8NsEtJ8qZQxdzdb8rA4 vxxy7W1sDpKwZFo7gcHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpm3i-0000000DLCE-0VbG; Thu, 28 Mar 2024 09:28:30 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpm3d-0000000DL7x-3VOY; Thu, 28 Mar 2024 09:28:28 +0000 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-a472f8c6a55so88859266b.0; Thu, 28 Mar 2024 02:28:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711618098; x=1712222898; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=yhDsgsoAO60u3k10g2MJLo0MvaSsM4SCLf4CmYbwMnU=; b=H0sYCOUZfoOdWOeRbpc908I61yGgkps1HPofzhIchPU2KdMQomcqf3lNpcsbHmy+kM Spv3xSSDiSTjvM+Qy9JZ7BogcfPE+x9L0H1ws82mw1oKPadzyFT4qt/oMX2TPsu1yD2v /PLptp9wS6w3a+kWr7u6MHNueuna5PZHakwb3Ey2zZQCukXaawmcTMzCMaDdqoPHky+8 +JrZCFDbQyaR84GiLrMK8BXLRJbeY1/CMhWIyom4815jo8uBuZhU4vVQKWVWE3ZjFZsM jKkWEUJo3A07yoR9vkvQ8P/gSLjczfiib8DrgIfmmvRXAlFQKJQQ5lBZ/gt8iv6mwXAW 7r3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711618098; x=1712222898; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yhDsgsoAO60u3k10g2MJLo0MvaSsM4SCLf4CmYbwMnU=; b=cSjO63En3NiYBOWWoC9Bw+4r6/YoYGWidYR3mrJPS2621LUOuYGg65/sM0jrnjfLYr Wx8CXHnqZNWBfB9LLczz66J3VX9CNxsH+xwN+WyGRw2YVANfD/7+FPv4a27j53bxdpmH 1b+fxtB2cxQPKkOACJUHD1oW3leJuCE9c3bmmd8hD4s+1Q6EjVEzb6IAMl0gjfkOG0vr nCJjMK0y7SeK2BhSEQlOQ94bREDu8D6TK7IWtzYR5/nNwMX+7od4Dd/U/VCa9uRgG6sy bqdJQtUqhanEbaC8Ndm/jCenL03a+ZgekbjDmFKf/Rv+yhyRNlxWCzGsKAgDNdVCRjlJ DA0A== X-Forwarded-Encrypted: i=1; AJvYcCWzbn3dXX13nwHlXZI1hA/yzw6t4GOxxO9DRfpUq4+qxN4M7PMFNCoS2/4pOS0t0bPa+7CwYPd5STigYI14pjRUHw+khzS4wSrQd+qYFCJh6HD+V+vbSA2hUOoHRPdjgzjWlwO9j4dqKN2xDatXcfHKSezIW5g= X-Gm-Message-State: AOJu0YwqTv6tZwzEkESod4pIg/FzrONNJYh6ptcKKIm21MGEmF407y/j 1Nzo+q7kgpLf+w19oLMMb8uR0RDWIacxGN8LNYaDujZakxQKYY95 X-Google-Smtp-Source: AGHT+IF4nGJMSNCV5u3DgVbXNZEHPac9H6U3miurlYMwBj65T7W35FEsQTMN3m6K4hqypNhM2eag0g== X-Received: by 2002:a17:906:41b:b0:a46:8856:e6bf with SMTP id d27-20020a170906041b00b00a468856e6bfmr1287546eja.44.1711618097410; Thu, 28 Mar 2024 02:28:17 -0700 (PDT) Received: from gmail.com (195-38-112-2.pool.digikabel.hu. [195.38.112.2]) by smtp.gmail.com with ESMTPSA id qx27-20020a170906fcdb00b00a4750b2e0f0sm519801ejb.164.2024.03.28.02.28.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 02:28:16 -0700 (PDT) Date: Thu, 28 Mar 2024 10:28:14 +0100 From: Ingo Molnar To: Rohan McLure Cc: linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, christophe.leroy@csgroup.eu, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org Subject: Re: [PATCH v11 00/11] Support page table check PowerPC Message-ID: References: <20240328045535.194800-3-rmclure@linux.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240328045535.194800-3-rmclure@linux.ibm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240328_022825_940924_3977B9C7 X-CRM114-Status: GOOD ( 10.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Rohan McLure wrote: > Rohan McLure (11): > Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pud_set" > Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_set" > Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pud_clear" > Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_clear" > Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pte_clear" Just a process request: please give these commits proper titles, they are not really 'reverts' in the classical sense, and this title hides what is being done in the commit. The typical use of reverts is to revert a bad change because it broke something. Here the goal is to reintroduce functionality. So please name these 5 patches accordingly, to shed light on what is being reintroduced. You can mention it at the end of the changelog that it's a functional revert of commit XYZ, but that's not the primary purpose of the commit. Thanks, Ingo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61127C54E67 for ; Thu, 28 Mar 2024 09:29:13 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=JiO2FC7b; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4V4ysh0Fdgz3dXb for ; Thu, 28 Mar 2024 20:29:12 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=JiO2FC7b; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::632; helo=mail-ej1-x632.google.com; envelope-from=mingo.kernel.org@gmail.com; receiver=lists.ozlabs.org) Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4V4yrp6vNbz3dX1 for ; Thu, 28 Mar 2024 20:28:25 +1100 (AEDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a44665605f3so77057966b.2 for ; Thu, 28 Mar 2024 02:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711618098; x=1712222898; darn=lists.ozlabs.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=yhDsgsoAO60u3k10g2MJLo0MvaSsM4SCLf4CmYbwMnU=; b=JiO2FC7bIuMZUi1DmLkv5ypbEl93C2Ltu/iRVdfFr/wcCu5MbqykCnHLTlIyTBKiTw eMkWRi82tbBoRfREpVcUUD8EtaxxsPS7VRKVkp+jMd4WApcqXyXVbPGNgXhd5SeWrFUw OKr9dPC/yLQyvgoaEDlE7gIojpVwEuQUyQX2ppYQOktIvQt10ETRuUepxBSLOZqBtQgG dkqI3waVcDurR7wWoTmZMUcObGRFfbGQcyKqmWYji0/BfHWopvR29faVWIjBhuELXpV4 uLAQmiHEcipDUU2nB9FS4LFPchzrROnj/IT2uItW3toZQVi5JPHt8lR6zZZXuMOiSfq5 kV6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711618098; x=1712222898; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yhDsgsoAO60u3k10g2MJLo0MvaSsM4SCLf4CmYbwMnU=; b=DUEBOUsfRl7rsct8VrQ7xbjwr9IP0GOTfLxoCyNaax4RTPpiF9V54fhr21jDXOewYq hIRL14fJs3IFgveK+ILU4IGOpHlPDQkJjxwLgd+AAY3cN+pEuJYbQHM0W41Tckci2t5x eZ4bZukAybP9k1cGCimQcQI1lCMgG8nmZ1aMGMPlxBTiB54rkn8ofdkekw9gKqNxooUK opM0i+cwh65edtC0eyTkJsknY6Bk0MBdEHt49QMImq7o+PuPiAKbY5bFYthI3AwRSche W0eA4YXhF0u3IT6cR6Tozv2K+DnlxDLDIT9TS8jfOVSH/ZERDR8MnBuTKWEe8S1PIaj6 Zkxw== X-Gm-Message-State: AOJu0Yw1SRQXzgQWVPb92C++jlEdaLXo2eVGmAZF38E/QAUJn7Bh9XbM IPodj6kehQ4yKr5OGPgXD4NTeA+1PgGdaroFZa6CtOj57fhlkUrH X-Google-Smtp-Source: AGHT+IF4nGJMSNCV5u3DgVbXNZEHPac9H6U3miurlYMwBj65T7W35FEsQTMN3m6K4hqypNhM2eag0g== X-Received: by 2002:a17:906:41b:b0:a46:8856:e6bf with SMTP id d27-20020a170906041b00b00a468856e6bfmr1287546eja.44.1711618097410; Thu, 28 Mar 2024 02:28:17 -0700 (PDT) Received: from gmail.com (195-38-112-2.pool.digikabel.hu. [195.38.112.2]) by smtp.gmail.com with ESMTPSA id qx27-20020a170906fcdb00b00a4750b2e0f0sm519801ejb.164.2024.03.28.02.28.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 02:28:16 -0700 (PDT) Date: Thu, 28 Mar 2024 10:28:14 +0100 From: Ingo Molnar To: Rohan McLure Subject: Re: [PATCH v11 00/11] Support page table check PowerPC Message-ID: References: <20240328045535.194800-3-rmclure@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240328045535.194800-3-rmclure@linux.ibm.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" * Rohan McLure wrote: > Rohan McLure (11): > Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pud_set" > Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_set" > Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pud_clear" > Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_clear" > Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pte_clear" Just a process request: please give these commits proper titles, they are not really 'reverts' in the classical sense, and this title hides what is being done in the commit. The typical use of reverts is to revert a bad change because it broke something. Here the goal is to reintroduce functionality. So please name these 5 patches accordingly, to shed light on what is being reintroduced. You can mention it at the end of the changelog that it's a functional revert of commit XYZ, but that's not the primary purpose of the commit. Thanks, Ingo