From: Phil Auld <pauld@redhat.com>
To: Waiman Long <longman@redhat.com>
Cc: Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <guro@fb.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>
Subject: Re: [PATCH 0/5] cgroup/cpuset: Enable cpuset partition with no load balancing
Date: Thu, 10 Jun 2021 10:19:47 -0400 [thread overview]
Message-ID: <YMIfg0Aa2HZQPEy+@lorien.usersys.redhat.com> (raw)
In-Reply-To: <20210603212416.25934-1-longman@redhat.com>
Hi Waiman,
On Thu, Jun 03, 2021 at 05:24:11PM -0400 Waiman Long wrote:
> This patchset makes the following two major changes to the cpuset v2 code:
>
> Patch 2: Add a new partition state "root-nolb" to create a partition
> root with load balancing disabled. This is for handling intermitten
> workloads that have a strict low latency requirement.
>
> Patch 3: Allow partition roots that are not the top cpuset to distribute
> all its cpus to child partitions as long as there is no task associated
> with that partition root. This allows more flexibility for middleware
> to manage multiple partitions.
Thanks! This looks like it will be a usable replacement for the functionality
lost when SD_LOAD_BALANCE went away.
Cheers,
Phil
>
> Patch 4 updates the cgroup-v2.rst file accordingly. Patch 5 adds a test
> to test the new cpuset partition code.
>
> Waiman Long (5):
> cgroup/cpuset: Don't call validate_change() for some flag changes
> cgroup/cpuset: Add new cpus.partition type with no load balancing
> cgroup/cpuset: Allow non-top parent partition root to distribute out
> all CPUs
> cgroup/cpuset: Update description of cpuset.cpus.partition in
> cgroup-v2.rst
> kselftest/cgroup: Add cpuset v2 partition root state test
>
> Documentation/admin-guide/cgroup-v2.rst | 19 ++-
> kernel/cgroup/cpuset.c | 124 +++++++++++----
> tools/testing/selftests/cgroup/Makefile | 2 +-
> .../selftests/cgroup/test_cpuset_prs.sh | 141 ++++++++++++++++++
> 4 files changed, 247 insertions(+), 39 deletions(-)
> create mode 100755 tools/testing/selftests/cgroup/test_cpuset_prs.sh
>
> --
> 2.18.1
>
--
WARNING: multiple messages have this Message-ID (diff)
From: Phil Auld <pauld-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Zefan Li <lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Jonathan Corbet <corbet-T1hC0tSOHrs@public.gmane.org>,
Shuah Khan <shuah-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kselftest-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Roman Gushchin <guro-b10kYP2dOMg@public.gmane.org>,
Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Juri Lelli <juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 0/5] cgroup/cpuset: Enable cpuset partition with no load balancing
Date: Thu, 10 Jun 2021 10:19:47 -0400 [thread overview]
Message-ID: <YMIfg0Aa2HZQPEy+@lorien.usersys.redhat.com> (raw)
In-Reply-To: <20210603212416.25934-1-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Hi Waiman,
On Thu, Jun 03, 2021 at 05:24:11PM -0400 Waiman Long wrote:
> This patchset makes the following two major changes to the cpuset v2 code:
>
> Patch 2: Add a new partition state "root-nolb" to create a partition
> root with load balancing disabled. This is for handling intermitten
> workloads that have a strict low latency requirement.
>
> Patch 3: Allow partition roots that are not the top cpuset to distribute
> all its cpus to child partitions as long as there is no task associated
> with that partition root. This allows more flexibility for middleware
> to manage multiple partitions.
Thanks! This looks like it will be a usable replacement for the functionality
lost when SD_LOAD_BALANCE went away.
Cheers,
Phil
>
> Patch 4 updates the cgroup-v2.rst file accordingly. Patch 5 adds a test
> to test the new cpuset partition code.
>
> Waiman Long (5):
> cgroup/cpuset: Don't call validate_change() for some flag changes
> cgroup/cpuset: Add new cpus.partition type with no load balancing
> cgroup/cpuset: Allow non-top parent partition root to distribute out
> all CPUs
> cgroup/cpuset: Update description of cpuset.cpus.partition in
> cgroup-v2.rst
> kselftest/cgroup: Add cpuset v2 partition root state test
>
> Documentation/admin-guide/cgroup-v2.rst | 19 ++-
> kernel/cgroup/cpuset.c | 124 +++++++++++----
> tools/testing/selftests/cgroup/Makefile | 2 +-
> .../selftests/cgroup/test_cpuset_prs.sh | 141 ++++++++++++++++++
> 4 files changed, 247 insertions(+), 39 deletions(-)
> create mode 100755 tools/testing/selftests/cgroup/test_cpuset_prs.sh
>
> --
> 2.18.1
>
--
next prev parent reply other threads:[~2021-06-10 14:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 21:24 [PATCH 0/5] cgroup/cpuset: Enable cpuset partition with no load balancing Waiman Long
2021-06-03 21:24 ` [PATCH 1/5] cgroup/cpuset: Don't call validate_change() for some flag changes Waiman Long
2021-06-16 20:39 ` Tejun Heo
2021-06-17 2:53 ` Waiman Long
2021-06-03 21:24 ` [PATCH 2/5] cgroup/cpuset: Add new cpus.partition type with no load balancing Waiman Long
2021-06-10 18:50 ` Peter Zijlstra
2021-06-10 18:50 ` Peter Zijlstra
2021-06-10 19:16 ` Waiman Long
2021-06-10 19:39 ` Peter Zijlstra
2021-06-10 19:00 ` Peter Zijlstra
2021-06-10 19:00 ` Peter Zijlstra
2021-06-10 19:21 ` Waiman Long
2021-06-16 20:47 ` Tejun Heo
2021-06-17 2:57 ` Waiman Long
2021-06-17 2:57 ` Waiman Long
2021-06-03 21:24 ` [PATCH 3/5] cgroup/cpuset: Allow non-top parent partition root to distribute out all CPUs Waiman Long
2021-06-03 21:24 ` Waiman Long
2021-06-16 20:57 ` Tejun Heo
2021-06-16 20:57 ` Tejun Heo
2021-06-17 20:45 ` Waiman Long
2021-06-17 20:45 ` Waiman Long
2021-06-03 21:24 ` [PATCH 4/5] cgroup/cpuset: Update description of cpuset.cpus.partition in cgroup-v2.rst Waiman Long
2021-06-03 21:24 ` [PATCH 5/5] kselftest/cgroup: Add cpuset v2 partition root state test Waiman Long
2021-06-10 14:19 ` Phil Auld [this message]
2021-06-10 14:19 ` [PATCH 0/5] cgroup/cpuset: Enable cpuset partition with no load balancing Phil Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMIfg0Aa2HZQPEy+@lorien.usersys.redhat.com \
--to=pauld@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.