From: Tejun Heo <tj@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <guro@fb.com>, Phil Auld <pauld@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>
Subject: Re: [PATCH 2/5] cgroup/cpuset: Add new cpus.partition type with no load balancing
Date: Wed, 16 Jun 2021 16:47:40 -0400 [thread overview]
Message-ID: <YMpjbCWpSDIz4bHt@slm.duckdns.org> (raw)
In-Reply-To: <20210603212416.25934-3-longman@redhat.com>
Hello,
Generally looks fine to me.
On Thu, Jun 03, 2021 at 05:24:13PM -0400, Waiman Long wrote:
> @@ -1984,12 +1987,31 @@ static int update_prstate(struct cpuset *cs, int val)
> goto out;
>
> err = update_parent_subparts_cpumask(cs, partcmd_enable,
> - NULL, &tmp);
> + NULL, &tmpmask);
> +
> if (err) {
> update_flag(CS_CPU_EXCLUSIVE, cs, 0);
> goto out;
> + } else if (new_prs == PRS_ENABLED_NOLB) {
> + /*
> + * Disable the load balance flag should not return an
^ing
and "else if" after "if (err) goto out" block is weird. The two conditions
don't need to be tied together.
> @@ -2518,6 +2547,9 @@ static int sched_partition_show(struct seq_file *seq, void *v)
> case PRS_ENABLED:
> seq_puts(seq, "root\n");
> break;
> + case PRS_ENABLED_NOLB:
> + seq_puts(seq, "root-nolb\n");
> + break;
> case PRS_DISABLED:
> seq_puts(seq, "member\n");
> break;
> @@ -2544,6 +2576,8 @@ static ssize_t sched_partition_write(struct kernfs_open_file *of, char *buf,
> val = PRS_ENABLED;
> else if (!strcmp(buf, "member"))
> val = PRS_DISABLED;
> + else if (!strcmp(buf, "root-nolb"))
> + val = PRS_ENABLED_NOLB;
> else
> return -EINVAL;
I wonder whether there's a better name than "root-nolb" because nolb isn't
the most readable and we are using space as the delimiter for other names.
Would something like "isolated" work?
Thanks.
--
tejun
next prev parent reply other threads:[~2021-06-16 20:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 21:24 [PATCH 0/5] cgroup/cpuset: Enable cpuset partition with no load balancing Waiman Long
2021-06-03 21:24 ` [PATCH 1/5] cgroup/cpuset: Don't call validate_change() for some flag changes Waiman Long
2021-06-16 20:39 ` Tejun Heo
2021-06-17 2:53 ` Waiman Long
2021-06-03 21:24 ` [PATCH 2/5] cgroup/cpuset: Add new cpus.partition type with no load balancing Waiman Long
2021-06-10 18:50 ` Peter Zijlstra
2021-06-10 18:50 ` Peter Zijlstra
2021-06-10 19:16 ` Waiman Long
2021-06-10 19:39 ` Peter Zijlstra
2021-06-10 19:00 ` Peter Zijlstra
2021-06-10 19:00 ` Peter Zijlstra
2021-06-10 19:21 ` Waiman Long
2021-06-16 20:47 ` Tejun Heo [this message]
2021-06-17 2:57 ` Waiman Long
2021-06-17 2:57 ` Waiman Long
2021-06-03 21:24 ` [PATCH 3/5] cgroup/cpuset: Allow non-top parent partition root to distribute out all CPUs Waiman Long
2021-06-03 21:24 ` Waiman Long
2021-06-16 20:57 ` Tejun Heo
2021-06-16 20:57 ` Tejun Heo
2021-06-17 20:45 ` Waiman Long
2021-06-17 20:45 ` Waiman Long
2021-06-03 21:24 ` [PATCH 4/5] cgroup/cpuset: Update description of cpuset.cpus.partition in cgroup-v2.rst Waiman Long
2021-06-03 21:24 ` [PATCH 5/5] kselftest/cgroup: Add cpuset v2 partition root state test Waiman Long
2021-06-10 14:19 ` [PATCH 0/5] cgroup/cpuset: Enable cpuset partition with no load balancing Phil Auld
2021-06-10 14:19 ` Phil Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMpjbCWpSDIz4bHt@slm.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.