* [bug report] scsi: iscsi: Drop suspend calls from ep_disconnect
@ 2021-06-08 7:00 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2021-06-08 7:00 UTC (permalink / raw)
To: michael.christie; +Cc: linux-scsi
Hello Mike Christie,
This is a semi-automatic email about new static checker warnings.
The patch 27e986289e73: "scsi: iscsi: Drop suspend calls from
ep_disconnect" from May 25, 2021, leads to the following Smatch
complaint:
drivers/scsi/qedi/qedi_iscsi.c:1669 qedi_clear_session_ctx()
warn: variable dereferenced before check 'conn' (see line 1666)
drivers/scsi/qedi/qedi_iscsi.c
1665 struct iscsi_conn *conn = session->leadconn;
1666 struct qedi_conn *qedi_conn = conn->dd_data;
^^^^^^^^^^^^^
Dereference
1667
1668 if (iscsi_is_session_online(cls_sess)) {
1669 if (conn)
^^^^
This new NULL check is too late.
1670 iscsi_suspend_queue(conn);
1671 qedi_ep_disconnect(qedi_conn->iscsi_ep);
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-08 7:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 7:00 [bug report] scsi: iscsi: Drop suspend calls from ep_disconnect Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.