From: Dan Carpenter <dan.carpenter@oracle.com>
To: michael.christie@oracle.com
Cc: linux-scsi@vger.kernel.org
Subject: [bug report] scsi: iscsi: Drop suspend calls from ep_disconnect
Date: Tue, 8 Jun 2021 10:00:39 +0300 [thread overview]
Message-ID: <YL8Vl7HGiJhHkgHr@mwanda> (raw)
Hello Mike Christie,
This is a semi-automatic email about new static checker warnings.
The patch 27e986289e73: "scsi: iscsi: Drop suspend calls from
ep_disconnect" from May 25, 2021, leads to the following Smatch
complaint:
drivers/scsi/qedi/qedi_iscsi.c:1669 qedi_clear_session_ctx()
warn: variable dereferenced before check 'conn' (see line 1666)
drivers/scsi/qedi/qedi_iscsi.c
1665 struct iscsi_conn *conn = session->leadconn;
1666 struct qedi_conn *qedi_conn = conn->dd_data;
^^^^^^^^^^^^^
Dereference
1667
1668 if (iscsi_is_session_online(cls_sess)) {
1669 if (conn)
^^^^
This new NULL check is too late.
1670 iscsi_suspend_queue(conn);
1671 qedi_ep_disconnect(qedi_conn->iscsi_ep);
regards,
dan carpenter
reply other threads:[~2021-06-08 7:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YL8Vl7HGiJhHkgHr@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michael.christie@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.