From: Dave Airlie <airlied@gmail.com> To: Daniel Vetter <daniel@ffwll.ch> Cc: Dave Airlie <airlied@redhat.com>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, dri-devel <dri-devel@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@intel.com> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms Date: Tue, 1 Jun 2021 17:19:47 +1000 [thread overview] Message-ID: <CAPM=9txR2ZDpLX1bwzgqq+f9nsiP0feWB+1=tpto2zf_qPKu=Q@mail.gmail.com> (raw) In-Reply-To: <YK9uwBAvUD+2NYlL@phenom.ffwll.local> On Thu, 27 May 2021 at 20:04, Daniel Vetter <daniel@ffwll.ch> wrote: > > On Wed, May 26, 2021 at 10:35:49AM +1000, Dave Airlie wrote: > > On Wed, 12 May 2021 at 03:05, Daniel Vetter <daniel@ffwll.ch> wrote: > > > On Tue, May 11, 2021 at 10:31:39AM +0200, Zbigniew Kempczyński wrote: > > > > We have established previously we stop using relocations starting > > > > from gen12 platforms with Tigerlake as an exception. Unfortunately > > > > we need extend transition period and support relocations for two > > > > other igfx platforms - Rocketlake and Alderlake. > > > > > > > > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com> > > > > Cc: Dave Airlie <airlied@redhat.com> > > > > Cc: Daniel Vetter <daniel.vetter@intel.com> > > > > Cc: Jason Ekstrand <jason@jlekstrand.net> > > > > > > So the annoying thing here is that now media-driver is fixed: > > > > > > https://github.com/intel/media-driver/commit/144020c37770083974bedf59902b70b8f444c799 > > > > > > Which means igt is really the only thing left. > > > > > > Dave, is this still ok for an acked exception, or is this now leaning > > > towards "just fix igt"? > > > > Oh that isn't great is it, I had thought it was the media-driver, > > keeping a big uAPI like this open just for the test code seems a bit > > silly. I get the tests are testing more than just relocs, but it's a > > pretty big interface to leave lying around if we can avoid it. > > So since we need to do the work anyway for DG1+ what about some interim > hack? Currently ADL still has the require_force_probe flag set. We could > re-enable relocations just for ADL, only while this flag is set. This > gives us a bunch of wiggle room, unblocks everything else (CI is a bit on > fire right now due to this and practially unuseable on ADL gem areay) and > we'll still make sure that when ADL is all done we wont expose relocations > just for igt. > > Thoughts? I can handle that as a compromise, though I'd not want to block ADL getting out of alpha over some IGT that needs porting. Dave. > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Dave Airlie <airlied@gmail.com> To: Daniel Vetter <daniel@ffwll.ch> Cc: "Dave Airlie" <airlied@redhat.com>, "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>, "Intel Graphics Development" <intel-gfx@lists.freedesktop.org>, dri-devel <dri-devel@lists.freedesktop.org>, "Daniel Vetter" <daniel.vetter@intel.com> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms Date: Tue, 1 Jun 2021 17:19:47 +1000 [thread overview] Message-ID: <CAPM=9txR2ZDpLX1bwzgqq+f9nsiP0feWB+1=tpto2zf_qPKu=Q@mail.gmail.com> (raw) In-Reply-To: <YK9uwBAvUD+2NYlL@phenom.ffwll.local> On Thu, 27 May 2021 at 20:04, Daniel Vetter <daniel@ffwll.ch> wrote: > > On Wed, May 26, 2021 at 10:35:49AM +1000, Dave Airlie wrote: > > On Wed, 12 May 2021 at 03:05, Daniel Vetter <daniel@ffwll.ch> wrote: > > > On Tue, May 11, 2021 at 10:31:39AM +0200, Zbigniew Kempczyński wrote: > > > > We have established previously we stop using relocations starting > > > > from gen12 platforms with Tigerlake as an exception. Unfortunately > > > > we need extend transition period and support relocations for two > > > > other igfx platforms - Rocketlake and Alderlake. > > > > > > > > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com> > > > > Cc: Dave Airlie <airlied@redhat.com> > > > > Cc: Daniel Vetter <daniel.vetter@intel.com> > > > > Cc: Jason Ekstrand <jason@jlekstrand.net> > > > > > > So the annoying thing here is that now media-driver is fixed: > > > > > > https://github.com/intel/media-driver/commit/144020c37770083974bedf59902b70b8f444c799 > > > > > > Which means igt is really the only thing left. > > > > > > Dave, is this still ok for an acked exception, or is this now leaning > > > towards "just fix igt"? > > > > Oh that isn't great is it, I had thought it was the media-driver, > > keeping a big uAPI like this open just for the test code seems a bit > > silly. I get the tests are testing more than just relocs, but it's a > > pretty big interface to leave lying around if we can avoid it. > > So since we need to do the work anyway for DG1+ what about some interim > hack? Currently ADL still has the require_force_probe flag set. We could > re-enable relocations just for ADL, only while this flag is set. This > gives us a bunch of wiggle room, unblocks everything else (CI is a bit on > fire right now due to this and practially unuseable on ADL gem areay) and > we'll still make sure that when ADL is all done we wont expose relocations > just for igt. > > Thoughts? I can handle that as a compromise, though I'd not want to block ADL getting out of alpha over some IGT that needs porting. Dave. > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch
next prev parent reply other threads:[~2021-06-01 7:20 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-11 8:31 [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms Zbigniew Kempczyński 2021-05-11 8:31 ` Zbigniew Kempczyński 2021-05-11 9:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add relocation exceptions for two other platforms (rev2) Patchwork 2021-05-11 10:27 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-05-11 17:04 ` [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms Daniel Vetter 2021-05-11 17:04 ` Daniel Vetter 2021-05-26 0:35 ` [Intel-gfx] " Dave Airlie 2021-05-26 0:35 ` Dave Airlie 2021-05-27 10:04 ` Daniel Vetter 2021-05-27 10:04 ` Daniel Vetter 2021-06-01 7:19 ` Dave Airlie [this message] 2021-06-01 7:19 ` Dave Airlie 2021-06-01 7:28 ` Daniel Vetter 2021-06-01 7:28 ` Daniel Vetter -- strict thread matches above, loose matches on Subject: below -- 2021-06-17 5:44 Zbigniew Kempczyński 2021-06-17 10:19 ` Rodrigo Vivi 2021-06-16 9:48 Zbigniew Kempczyński 2021-06-16 13:54 ` Rodrigo Vivi 2021-06-11 6:23 Zbigniew Kempczyński 2021-06-10 10:39 Zbigniew Kempczyński 2021-06-10 14:36 ` Rodrigo Vivi 2021-06-10 14:36 ` Rodrigo Vivi 2021-06-11 6:09 ` Zbigniew Kempczyński 2021-06-11 6:09 ` Zbigniew Kempczyński 2021-06-11 8:54 ` Rodrigo Vivi 2021-06-11 8:54 ` Rodrigo Vivi 2021-06-14 8:35 ` Zbigniew Kempczyński 2021-06-14 8:35 ` Zbigniew Kempczyński 2021-06-14 16:28 ` Rodrigo Vivi 2021-06-14 16:28 ` Rodrigo Vivi 2021-06-01 14:24 Zbigniew Kempczyński 2021-06-03 19:45 ` David Airlie 2021-06-09 13:14 ` Daniel Vetter 2021-06-01 8:28 Zbigniew Kempczyński 2021-06-01 12:26 ` Jani Nikula 2021-06-01 12:26 ` Jani Nikula 2021-04-28 17:30 Zbigniew Kempczyński
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAPM=9txR2ZDpLX1bwzgqq+f9nsiP0feWB+1=tpto2zf_qPKu=Q@mail.gmail.com' \ --to=airlied@gmail.com \ --cc=airlied@redhat.com \ --cc=daniel.vetter@intel.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.