From: David Airlie <airlied@redhat.com> To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com> Cc: Daniel Vetter <daniel.vetter@intel.com>, "Development, Intel" <intel-gfx@lists.freedesktop.org>, dri-devel <dri-devel@lists.freedesktop.org> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms Date: Fri, 4 Jun 2021 05:45:24 +1000 [thread overview] Message-ID: <CAMwc25px1ZkCbThbpTtL+Dv+6b9aeXR4igpfC41pTDDFq6Uehg@mail.gmail.com> (raw) In-Reply-To: <20210601142442.100754-1-zbigniew.kempczynski@intel.com> On Wed, Jun 2, 2021 at 12:25 AM Zbigniew Kempczyński <zbigniew.kempczynski@intel.com> wrote: > > We have established previously we stop using relocations starting > from gen12 platforms with Tigerlake as an exception. We keep this > statement but we want to enable relocations conditionally for > Rocketlake and Alderlake under require_force_probe flag set. > > Keeping relocations under require_force_probe flag is interim solution > until IGTs will be rewritten to use softpin. > > v2: - remove inline from function definition (Jani) > - fix indentation > > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com> > Cc: Dave Airlie <airlied@redhat.com> > Cc: Daniel Vetter <daniel.vetter@intel.com> > Cc: Jason Ekstrand <jason@jlekstrand.net> Acked-by: Dave Airlie <airlied@redhat.com> > --- > .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 24 +++++++++++++++---- > 1 file changed, 19 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > index 297143511f99..78b86a7bc39a 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > @@ -491,16 +491,30 @@ eb_unreserve_vma(struct eb_vma *ev) > ev->flags &= ~__EXEC_OBJECT_RESERVED; > } > > +static bool platform_has_relocs_enabled(const struct i915_execbuffer *eb) > +{ > + /* > + * Relocations are disallowed starting from gen12 with Tigerlake > + * as an exception. We allow temporarily use relocations for Rocketlake > + * and Alderlake when require_force_probe flag is set. > + */ > + if (INTEL_GEN(eb->i915) < 12 || IS_TIGERLAKE(eb->i915)) > + return true; > + > + if (INTEL_INFO(eb->i915)->require_force_probe && > + (IS_ROCKETLAKE(eb->i915) || IS_ALDERLAKE_S(eb->i915) || > + IS_ALDERLAKE_P(eb->i915))) > + return true; > + > + return false; > +} > + > static int > eb_validate_vma(struct i915_execbuffer *eb, > struct drm_i915_gem_exec_object2 *entry, > struct i915_vma *vma) > { > - /* Relocations are disallowed for all platforms after TGL-LP. This > - * also covers all platforms with local memory. > - */ > - if (entry->relocation_count && > - INTEL_GEN(eb->i915) >= 12 && !IS_TIGERLAKE(eb->i915)) > + if (entry->relocation_count && !platform_has_relocs_enabled(eb)) > return -EINVAL; > > if (unlikely(entry->flags & eb->invalid_flags)) > -- > 2.26.0 > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: David Airlie <airlied@redhat.com> To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com> Cc: Daniel Vetter <daniel.vetter@intel.com>, "Development, Intel" <intel-gfx@lists.freedesktop.org>, Jason Ekstrand <jason@jlekstrand.net>, dri-devel <dri-devel@lists.freedesktop.org> Subject: Re: [PATCH] drm/i915: Add relocation exceptions for two other platforms Date: Fri, 4 Jun 2021 05:45:24 +1000 [thread overview] Message-ID: <CAMwc25px1ZkCbThbpTtL+Dv+6b9aeXR4igpfC41pTDDFq6Uehg@mail.gmail.com> (raw) In-Reply-To: <20210601142442.100754-1-zbigniew.kempczynski@intel.com> On Wed, Jun 2, 2021 at 12:25 AM Zbigniew Kempczyński <zbigniew.kempczynski@intel.com> wrote: > > We have established previously we stop using relocations starting > from gen12 platforms with Tigerlake as an exception. We keep this > statement but we want to enable relocations conditionally for > Rocketlake and Alderlake under require_force_probe flag set. > > Keeping relocations under require_force_probe flag is interim solution > until IGTs will be rewritten to use softpin. > > v2: - remove inline from function definition (Jani) > - fix indentation > > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com> > Cc: Dave Airlie <airlied@redhat.com> > Cc: Daniel Vetter <daniel.vetter@intel.com> > Cc: Jason Ekstrand <jason@jlekstrand.net> Acked-by: Dave Airlie <airlied@redhat.com> > --- > .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 24 +++++++++++++++---- > 1 file changed, 19 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > index 297143511f99..78b86a7bc39a 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > @@ -491,16 +491,30 @@ eb_unreserve_vma(struct eb_vma *ev) > ev->flags &= ~__EXEC_OBJECT_RESERVED; > } > > +static bool platform_has_relocs_enabled(const struct i915_execbuffer *eb) > +{ > + /* > + * Relocations are disallowed starting from gen12 with Tigerlake > + * as an exception. We allow temporarily use relocations for Rocketlake > + * and Alderlake when require_force_probe flag is set. > + */ > + if (INTEL_GEN(eb->i915) < 12 || IS_TIGERLAKE(eb->i915)) > + return true; > + > + if (INTEL_INFO(eb->i915)->require_force_probe && > + (IS_ROCKETLAKE(eb->i915) || IS_ALDERLAKE_S(eb->i915) || > + IS_ALDERLAKE_P(eb->i915))) > + return true; > + > + return false; > +} > + > static int > eb_validate_vma(struct i915_execbuffer *eb, > struct drm_i915_gem_exec_object2 *entry, > struct i915_vma *vma) > { > - /* Relocations are disallowed for all platforms after TGL-LP. This > - * also covers all platforms with local memory. > - */ > - if (entry->relocation_count && > - INTEL_GEN(eb->i915) >= 12 && !IS_TIGERLAKE(eb->i915)) > + if (entry->relocation_count && !platform_has_relocs_enabled(eb)) > return -EINVAL; > > if (unlikely(entry->flags & eb->invalid_flags)) > -- > 2.26.0 >
next prev parent reply other threads:[~2021-06-03 19:45 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-01 14:24 [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms Zbigniew Kempczyński 2021-06-01 14:24 ` Zbigniew Kempczyński 2021-06-01 21:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add relocation exceptions for two other platforms (rev4) Patchwork 2021-06-02 7:43 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-06-02 11:54 ` Zbigniew Kempczyński 2021-06-03 19:45 ` David Airlie [this message] 2021-06-03 19:45 ` [PATCH] drm/i915: Add relocation exceptions for two other platforms David Airlie 2021-06-09 13:14 ` Daniel Vetter 2021-06-09 13:14 ` [Intel-gfx] " Daniel Vetter -- strict thread matches above, loose matches on Subject: below -- 2021-06-17 5:44 Zbigniew Kempczyński 2021-06-17 10:19 ` Rodrigo Vivi 2021-06-16 9:48 Zbigniew Kempczyński 2021-06-16 13:54 ` Rodrigo Vivi 2021-06-11 6:23 Zbigniew Kempczyński 2021-06-10 10:39 Zbigniew Kempczyński 2021-06-10 14:36 ` Rodrigo Vivi 2021-06-10 14:36 ` Rodrigo Vivi 2021-06-11 6:09 ` Zbigniew Kempczyński 2021-06-11 6:09 ` Zbigniew Kempczyński 2021-06-11 8:54 ` Rodrigo Vivi 2021-06-11 8:54 ` Rodrigo Vivi 2021-06-14 8:35 ` Zbigniew Kempczyński 2021-06-14 8:35 ` Zbigniew Kempczyński 2021-06-14 16:28 ` Rodrigo Vivi 2021-06-14 16:28 ` Rodrigo Vivi 2021-06-01 8:28 Zbigniew Kempczyński 2021-06-01 12:26 ` Jani Nikula 2021-06-01 12:26 ` Jani Nikula 2021-05-11 8:31 Zbigniew Kempczyński 2021-05-11 17:04 ` Daniel Vetter 2021-05-26 0:35 ` Dave Airlie 2021-05-26 0:35 ` Dave Airlie 2021-05-27 10:04 ` Daniel Vetter 2021-05-27 10:04 ` Daniel Vetter 2021-06-01 7:19 ` Dave Airlie 2021-06-01 7:19 ` Dave Airlie 2021-06-01 7:28 ` Daniel Vetter 2021-06-01 7:28 ` Daniel Vetter 2021-04-28 17:30 Zbigniew Kempczyński
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAMwc25px1ZkCbThbpTtL+Dv+6b9aeXR4igpfC41pTDDFq6Uehg@mail.gmail.com \ --to=airlied@redhat.com \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=zbigniew.kempczynski@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.