All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Breno Matheus Lima <brenomatheus@gmail.com>
To: Peter Chen <peter.chen@kernel.org>
Cc: Breno Lima <breno.lima@nxp.com>,
	gregkh@linuxfoundation.org, shawnguo@kernel.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	Fabio Estevam <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Jun Li <jun.li@nxp.com>
Subject: Re: [PATCH v2] mx8mm: usb: chipidea: Fix Battery Charger 1.2 CDP detection
Date: Sat, 12 Jun 2021 13:59:21 -0400	[thread overview]
Message-ID: <CAC4tdFXrGmmgui2uc-K2sgzxsgsQhQoARwO0720_wFb2ehpJ1A@mail.gmail.com> (raw)
In-Reply-To: <20210612072438.GA4580@Peter>

Hi Peter,

Em sáb., 12 de jun. de 2021 às 03:24, Peter Chen
<peter.chen@kernel.org> escreveu:
>
> On 21-06-11 10:56:07, Breno Lima wrote:
> > i.MX8MM cannot detect certain CDP USB HUBs. usbmisc_imx.c driver is not
> > following CDP timing requirements defined by USB BC 1.2 specification
> > and section 3.2.4 Detection Timing CDP.
> >
> > During Primary Detection the i.MX device should turn on VDP_SRC and
> > IDM_SINK for a minimum of 40ms (TVDPSRC_ON). After a time of TVDPSRC_ON,
> > the PD is allowed to check the status of the D- line. Current
> > implementation is waiting between 1ms and 2ms, and certain BC 1.2
> > complaint USB HUBs cannot be detected. Increase delay to 40ms allowing
> > enough time for primary detection.
> >
> > During secondary detection the PD is required to disable VDP_SRC and
>
> What does the "PD" mean here?
>

PD stands for Portable Device, I can send another version and mention
i.MX instead.

Thanks for pointing this out.

Best regards,
Breno Lima

WARNING: multiple messages have this Message-ID (diff)
From: Breno Matheus Lima <brenomatheus@gmail.com>
To: Peter Chen <peter.chen@kernel.org>
Cc: Breno Lima <breno.lima@nxp.com>,
	gregkh@linuxfoundation.org, shawnguo@kernel.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	 Fabio Estevam <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	linux-usb@vger.kernel.org,  linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,  Jun Li <jun.li@nxp.com>
Subject: Re: [PATCH v2] mx8mm: usb: chipidea: Fix Battery Charger 1.2 CDP detection
Date: Sat, 12 Jun 2021 13:59:21 -0400	[thread overview]
Message-ID: <CAC4tdFXrGmmgui2uc-K2sgzxsgsQhQoARwO0720_wFb2ehpJ1A@mail.gmail.com> (raw)
In-Reply-To: <20210612072438.GA4580@Peter>

Hi Peter,

Em sáb., 12 de jun. de 2021 às 03:24, Peter Chen
<peter.chen@kernel.org> escreveu:
>
> On 21-06-11 10:56:07, Breno Lima wrote:
> > i.MX8MM cannot detect certain CDP USB HUBs. usbmisc_imx.c driver is not
> > following CDP timing requirements defined by USB BC 1.2 specification
> > and section 3.2.4 Detection Timing CDP.
> >
> > During Primary Detection the i.MX device should turn on VDP_SRC and
> > IDM_SINK for a minimum of 40ms (TVDPSRC_ON). After a time of TVDPSRC_ON,
> > the PD is allowed to check the status of the D- line. Current
> > implementation is waiting between 1ms and 2ms, and certain BC 1.2
> > complaint USB HUBs cannot be detected. Increase delay to 40ms allowing
> > enough time for primary detection.
> >
> > During secondary detection the PD is required to disable VDP_SRC and
>
> What does the "PD" mean here?
>

PD stands for Portable Device, I can send another version and mention
i.MX instead.

Thanks for pointing this out.

Best regards,
Breno Lima

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-12 17:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11 14:56 [PATCH v2] mx8mm: usb: chipidea: Fix Battery Charger 1.2 CDP detection Breno Lima
2021-06-11 14:56 ` Breno Lima
2021-06-12  7:24 ` Peter Chen
2021-06-12  7:24   ` Peter Chen
2021-06-12 17:59   ` Breno Matheus Lima [this message]
2021-06-12 17:59     ` Breno Matheus Lima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAC4tdFXrGmmgui2uc-K2sgzxsgsQhQoARwO0720_wFb2ehpJ1A@mail.gmail.com \
    --to=brenomatheus@gmail.com \
    --cc=breno.lima@nxp.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jun.li@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter.chen@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.