From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F21D1C48BE5 for ; Sat, 12 Jun 2021 17:59:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5DE7610C7 for ; Sat, 12 Jun 2021 17:59:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230240AbhFLSBh (ORCPT ); Sat, 12 Jun 2021 14:01:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229633AbhFLSBg (ORCPT ); Sat, 12 Jun 2021 14:01:36 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A800C061574; Sat, 12 Jun 2021 10:59:36 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id 131so14078713ljj.3; Sat, 12 Jun 2021 10:59:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=91owpaF2W4JTE1rLDzae7eV/utnfUIkLjonIrTqWctw=; b=T8e0ZAXkaUaUkD4HeUO7qhqHzDK+IhSwWzQ9/TohafpqcLqKdMvjjhn+DrBpQUKZZC rjqWcZ2se/jMMgJ09vPHTBe4uUTo0kmh5/7m3AJzgtZl2Rc1CbNf4GOajsdTs0LBcQUq 2OrsMLloBV3xfjBuIWd63W/OWrkfnG1OiAcLsFbKNTWTpAkF3h5TkElKjpkJOI9DuFAP B+7KKwAFrsjLzCfZht7q4zplsKZyeV6e00ugZ/cFPF717kJPSuNZuCqrItoA2K7n0Psu oNproxBU38PkPWVt+bNMf8PYvpZxRePRPYCMy50illm5JRjkyvkaNhnSdLlpW9lGREQm pZQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=91owpaF2W4JTE1rLDzae7eV/utnfUIkLjonIrTqWctw=; b=nPK0PbAKFFWOCnKL6CUMFQDMUUeCVfDTQQjJdsJUDBMLvIMjrPVQfWg9BxZdV4rtXr 6lt7Ywb4jd3pok/n7LYaX5bZP4++O77JZDp2YuBn9m2TuRQCQ8Z0QUkSG9Ubk5zvix93 kbXdtVpTPoxH/aVJqrky9xkCLb+gnBScPdugtFzbC3z9bX5+1XOu3eMVcgYBw/U1eCSf mVyFz4ekDtCJ/m2D1mPV4B2cxcD4sK1rjrOL3qXUUOoJWT3L+UKpbnsIoULjlCqPoc+K W56XcpeqUghW+4Wa+SpuoQQnPJ89NF6VgubJLbrLaYTKaHQbRYBrEYXLOeT+VTzMYh72 5vQg== X-Gm-Message-State: AOAM533/Oh0VMFYr7/Elu8tackArBm4zM0Nf7lxhUJWGl58FoFWqTC35 yC72pHddeUWtRZvAAI5tvYD8PIRHvHv7CFiDLHs= X-Google-Smtp-Source: ABdhPJzrKD1MyMwrpMGoTcyk7feA6asP4uJ32aZoFpDWXOILBrLXS48SNSKB/XYWWXY/1GJ213e4ijzKPI4ihdpnfX8= X-Received: by 2002:a2e:9715:: with SMTP id r21mr7632513lji.46.1623520773299; Sat, 12 Jun 2021 10:59:33 -0700 (PDT) MIME-Version: 1.0 References: <20210611145607.147207-1-breno.lima@nxp.com> <20210612072438.GA4580@Peter> In-Reply-To: <20210612072438.GA4580@Peter> From: Breno Matheus Lima Date: Sat, 12 Jun 2021 13:59:21 -0400 Message-ID: Subject: Re: [PATCH v2] mx8mm: usb: chipidea: Fix Battery Charger 1.2 CDP detection To: Peter Chen Cc: Breno Lima , gregkh@linuxfoundation.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, Fabio Estevam , dl-linux-imx , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jun Li Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, Em s=C3=A1b., 12 de jun. de 2021 =C3=A0s 03:24, Peter Chen escreveu: > > On 21-06-11 10:56:07, Breno Lima wrote: > > i.MX8MM cannot detect certain CDP USB HUBs. usbmisc_imx.c driver is not > > following CDP timing requirements defined by USB BC 1.2 specification > > and section 3.2.4 Detection Timing CDP. > > > > During Primary Detection the i.MX device should turn on VDP_SRC and > > IDM_SINK for a minimum of 40ms (TVDPSRC_ON). After a time of TVDPSRC_ON= , > > the PD is allowed to check the status of the D- line. Current > > implementation is waiting between 1ms and 2ms, and certain BC 1.2 > > complaint USB HUBs cannot be detected. Increase delay to 40ms allowing > > enough time for primary detection. > > > > During secondary detection the PD is required to disable VDP_SRC and > > What does the "PD" mean here? > PD stands for Portable Device, I can send another version and mention i.MX instead. Thanks for pointing this out. Best regards, Breno Lima From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C6ADC48BCF for ; Sat, 12 Jun 2021 18:02:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D6016120D for ; Sat, 12 Jun 2021 18:02:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D6016120D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hQ6TauqMqgxxYM+DYAUPspjRtEwmWcbOQuq1RlgKwec=; b=0gFyNDcKnU4CF1 qm69igJNX9XfdtociVE7aQ02PgD0gkR9ZK4ggOoxThL7jhodiMItV8BItS43vdNnAm/FFBughPTuD K342NesU561YxkSvrEwzixyIVW4ULOn4jXQEWuJ12zmI7NkhJ8+2anQJKnTvWv1/uKDigri7eKrkH HOujLgOdpTS97EYpKrcKMoJDxjd4BObvJbWMTQUz8J8J+TogEz6j/YemIPn/AutC56WpR50EYV2my 0itxsALW5Mq6g611wc5W18nRj6dAKRsNs9S0emIMGwriVBCA3SXJaakIb8sIqLN1aKRIkjUZC9f4s u6JteKYZn9NH+uf4BZVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ls7w0-008vje-60; Sat, 12 Jun 2021 18:00:40 +0000 Received: from mail-lj1-f176.google.com ([209.85.208.176]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ls7vw-008vjB-Kc for linux-arm-kernel@lists.infradead.org; Sat, 12 Jun 2021 18:00:37 +0000 Received: by mail-lj1-f176.google.com with SMTP id z22so14030699ljh.8 for ; Sat, 12 Jun 2021 11:00:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=91owpaF2W4JTE1rLDzae7eV/utnfUIkLjonIrTqWctw=; b=T8e0ZAXkaUaUkD4HeUO7qhqHzDK+IhSwWzQ9/TohafpqcLqKdMvjjhn+DrBpQUKZZC rjqWcZ2se/jMMgJ09vPHTBe4uUTo0kmh5/7m3AJzgtZl2Rc1CbNf4GOajsdTs0LBcQUq 2OrsMLloBV3xfjBuIWd63W/OWrkfnG1OiAcLsFbKNTWTpAkF3h5TkElKjpkJOI9DuFAP B+7KKwAFrsjLzCfZht7q4zplsKZyeV6e00ugZ/cFPF717kJPSuNZuCqrItoA2K7n0Psu oNproxBU38PkPWVt+bNMf8PYvpZxRePRPYCMy50illm5JRjkyvkaNhnSdLlpW9lGREQm pZQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=91owpaF2W4JTE1rLDzae7eV/utnfUIkLjonIrTqWctw=; b=fuInSW6BE8ynABlN4rXdDcwK7xviiKjZdD0MtKZeHPR9oE23vBNxTkjatjl5aJzqxW nQMqKoFKBfKDkkXejOuQ+if+tfAsFfZqW60PUqUEJuTbg4IbjyLCounFw8CUHTfUNHHg dP/F+5GJM16j4ijVe1vLQhxpQJGLiUcF26Eh8GesNpNlc5zBIZsI44oV0UiI3o5dbhN8 CQ7LKU4+rqDnPyHe1AGu5yqI+8zc3JlRIbKtfe5WWEGI9UDkLs5zelZapsJ18+EjSU3F DFqMHw2adEXOkRWSqrv0I3hXNsz563fNmhocE5mp0SocPKFT1EEykMxJqn95DxuX9+Zg BwIQ== X-Gm-Message-State: AOAM530gMXDHBk0yUq5n4EpK9Czfsol0ONeun6pkNSn3wAWSX8bd8kI1 1cCvvgxiHbC43U9xuDPJvaugW8a0VjhHLiTTCOk= X-Google-Smtp-Source: ABdhPJzrKD1MyMwrpMGoTcyk7feA6asP4uJ32aZoFpDWXOILBrLXS48SNSKB/XYWWXY/1GJ213e4ijzKPI4ihdpnfX8= X-Received: by 2002:a2e:9715:: with SMTP id r21mr7632513lji.46.1623520773299; Sat, 12 Jun 2021 10:59:33 -0700 (PDT) MIME-Version: 1.0 References: <20210611145607.147207-1-breno.lima@nxp.com> <20210612072438.GA4580@Peter> In-Reply-To: <20210612072438.GA4580@Peter> From: Breno Matheus Lima Date: Sat, 12 Jun 2021 13:59:21 -0400 Message-ID: Subject: Re: [PATCH v2] mx8mm: usb: chipidea: Fix Battery Charger 1.2 CDP detection To: Peter Chen Cc: Breno Lima , gregkh@linuxfoundation.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, Fabio Estevam , dl-linux-imx , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jun Li X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210612_110036_702541_E819E954 X-CRM114-Status: GOOD ( 12.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUGV0ZXIsCgpFbSBzw6FiLiwgMTIgZGUganVuLiBkZSAyMDIxIMOgcyAwMzoyNCwgUGV0ZXIg Q2hlbgo8cGV0ZXIuY2hlbkBrZXJuZWwub3JnPiBlc2NyZXZldToKPgo+IE9uIDIxLTA2LTExIDEw OjU2OjA3LCBCcmVubyBMaW1hIHdyb3RlOgo+ID4gaS5NWDhNTSBjYW5ub3QgZGV0ZWN0IGNlcnRh aW4gQ0RQIFVTQiBIVUJzLiB1c2JtaXNjX2lteC5jIGRyaXZlciBpcyBub3QKPiA+IGZvbGxvd2lu ZyBDRFAgdGltaW5nIHJlcXVpcmVtZW50cyBkZWZpbmVkIGJ5IFVTQiBCQyAxLjIgc3BlY2lmaWNh dGlvbgo+ID4gYW5kIHNlY3Rpb24gMy4yLjQgRGV0ZWN0aW9uIFRpbWluZyBDRFAuCj4gPgo+ID4g RHVyaW5nIFByaW1hcnkgRGV0ZWN0aW9uIHRoZSBpLk1YIGRldmljZSBzaG91bGQgdHVybiBvbiBW RFBfU1JDIGFuZAo+ID4gSURNX1NJTksgZm9yIGEgbWluaW11bSBvZiA0MG1zIChUVkRQU1JDX09O KS4gQWZ0ZXIgYSB0aW1lIG9mIFRWRFBTUkNfT04sCj4gPiB0aGUgUEQgaXMgYWxsb3dlZCB0byBj aGVjayB0aGUgc3RhdHVzIG9mIHRoZSBELSBsaW5lLiBDdXJyZW50Cj4gPiBpbXBsZW1lbnRhdGlv biBpcyB3YWl0aW5nIGJldHdlZW4gMW1zIGFuZCAybXMsIGFuZCBjZXJ0YWluIEJDIDEuMgo+ID4g Y29tcGxhaW50IFVTQiBIVUJzIGNhbm5vdCBiZSBkZXRlY3RlZC4gSW5jcmVhc2UgZGVsYXkgdG8g NDBtcyBhbGxvd2luZwo+ID4gZW5vdWdoIHRpbWUgZm9yIHByaW1hcnkgZGV0ZWN0aW9uLgo+ID4K PiA+IER1cmluZyBzZWNvbmRhcnkgZGV0ZWN0aW9uIHRoZSBQRCBpcyByZXF1aXJlZCB0byBkaXNh YmxlIFZEUF9TUkMgYW5kCj4KPiBXaGF0IGRvZXMgdGhlICJQRCIgbWVhbiBoZXJlPwo+CgpQRCBz dGFuZHMgZm9yIFBvcnRhYmxlIERldmljZSwgSSBjYW4gc2VuZCBhbm90aGVyIHZlcnNpb24gYW5k IG1lbnRpb24KaS5NWCBpbnN0ZWFkLgoKVGhhbmtzIGZvciBwb2ludGluZyB0aGlzIG91dC4KCkJl c3QgcmVnYXJkcywKQnJlbm8gTGltYQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=