Re: [PATCH v5 7/7] interconnect: mediatek: Add MediaTek MT8183/8195 EMI Interconnect driver

From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Georgi Djakov <djakov@kernel.org>
Cc: robh@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, matthias.bgg@gmail.com, lgirdwood@gmail.com,
	broonie@kernel.org, keescook@chromium.org, gustavoars@kernel.org,
	henryc.chen@mediatek.com, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, kernel@collabora.com,
	wenst@chromium.org, amergnat@baylibre.com
Subject: Re: [PATCH v5 7/7] interconnect: mediatek: Add MediaTek MT8183/8195 EMI Interconnect driver
Date: Mon, 6 May 2024 12:49:12 +0200	[thread overview]
Message-ID: <522a4bbb-af1b-418b-b00c-95657222160b@collabora.com> (raw)
In-Reply-To: <52335ded-43e7-4694-80bf-6ceee7d918d8@kernel.org>

Il 03/05/24 13:53, Georgi Djakov ha scritto:
> Hi Angelo,
> 
> On 24.04.24 12:54, AngeloGioacchino Del Regno wrote:
>> Add an interconnect driver for the External Memory Interface (EMI),
>> voting for bus bandwidth over the Dynamic Voltage and Frequency Scaling
>> Resource Collector (DVFSRC).
>>
>>               ICC provider         ICC Nodes
>>                                ----          ----
>>               ---------       |CPU |   |--- |VPU |
>>      -----   |         |-----  ----    |     ----
>>     |DRAM |--|DRAM     |       ----    |     ----
>>     |     |--|scheduler|----- |GPU |   |--- |DISP|
>>     |     |--|(EMI)    |       ----    |     ----
>>     |     |--|         |       -----   |     ----
>>      -----   |         |----- |MMSYS|--|--- |VDEC|
>>               ---------        -----   |     ----
>>                 /|\                    |     ----
>>                  |change DRAM freq     |--- |VENC|
>>               ----------               |     ----
>>              |  DVFSR   |              |
>>              |          |              |     ----
>>               ----------               |--- |IMG |
>>                                        |     ----
>>                                        |     ----
>>                                        |--- |CAM |
>>                                              ----
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> 
> Thank you for working on this! It looks good to me.
> Do we have a plan how to merge all this?
> 

Nothing (regulator, nor interconnect)  will ever get enabled by Kconfig unless
the drivers/soc/mediatek patches are picked (or COMPILE_TEST!).... so I guess
we can just pick per-subsystem and call it a day :-)

As for the bindings, patch [3/7] *depends on* [1/7] and [2/7], but there is no
reverse dependency (so 1-2 can be picked, no warnings).

Otherwise I can pick all bindings, or.... whatever is easier for you :-)

Cheers,
Angelo

> Thanks,
> Georgi
> 
>> ---
>>   drivers/interconnect/Kconfig            |   1 +
>>   drivers/interconnect/Makefile           |   1 +
>>   drivers/interconnect/mediatek/Kconfig   |  29 ++
>>   drivers/interconnect/mediatek/Makefile  |   5 +
>>   drivers/interconnect/mediatek/icc-emi.c | 153 +++++++++++
>>   drivers/interconnect/mediatek/icc-emi.h |  40 +++
>>   drivers/interconnect/mediatek/mt8183.c  | 143 ++++++++++
>>   drivers/interconnect/mediatek/mt8195.c  | 339 ++++++++++++++++++++++++
>>   8 files changed, 711 insertions(+)
>>   create mode 100644 drivers/interconnect/mediatek/Kconfig
>>   create mode 100644 drivers/interconnect/mediatek/Makefile
>>   create mode 100644 drivers/interconnect/mediatek/icc-emi.c
>>   create mode 100644 drivers/interconnect/mediatek/icc-emi.h
>>   create mode 100644 drivers/interconnect/mediatek/mt8183.c
>>   create mode 100644 drivers/interconnect/mediatek/mt8195.c
> 