Re: [PATCH 0/2] i.MX93 ADC calibration settings

From: Jonathan Cameron <jic23@kernel.org>
To: Andrej Picej <andrej.picej@norik.com>
Cc: haibo.chen@nxp.com, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, lars@metafoo.de, shawnguo@kernel.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, robh@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	upstream@lists.phytec.de
Subject: Re: [PATCH 0/2] i.MX93 ADC calibration settings
Date: Sun, 24 Mar 2024 13:55:59 +0000	[thread overview]
Message-ID: <20240324135559.1640551d@jic23-huawei> (raw)
In-Reply-To: <20240320100407.1639082-1-andrej.picej@norik.com>

On Wed, 20 Mar 2024 11:04:04 +0100
Andrej Picej <andrej.picej@norik.com> wrote:

> Hi all,
> 
> we had some problems with failing ADC calibration on the i.MX93 boards.
> Changing default calibration settings fixed this. The board where this
> patches are useful is not yet upstream but will be soon (hopefully).

Tell us more.  My initial instinct is that this shouldn't be board specific.
What's the trade off we are making here?  Time vs precision of calibration or
something else?  If these are set to a level by default that doesn't work
for our board, maybe we should just change them for all devices?

Jonathan

> 
> Since we had these patches laying around we thought they might also be
> useful for someone else.
> 
> Best regards,
> Andrej
> 
> Andrej Picej (2):
>   iio: adc: imx93: Make calibration properties configurable
>   dt-bindings: iio: adc: nxp,imx93-adc.yaml: Add calibration properties
> 
>  .../bindings/iio/adc/nxp,imx93-adc.yaml       | 15 +++++
>  drivers/iio/adc/imx93_adc.c                   | 66 +++++++++++++++++--
>  2 files changed, 76 insertions(+), 5 deletions(-)
> 