From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F1C518622; Sun, 24 Mar 2024 13:56:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711288577; cv=none; b=MJqZKPrH9wYp+vvvBaJlISKwyciIEJE+gmh3ueBWGGIWfszRExIFDAF38OmdJ3jZj06BRE2FYJPiL7i+r8jbxpG9uUoMFQrMAjSoZ493s0bXW13h/u+kwfaillTPFTYch82U8ulfpLRMrY6kUCsfNTxMi60RbmFoYmJ+3KT7ZKw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711288577; c=relaxed/simple; bh=e0TNT9hvgC+8BnESH0czQ1VhFxeHzqWbWZrLn5xAYd8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=f3f//U3rcgmC46IR/6NWVvsn4ormSYEn+uFp8eiFeuKGghzKS/4iK+9gllMt5/Iv2tQJ+tkbgtAfJ3lwMuxE7Hz/8AtRcM1IeFI4T3QLnVq5sOaaACU+7cdO1HeOm3xW4GM1feHSn/EOlU+Z2DRUQLqDQdQee/IYHJ6DtLWYP9k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hVztc0Db; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hVztc0Db" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCFB6C433C7; Sun, 24 Mar 2024 13:56:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711288576; bh=e0TNT9hvgC+8BnESH0czQ1VhFxeHzqWbWZrLn5xAYd8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hVztc0DbRB5JJY/eLjUFyCa57frLkHN9uZ7tW++UahBQeIhB7nOVmKv+RHswWwLxv ++yoJqA8L/BxdLBSCNNDsstpF/mY3V0UZYowEpAAV+swglq4naUf/2e8H9ranEy/Qb cKUv7zyi5hg3pAQJOY0jURXlebB2HmSIYeDFRq79iZc8aSqzOnljnXfA+QUI5TsWIW P2EzAcpWzHd5RvdjWUHpt5u3a1igcNoOUzKTJWjPGslHNCnXbcZPnd81Uw81UW2+aQ NK0IIDTkMDlIX/4CAQw7JN+kjOxO8i8zfmhWRCKOvY9KhKEDlukYROj1xmp3zdj1VB I39TWa+PJ78mA== Date: Sun, 24 Mar 2024 13:55:59 +0000 From: Jonathan Cameron To: Andrej Picej Cc: haibo.chen@nxp.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, lars@metafoo.de, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, upstream@lists.phytec.de Subject: Re: [PATCH 0/2] i.MX93 ADC calibration settings Message-ID: <20240324135559.1640551d@jic23-huawei> In-Reply-To: <20240320100407.1639082-1-andrej.picej@norik.com> References: <20240320100407.1639082-1-andrej.picej@norik.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 20 Mar 2024 11:04:04 +0100 Andrej Picej wrote: > Hi all, > > we had some problems with failing ADC calibration on the i.MX93 boards. > Changing default calibration settings fixed this. The board where this > patches are useful is not yet upstream but will be soon (hopefully). Tell us more. My initial instinct is that this shouldn't be board specific. What's the trade off we are making here? Time vs precision of calibration or something else? If these are set to a level by default that doesn't work for our board, maybe we should just change them for all devices? Jonathan > > Since we had these patches laying around we thought they might also be > useful for someone else. > > Best regards, > Andrej > > Andrej Picej (2): > iio: adc: imx93: Make calibration properties configurable > dt-bindings: iio: adc: nxp,imx93-adc.yaml: Add calibration properties > > .../bindings/iio/adc/nxp,imx93-adc.yaml | 15 +++++ > drivers/iio/adc/imx93_adc.c | 66 +++++++++++++++++-- > 2 files changed, 76 insertions(+), 5 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F905C47DD9 for ; Sun, 24 Mar 2024 13:56:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=izpcyfG3YgGUv1IYEqF7or4+dfkMYQY6ICt/YVzlrRw=; b=RrF9jpbMZHpU7i FoRVMawg1R5xQ0HICwvwJTAvjLu/F2nMe7R7nXPytmiXEUPjw81Lk7KKuHAuLNVt40ubF8dtk1NJc QPTJDF5Z0hplHbu/ifnE7MVhYnWM11+3OrMut7m7XfdizMGPO8QPaf32gwWBy087vHBaeE5ZZ1SCW yooGRiLcWrCMFNw3gEpxRHZ6uGFe6pZU6KrnCxju+tpCb2NfSzAkAgt61IE+qLenkWsl16b4iFEC+ ngDWyBBr1hFWzNK7DV+SayMIgYtaJNleBAoEGdAP0PmR2Zw0wFLioxvtS5RnZganRylHFXct6Z+gD jYSyNFkCeY41VGB465wQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1roOKi-0000000Cf1s-2UEH; Sun, 24 Mar 2024 13:56:20 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1roOKf-0000000Cf1B-26aW for linux-arm-kernel@lists.infradead.org; Sun, 24 Mar 2024 13:56:18 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0518D60C51; Sun, 24 Mar 2024 13:56:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCFB6C433C7; Sun, 24 Mar 2024 13:56:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711288576; bh=e0TNT9hvgC+8BnESH0czQ1VhFxeHzqWbWZrLn5xAYd8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hVztc0DbRB5JJY/eLjUFyCa57frLkHN9uZ7tW++UahBQeIhB7nOVmKv+RHswWwLxv ++yoJqA8L/BxdLBSCNNDsstpF/mY3V0UZYowEpAAV+swglq4naUf/2e8H9ranEy/Qb cKUv7zyi5hg3pAQJOY0jURXlebB2HmSIYeDFRq79iZc8aSqzOnljnXfA+QUI5TsWIW P2EzAcpWzHd5RvdjWUHpt5u3a1igcNoOUzKTJWjPGslHNCnXbcZPnd81Uw81UW2+aQ NK0IIDTkMDlIX/4CAQw7JN+kjOxO8i8zfmhWRCKOvY9KhKEDlukYROj1xmp3zdj1VB I39TWa+PJ78mA== Date: Sun, 24 Mar 2024 13:55:59 +0000 From: Jonathan Cameron To: Andrej Picej Cc: haibo.chen@nxp.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, lars@metafoo.de, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, upstream@lists.phytec.de Subject: Re: [PATCH 0/2] i.MX93 ADC calibration settings Message-ID: <20240324135559.1640551d@jic23-huawei> In-Reply-To: <20240320100407.1639082-1-andrej.picej@norik.com> References: <20240320100407.1639082-1-andrej.picej@norik.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240324_065617_621286_AC50BC95 X-CRM114-Status: GOOD ( 14.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 20 Mar 2024 11:04:04 +0100 Andrej Picej wrote: > Hi all, > > we had some problems with failing ADC calibration on the i.MX93 boards. > Changing default calibration settings fixed this. The board where this > patches are useful is not yet upstream but will be soon (hopefully). Tell us more. My initial instinct is that this shouldn't be board specific. What's the trade off we are making here? Time vs precision of calibration or something else? If these are set to a level by default that doesn't work for our board, maybe we should just change them for all devices? Jonathan > > Since we had these patches laying around we thought they might also be > useful for someone else. > > Best regards, > Andrej > > Andrej Picej (2): > iio: adc: imx93: Make calibration properties configurable > dt-bindings: iio: adc: nxp,imx93-adc.yaml: Add calibration properties > > .../bindings/iio/adc/nxp,imx93-adc.yaml | 15 +++++ > drivers/iio/adc/imx93_adc.c | 66 +++++++++++++++++-- > 2 files changed, 76 insertions(+), 5 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel