From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
"Rajneesh Bhardwaj" <rajneesh.bhardwaj@amd.com>,
"Felix Kuehling" <Felix.Kuehling@amd.com>,
"Christian König" <christian.koenig@amd.com>,
dri-devel@lists.freedesktop.org
Subject: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4
Date: Mon, 22 Jan 2024 18:06:05 -0500 [thread overview]
Message-ID: <20240122180605.28daf23a@gandalf.local.home> (raw)
I just kicked off testing some patches on top of 6.8-rc1 and triggered this
immediately:
[ note this happened on both my 32 bit an 64 bit test machines, this is
just the 32 bit output ]
BUG: kernel NULL pointer dereference, address: 00000238
#PF: supervisor read access in kernel mode
#PF: error_code(0x0000) - not-present page
*pdpt = 0000000000000000 *pde = f000ff53f000ff53
Oops: 0000 [#1] PREEMPT SMP PTI
CPU: 0 PID: 9 Comm: kworker/0:1 Not tainted 6.8.0-rc1-test-00001-g2b44760609e9-dirty #1056
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014
Workqueue: events work_for_cpu_fn
EIP: ttm_device_init+0xb4/0x274
Code: 86 10 09 00 00 83 c4 0c 85 c0 0f 84 96 01 00 00 8b 45 ac 8d 9e 94 00 00 00 89 46 08 89 f0 e8 27 05 00 00 8b 55 a8 0f b6 45 98 <8b> 8a 38 02 00 00 50 0f b6 45 9c 50 89 d8 e8 95 ee ff ff 8b 45 a0
EAX: 00000000 EBX: c135a7e4 ECX: c135a7b0 EDX: 00000000
ESI: c135a750 EDI: 0007bc1d EBP: c11d7e4c ESP: c11d7de4
DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068 EFLAGS: 00010246
CR0: 80050033 CR2: 00000238 CR3: 145c4000 CR4: 000006f0
Call Trace:
? show_regs+0x4f/0x58
? __die+0x1d/0x58
? page_fault_oops+0x171/0x330
? lock_acquire+0xa4/0x280
? kernelmode_fixup_or_oops.constprop.0+0x7c/0xcc
? __bad_area_nosemaphore.constprop.0+0x124/0x1b4
? __mutex_lock+0x17f/0xb00
? bad_area_nosemaphore+0xf/0x14
? do_user_addr_fault+0x140/0x3e4
? exc_page_fault+0x5b/0x1d8
? pvclock_clocksource_read_nowd+0x130/0x130
? handle_exception+0x133/0x133
? pvclock_clocksource_read_nowd+0x130/0x130
? ttm_device_init+0xb4/0x274
? pvclock_clocksource_read_nowd+0x130/0x130
? ttm_device_init+0xb4/0x274
qxl_ttm_init+0x34/0x130
qxl_bo_init+0xd/0x10
qxl_device_init+0x52a/0x92c
qxl_pci_probe+0x91/0x1ac
local_pci_probe+0x3d/0x84
work_for_cpu_fn+0x16/0x20
process_one_work+0x1bc/0x4a0
worker_thread+0x310/0x3a8
kthread+0xea/0x110
? rescuer_thread+0x2f0/0x2f0
? kthread_complete_and_exit+0x1c/0x1c
ret_from_fork+0x34/0x4c
? kthread_complete_and_exit+0x1c/0x1c
ret_from_fork_asm+0x12/0x18
entry_INT80_32+0xf0/0xf0
Modules linked in:
CR2: 0000000000000238
---[ end trace 0000000000000000 ]---
The crash happened here:
int ttm_device_init(struct ttm_device *bdev, const struct ttm_device_funcs *funcs,
struct device *dev, struct address_space *mapping,
struct drm_vma_offset_manager *vma_manager,
bool use_dma_alloc, bool use_dma32)
{
struct ttm_global *glob = &ttm_glob;
int ret;
if (WARN_ON(vma_manager == NULL))
return -EINVAL;
ret = ttm_global_init();
if (ret)
return ret;
bdev->wq = alloc_workqueue("ttm",
WQ_MEM_RECLAIM | WQ_HIGHPRI | WQ_UNBOUND, 16);
if (!bdev->wq) {
ttm_global_release();
return -ENOMEM;
}
bdev->funcs = funcs;
ttm_sys_man_init(bdev);
ttm_pool_init(&bdev->pool, dev, dev_to_node(dev), use_dma_alloc, use_dma32); <<<------- BUG!
Specifically, it appears that dev is NULL and dev_to_node() doesn't like
having a NULL pointer passed to it.
I currently "fixed" this with a:
if (!dev)
return -EINVAL;
at the start of this function just so that I can continue running my tests,
but that is obviously incorrect.
-- Steve
WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: "Felix Kuehling" <Felix.Kuehling@amd.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Rajneesh Bhardwaj" <rajneesh.bhardwaj@amd.com>,
dri-devel@lists.freedesktop.org,
"Christian König" <christian.koenig@amd.com>
Subject: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4
Date: Mon, 22 Jan 2024 18:06:05 -0500 [thread overview]
Message-ID: <20240122180605.28daf23a@gandalf.local.home> (raw)
I just kicked off testing some patches on top of 6.8-rc1 and triggered this
immediately:
[ note this happened on both my 32 bit an 64 bit test machines, this is
just the 32 bit output ]
BUG: kernel NULL pointer dereference, address: 00000238
#PF: supervisor read access in kernel mode
#PF: error_code(0x0000) - not-present page
*pdpt = 0000000000000000 *pde = f000ff53f000ff53
Oops: 0000 [#1] PREEMPT SMP PTI
CPU: 0 PID: 9 Comm: kworker/0:1 Not tainted 6.8.0-rc1-test-00001-g2b44760609e9-dirty #1056
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014
Workqueue: events work_for_cpu_fn
EIP: ttm_device_init+0xb4/0x274
Code: 86 10 09 00 00 83 c4 0c 85 c0 0f 84 96 01 00 00 8b 45 ac 8d 9e 94 00 00 00 89 46 08 89 f0 e8 27 05 00 00 8b 55 a8 0f b6 45 98 <8b> 8a 38 02 00 00 50 0f b6 45 9c 50 89 d8 e8 95 ee ff ff 8b 45 a0
EAX: 00000000 EBX: c135a7e4 ECX: c135a7b0 EDX: 00000000
ESI: c135a750 EDI: 0007bc1d EBP: c11d7e4c ESP: c11d7de4
DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068 EFLAGS: 00010246
CR0: 80050033 CR2: 00000238 CR3: 145c4000 CR4: 000006f0
Call Trace:
? show_regs+0x4f/0x58
? __die+0x1d/0x58
? page_fault_oops+0x171/0x330
? lock_acquire+0xa4/0x280
? kernelmode_fixup_or_oops.constprop.0+0x7c/0xcc
? __bad_area_nosemaphore.constprop.0+0x124/0x1b4
? __mutex_lock+0x17f/0xb00
? bad_area_nosemaphore+0xf/0x14
? do_user_addr_fault+0x140/0x3e4
? exc_page_fault+0x5b/0x1d8
? pvclock_clocksource_read_nowd+0x130/0x130
? handle_exception+0x133/0x133
? pvclock_clocksource_read_nowd+0x130/0x130
? ttm_device_init+0xb4/0x274
? pvclock_clocksource_read_nowd+0x130/0x130
? ttm_device_init+0xb4/0x274
qxl_ttm_init+0x34/0x130
qxl_bo_init+0xd/0x10
qxl_device_init+0x52a/0x92c
qxl_pci_probe+0x91/0x1ac
local_pci_probe+0x3d/0x84
work_for_cpu_fn+0x16/0x20
process_one_work+0x1bc/0x4a0
worker_thread+0x310/0x3a8
kthread+0xea/0x110
? rescuer_thread+0x2f0/0x2f0
? kthread_complete_and_exit+0x1c/0x1c
ret_from_fork+0x34/0x4c
? kthread_complete_and_exit+0x1c/0x1c
ret_from_fork_asm+0x12/0x18
entry_INT80_32+0xf0/0xf0
Modules linked in:
CR2: 0000000000000238
---[ end trace 0000000000000000 ]---
The crash happened here:
int ttm_device_init(struct ttm_device *bdev, const struct ttm_device_funcs *funcs,
struct device *dev, struct address_space *mapping,
struct drm_vma_offset_manager *vma_manager,
bool use_dma_alloc, bool use_dma32)
{
struct ttm_global *glob = &ttm_glob;
int ret;
if (WARN_ON(vma_manager == NULL))
return -EINVAL;
ret = ttm_global_init();
if (ret)
return ret;
bdev->wq = alloc_workqueue("ttm",
WQ_MEM_RECLAIM | WQ_HIGHPRI | WQ_UNBOUND, 16);
if (!bdev->wq) {
ttm_global_release();
return -ENOMEM;
}
bdev->funcs = funcs;
ttm_sys_man_init(bdev);
ttm_pool_init(&bdev->pool, dev, dev_to_node(dev), use_dma_alloc, use_dma32); <<<------- BUG!
Specifically, it appears that dev is NULL and dev_to_node() doesn't like
having a NULL pointer passed to it.
I currently "fixed" this with a:
if (!dev)
return -EINVAL;
at the start of this function just so that I can continue running my tests,
but that is obviously incorrect.
-- Steve
next reply other threads:[~2024-01-22 23:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 23:06 Steven Rostedt [this message]
2024-01-22 23:06 ` [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4 Steven Rostedt
2024-01-22 23:15 ` Steven Rostedt
2024-01-22 23:15 ` Steven Rostedt
2024-01-22 23:19 ` Steven Rostedt
2024-01-22 23:19 ` Steven Rostedt
2024-01-23 0:43 ` Linus Torvalds
2024-01-23 0:43 ` Linus Torvalds
2024-01-23 0:56 ` Bhardwaj, Rajneesh
2024-01-23 1:25 ` Linus Torvalds
2024-01-23 1:25 ` Linus Torvalds
2024-01-23 1:35 ` Steven Rostedt
2024-01-23 1:35 ` Steven Rostedt
2024-01-23 2:21 ` Dave Airlie
2024-01-23 2:21 ` Dave Airlie
2024-01-23 2:32 ` Dave Airlie
2024-01-23 2:32 ` Dave Airlie
2024-01-23 2:52 ` Steven Rostedt
2024-01-23 2:52 ` Steven Rostedt
2024-01-23 9:43 ` Christian König
2024-01-23 9:43 ` Christian König
2024-01-23 14:35 ` Steven Rostedt
2024-01-23 14:35 ` Steven Rostedt
2024-01-23 1:06 ` Bhardwaj, Rajneesh
2024-01-23 1:06 ` Bhardwaj, Rajneesh
2024-01-23 0:29 ` Bhardwaj, Rajneesh
2024-01-23 0:34 ` Steven Rostedt
2024-01-23 0:34 ` Steven Rostedt
2024-01-23 0:40 ` Bhardwaj, Rajneesh
2024-01-23 0:40 ` Bhardwaj, Rajneesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122180605.28daf23a@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=Felix.Kuehling@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rajneesh.bhardwaj@amd.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.