From: Claire Jensen <cjense@google.com>
To: eranian@google.com, irogers@google.com, tz.stoyanov@gmail.com,
linux-trace-devel@vger.kernel.org, rostedt@goodmis.org
Cc: Claire Jensen <cjense@google.com>
Subject: [PATCH 2/2] libtraceevent: Changed angled brackets to double quotes.
Date: Thu, 17 Jun 2021 19:43:26 +0000 [thread overview]
Message-ID: <20210617194326.2107129-2-cjense@google.com> (raw)
In-Reply-To: <20210617194326.2107129-1-cjense@google.com>
Certain build systems, such as bazel, are picky about angled brackets vs
double quotes.
the failure you see when building is:
In file included from src/event-parse.c:27:
src/event-utils.h:13:10: error: 'event-parse.h' file not found with
<angled> include; use "quotes" instead
#include <event-parse.h>
^~~~~~~~~~~~~~~
"event-parse.h"
Arguably -iquote is more correct within the library build, hence bazel
using it. The libtraceevent Makefile is using -I, hence this not being
a problem for others.
Signed-off-by: Claire Jensen <cjense@google.com>
---
src/event-utils.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/event-utils.h b/src/event-utils.h
index d377201..44f7968 100644
--- a/src/event-utils.h
+++ b/src/event-utils.h
@@ -10,7 +10,7 @@
#include <stdarg.h>
#include <stdbool.h>
-#include <event-parse.h>
+#include "event-parse.h"
void tep_warning(const char *fmt, ...);
void tep_info(const char *fmt, ...);
--
2.32.0.288.g62a8d224e6-goog
next prev parent reply other threads:[~2021-06-17 19:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 19:43 [PATCH 1/2] libtraceevent: Add eof checks Claire Jensen
2021-06-17 19:43 ` Claire Jensen [this message]
2021-06-17 19:58 ` Steven Rostedt
2021-06-24 1:06 ` Steven Rostedt
2021-06-24 5:50 ` Ian Rogers
2021-06-24 13:14 ` Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2021-06-12 1:44 [PATCH 0/2] Build and fuzzing related fixes Ian Rogers
2021-06-12 1:45 ` [PATCH 2/2] libtraceevent: Changed angled brackets to double quotes Ian Rogers
2021-06-12 23:00 ` Steven Rostedt
2021-06-13 21:31 ` Ian Rogers
2021-06-13 23:29 ` Steven Rostedt
2021-06-14 16:14 ` Ian Rogers
2021-06-14 18:43 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617194326.2107129-2-cjense@google.com \
--to=cjense@google.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.