From: Steven Rostedt <rostedt@goodmis.org>
To: Ian Rogers <irogers@google.com>
Cc: linux-trace-devel@vger.kernel.org,
Tzvetomir Stoyanov <tz.stoyanov@gmail.com>,
Claire Jensen <cjense@google.com>
Subject: Re: [PATCH 2/2] libtraceevent: Changed angled brackets to double quotes.
Date: Sat, 12 Jun 2021 19:00:49 -0400 [thread overview]
Message-ID: <20210612190049.7e09d8c6@rorschach.local.home> (raw)
In-Reply-To: <20210612014501.890593-3-irogers@google.com>
On Fri, 11 Jun 2021 18:45:01 -0700
Ian Rogers <irogers@google.com> wrote:
> From: Claire Jensen <cjense@google.com>
>
> Signed-off-by: Claire Jensen <cjense@google.com>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> src/event-utils.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/event-utils.h b/src/event-utils.h
> index d377201..44f7968 100644
> --- a/src/event-utils.h
> +++ b/src/event-utils.h
> @@ -10,7 +10,7 @@
> #include <stdarg.h>
> #include <stdbool.h>
>
> -#include <event-parse.h>
> +#include "event-parse.h"
Thanks for the update, but event-parse.h is part of the exported
library and even though it happens to be local to this file, we use the
'<' and '>' to denote that it is a library header and not a local one.
-- Steve
>
> void tep_warning(const char *fmt, ...);
> void tep_info(const char *fmt, ...);
next prev parent reply other threads:[~2021-06-12 23:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-12 1:44 [PATCH 0/2] Build and fuzzing related fixes Ian Rogers
2021-06-12 1:45 ` [PATCH 1/2] libtraceevent: Add eof checks Ian Rogers
2021-06-13 23:30 ` Steven Rostedt
[not found] ` <CAFPGG2iQK8XMv6Z1-KurgjOnYuk=m=uWNWJXj6OEb_SBQkokZA@mail.gmail.com>
2021-06-17 19:01 ` Steven Rostedt
2021-06-12 1:45 ` [PATCH 2/2] libtraceevent: Changed angled brackets to double quotes Ian Rogers
2021-06-12 23:00 ` Steven Rostedt [this message]
2021-06-13 21:31 ` Ian Rogers
2021-06-13 23:29 ` Steven Rostedt
2021-06-14 16:14 ` Ian Rogers
2021-06-14 18:43 ` Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2021-06-17 19:43 [PATCH 1/2] libtraceevent: Add eof checks Claire Jensen
2021-06-17 19:43 ` [PATCH 2/2] libtraceevent: Changed angled brackets to double quotes Claire Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210612190049.7e09d8c6@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=cjense@google.com \
--cc=irogers@google.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.