From: Steven Rostedt <rostedt@goodmis.org>
To: Claire Jensen <cjense@google.com>
Cc: eranian@google.com, irogers@google.com, tz.stoyanov@gmail.com,
linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] libtraceevent: Add eof checks.
Date: Wed, 23 Jun 2021 21:06:21 -0400 [thread overview]
Message-ID: <20210623210621.3b35e0d4@rorschach.local.home> (raw)
In-Reply-To: <20210617155828.4e9c7f45@gandalf.local.home>
On Thu, 17 Jun 2021 15:58:28 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Thu, 17 Jun 2021 19:43:25 +0000
> Claire Jensen <cjense@google.com> wrote:
>
> Hi Claire,
>
> Thanks for sending the patches, I'll try to get some time to look at them
> (note, that I have a lot of other duties that I need to finish before I can
> get to this).
>
> > Added checking for __read_char and peek_char to make sure value is not at end
> > of file.
> >
> > This issue was found while fuzz testing. One of the test cases created an infinite loop because __read_token had reached end of file. Checking was added to all cases where this may occur.
>
> You don't need to fix this now, but for future reference, we follow the
> Linux guidelines on submitting patches which includes having line breaks at
> 74 (although I use 76) bytes, for the change log.
>
> This makes the change logs easier to read.
>
I made the mistake of adding this patch and pushing it to a new release
without running my test suite against it. It ended up breaking the parsing.
When running with --debug -N, I get:
[ftrace:branch] unexpected type 1
[sched:sched_switch] unknown op ''
[irq:irq_handler_exit] unexpected type 1
[timer:timer_start] unknown op ''
[kvm:vcpu_match_mmio] unexpected type 1
[kvm:kvm_wait_lapic_expire] unknown op ''
[kvm:kvm_vcpu_wakeup] unexpected type 1
[kvm:kvm_userspace_exit] unknown op ''
[kvm:kvm_pv_tlb_flush] unexpected type 1
[kvm:kvm_ple_window_update] unknown op ''
[kvm:kvm_pio] unknown op ''
[kvm:kvm_pic_set_irq] unknown op ''
[kvm:kvm_nested_vmrun] unexpected type 1
[kvm:kvm_nested_vmexit_inject] unknown op ''
Error: expected type 5 but read 0
[kvm:kvm_nested_vmexit] unknown op ''
Error: expected type 5 but read 0
[kvm:kvm_nested_vmenter_failed] bad op token
[kvm:kvm_msr] unexpected type 1
[kvm:kvm_msi_set_irq] unknown op ''
unknown op ''
[kvm:kvm_ioapic_set_irq] unknown op ''
Error: expected type 5 but read 0
unknown op ''
[kvm:kvm_ioapic_delayed_eoi_inj] unknown op ''
Error: expected type 5 but read 0
[kvm:kvm_exit] unknown op ''
Error: expected type 5 but read 0
[kvm:kvm_emulate_insn] unknown op ''
Error: expected type 5 but read 0
[kvm:kvm_cpuid] unexpected type 1
unknown op ''
[kvm:kvm_apic_ipi] unknown op ''
Error: expected type 5 but read 0
unknown op ''
[kvm:kvm_apic_accept_irq] unknown op ''
Error: expected type 5 but read 0
[kvm:kvm_age_page] unexpected type 1
with the patch, and no errors without it.
I have to revert this patch and push a new version out.
-- Steve
next prev parent reply other threads:[~2021-06-24 1:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 19:43 [PATCH 1/2] libtraceevent: Add eof checks Claire Jensen
2021-06-17 19:43 ` [PATCH 2/2] libtraceevent: Changed angled brackets to double quotes Claire Jensen
2021-06-17 19:58 ` [PATCH 1/2] libtraceevent: Add eof checks Steven Rostedt
2021-06-24 1:06 ` Steven Rostedt [this message]
2021-06-24 5:50 ` Ian Rogers
2021-06-24 13:14 ` Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2021-06-12 1:44 [PATCH 0/2] Build and fuzzing related fixes Ian Rogers
2021-06-12 1:45 ` [PATCH 1/2] libtraceevent: Add eof checks Ian Rogers
2021-06-13 23:30 ` Steven Rostedt
[not found] ` <CAFPGG2iQK8XMv6Z1-KurgjOnYuk=m=uWNWJXj6OEb_SBQkokZA@mail.gmail.com>
2021-06-17 19:01 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210623210621.3b35e0d4@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=cjense@google.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.