From: kernel test robot <lkp@intel.com>
To: Jason Ekstrand <jason@jlekstrand.net>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: "Daniel Vetter" <daniel.vetter@ffwll.ch>,
kbuild-all@lists.01.org,
"Christian König" <christian.koenig@amd.com>,
"Matthew Auld" <matthew.auld@intel.com>
Subject: Re: [Intel-gfx] [PATCH 4/5] dma-buf: Stop using SLAB_TYPESAFE_BY_RCU in selftests
Date: Wed, 16 Jun 2021 20:47:17 +0800 [thread overview]
Message-ID: <202106162053.tvp2I6JR-lkp@intel.com> (raw)
In-Reply-To: <20210609212959.471209-5-jason@jlekstrand.net>
[-- Attachment #1: Type: text/plain, Size: 4067 bytes --]
Hi Jason,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.13-rc6 next-20210615]
[cannot apply to drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jason-Ekstrand/dma-fence-i915-Stop-allowing-SLAB_TYPESAFE_BY_RCU-for-dma_fence/20210616-154432
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: sparc-randconfig-s032-20210615 (attached as .config)
compiler: sparc-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/c889567ea79d1ce55ff8868bae789bbb3223503d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jason-Ekstrand/dma-fence-i915-Stop-allowing-SLAB_TYPESAFE_BY_RCU-for-dma_fence/20210616-154432
git checkout c889567ea79d1ce55ff8868bae789bbb3223503d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=sparc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/dma-buf/st-dma-fence.c:457:57: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct dma_fence *fence @@ got struct dma_fence [noderef] __rcu * @@
drivers/dma-buf/st-dma-fence.c:457:57: sparse: expected struct dma_fence *fence
drivers/dma-buf/st-dma-fence.c:457:57: sparse: got struct dma_fence [noderef] __rcu *
vim +457 drivers/dma-buf/st-dma-fence.c
434
435 static int thread_signal_callback(void *arg)
436 {
437 const struct race_thread *t = arg;
438 unsigned long pass = 0;
439 unsigned long miss = 0;
440 int err = 0;
441
442 while (!err && !kthread_should_stop()) {
443 struct dma_fence *f1, *f2;
444 struct simple_cb cb;
445
446 f1 = mock_fence();
447 if (!f1) {
448 err = -ENOMEM;
449 break;
450 }
451
452 rcu_assign_pointer(t->fences[t->id], f1);
453 smp_wmb();
454
455 rcu_read_lock();
456 do {
> 457 f2 = dma_fence_get_rcu(t->fences[!t->id]);
458 } while (!f2 && !kthread_should_stop());
459 rcu_read_unlock();
460
461 if (t->before)
462 dma_fence_signal(f1);
463
464 smp_store_mb(cb.seen, false);
465 if (!f2 ||
466 dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
467 miss++;
468 cb.seen = true;
469 }
470
471 if (!t->before)
472 dma_fence_signal(f1);
473
474 if (!cb.seen) {
475 dma_fence_wait(f2, false);
476 __wait_for_callbacks(f2);
477 }
478
479 if (!READ_ONCE(cb.seen)) {
480 pr_err("Callback not seen on thread %d, pass %lu (%lu misses), signaling %s add_callback; fence signaled? %s\n",
481 t->id, pass, miss,
482 t->before ? "before" : "after",
483 dma_fence_is_signaled(f2) ? "yes" : "no");
484 err = -EINVAL;
485 }
486
487 dma_fence_put(f2);
488
489 rcu_assign_pointer(t->fences[t->id], NULL);
490 smp_wmb();
491
492 dma_fence_put(f1);
493
494 pass++;
495 }
496
497 pr_info("%s[%d] completed %lu passes, %lu misses\n",
498 __func__, t->id, pass, miss);
499 return err;
500 }
501
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 23450 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Jason Ekstrand <jason@jlekstrand.net>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: "Daniel Vetter" <daniel.vetter@ffwll.ch>,
kbuild-all@lists.01.org,
"Christian König" <christian.koenig@amd.com>,
"Matthew Auld" <matthew.auld@intel.com>
Subject: Re: [Intel-gfx] [PATCH 4/5] dma-buf: Stop using SLAB_TYPESAFE_BY_RCU in selftests
Date: Wed, 16 Jun 2021 20:47:17 +0800 [thread overview]
Message-ID: <202106162053.tvp2I6JR-lkp@intel.com> (raw)
In-Reply-To: <20210609212959.471209-5-jason@jlekstrand.net>
[-- Attachment #1: Type: text/plain, Size: 4067 bytes --]
Hi Jason,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.13-rc6 next-20210615]
[cannot apply to drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jason-Ekstrand/dma-fence-i915-Stop-allowing-SLAB_TYPESAFE_BY_RCU-for-dma_fence/20210616-154432
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: sparc-randconfig-s032-20210615 (attached as .config)
compiler: sparc-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/c889567ea79d1ce55ff8868bae789bbb3223503d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jason-Ekstrand/dma-fence-i915-Stop-allowing-SLAB_TYPESAFE_BY_RCU-for-dma_fence/20210616-154432
git checkout c889567ea79d1ce55ff8868bae789bbb3223503d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=sparc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/dma-buf/st-dma-fence.c:457:57: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct dma_fence *fence @@ got struct dma_fence [noderef] __rcu * @@
drivers/dma-buf/st-dma-fence.c:457:57: sparse: expected struct dma_fence *fence
drivers/dma-buf/st-dma-fence.c:457:57: sparse: got struct dma_fence [noderef] __rcu *
vim +457 drivers/dma-buf/st-dma-fence.c
434
435 static int thread_signal_callback(void *arg)
436 {
437 const struct race_thread *t = arg;
438 unsigned long pass = 0;
439 unsigned long miss = 0;
440 int err = 0;
441
442 while (!err && !kthread_should_stop()) {
443 struct dma_fence *f1, *f2;
444 struct simple_cb cb;
445
446 f1 = mock_fence();
447 if (!f1) {
448 err = -ENOMEM;
449 break;
450 }
451
452 rcu_assign_pointer(t->fences[t->id], f1);
453 smp_wmb();
454
455 rcu_read_lock();
456 do {
> 457 f2 = dma_fence_get_rcu(t->fences[!t->id]);
458 } while (!f2 && !kthread_should_stop());
459 rcu_read_unlock();
460
461 if (t->before)
462 dma_fence_signal(f1);
463
464 smp_store_mb(cb.seen, false);
465 if (!f2 ||
466 dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
467 miss++;
468 cb.seen = true;
469 }
470
471 if (!t->before)
472 dma_fence_signal(f1);
473
474 if (!cb.seen) {
475 dma_fence_wait(f2, false);
476 __wait_for_callbacks(f2);
477 }
478
479 if (!READ_ONCE(cb.seen)) {
480 pr_err("Callback not seen on thread %d, pass %lu (%lu misses), signaling %s add_callback; fence signaled? %s\n",
481 t->id, pass, miss,
482 t->before ? "before" : "after",
483 dma_fence_is_signaled(f2) ? "yes" : "no");
484 err = -EINVAL;
485 }
486
487 dma_fence_put(f2);
488
489 rcu_assign_pointer(t->fences[t->id], NULL);
490 smp_wmb();
491
492 dma_fence_put(f1);
493
494 pass++;
495 }
496
497 pr_info("%s[%d] completed %lu passes, %lu misses\n",
498 __func__, t->id, pass, miss);
499 return err;
500 }
501
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 23450 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [PATCH 4/5] dma-buf: Stop using SLAB_TYPESAFE_BY_RCU in selftests
Date: Wed, 16 Jun 2021 20:47:17 +0800 [thread overview]
Message-ID: <202106162053.tvp2I6JR-lkp@intel.com> (raw)
In-Reply-To: <20210609212959.471209-5-jason@jlekstrand.net>
[-- Attachment #1: Type: text/plain, Size: 4179 bytes --]
Hi Jason,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.13-rc6 next-20210615]
[cannot apply to drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jason-Ekstrand/dma-fence-i915-Stop-allowing-SLAB_TYPESAFE_BY_RCU-for-dma_fence/20210616-154432
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: sparc-randconfig-s032-20210615 (attached as .config)
compiler: sparc-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/c889567ea79d1ce55ff8868bae789bbb3223503d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jason-Ekstrand/dma-fence-i915-Stop-allowing-SLAB_TYPESAFE_BY_RCU-for-dma_fence/20210616-154432
git checkout c889567ea79d1ce55ff8868bae789bbb3223503d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=sparc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/dma-buf/st-dma-fence.c:457:57: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct dma_fence *fence @@ got struct dma_fence [noderef] __rcu * @@
drivers/dma-buf/st-dma-fence.c:457:57: sparse: expected struct dma_fence *fence
drivers/dma-buf/st-dma-fence.c:457:57: sparse: got struct dma_fence [noderef] __rcu *
vim +457 drivers/dma-buf/st-dma-fence.c
434
435 static int thread_signal_callback(void *arg)
436 {
437 const struct race_thread *t = arg;
438 unsigned long pass = 0;
439 unsigned long miss = 0;
440 int err = 0;
441
442 while (!err && !kthread_should_stop()) {
443 struct dma_fence *f1, *f2;
444 struct simple_cb cb;
445
446 f1 = mock_fence();
447 if (!f1) {
448 err = -ENOMEM;
449 break;
450 }
451
452 rcu_assign_pointer(t->fences[t->id], f1);
453 smp_wmb();
454
455 rcu_read_lock();
456 do {
> 457 f2 = dma_fence_get_rcu(t->fences[!t->id]);
458 } while (!f2 && !kthread_should_stop());
459 rcu_read_unlock();
460
461 if (t->before)
462 dma_fence_signal(f1);
463
464 smp_store_mb(cb.seen, false);
465 if (!f2 ||
466 dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
467 miss++;
468 cb.seen = true;
469 }
470
471 if (!t->before)
472 dma_fence_signal(f1);
473
474 if (!cb.seen) {
475 dma_fence_wait(f2, false);
476 __wait_for_callbacks(f2);
477 }
478
479 if (!READ_ONCE(cb.seen)) {
480 pr_err("Callback not seen on thread %d, pass %lu (%lu misses), signaling %s add_callback; fence signaled? %s\n",
481 t->id, pass, miss,
482 t->before ? "before" : "after",
483 dma_fence_is_signaled(f2) ? "yes" : "no");
484 err = -EINVAL;
485 }
486
487 dma_fence_put(f2);
488
489 rcu_assign_pointer(t->fences[t->id], NULL);
490 smp_wmb();
491
492 dma_fence_put(f1);
493
494 pass++;
495 }
496
497 pr_info("%s[%d] completed %lu passes, %lu misses\n",
498 __func__, t->id, pass, miss);
499 return err;
500 }
501
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 23450 bytes --]
next prev parent reply other threads:[~2021-06-16 12:47 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 21:29 [Intel-gfx] [PATCH 0/5] dma-fence, i915: Stop allowing SLAB_TYPESAFE_BY_RCU for dma_fence Jason Ekstrand
2021-06-09 21:29 ` Jason Ekstrand
2021-06-09 21:29 ` [Intel-gfx] [PATCH 1/5] drm/i915: Move intel_engine_free_request_pool to i915_request.c Jason Ekstrand
2021-06-09 21:29 ` Jason Ekstrand
2021-06-10 10:03 ` [Intel-gfx] " Tvrtko Ursulin
2021-06-10 10:03 ` Tvrtko Ursulin
2021-06-10 13:57 ` Jason Ekstrand
2021-06-10 13:57 ` Jason Ekstrand
2021-06-10 15:07 ` Tvrtko Ursulin
2021-06-10 15:07 ` Tvrtko Ursulin
2021-06-10 16:32 ` Jason Ekstrand
2021-06-10 16:32 ` Jason Ekstrand
2021-06-09 21:29 ` [Intel-gfx] [PATCH 2/5] drm/i915: Use a simpler scheme for caching i915_request Jason Ekstrand
2021-06-09 21:29 ` Jason Ekstrand
2021-06-10 10:08 ` [Intel-gfx] " Tvrtko Ursulin
2021-06-10 10:08 ` Tvrtko Ursulin
2021-06-10 13:50 ` Jason Ekstrand
2021-06-10 13:50 ` Jason Ekstrand
2021-06-09 21:29 ` [Intel-gfx] [PATCH 3/5] drm/i915: Stop using SLAB_TYPESAFE_BY_RCU for i915_request Jason Ekstrand
2021-06-09 21:29 ` Jason Ekstrand
2021-06-09 21:29 ` [Intel-gfx] [PATCH 4/5] dma-buf: Stop using SLAB_TYPESAFE_BY_RCU in selftests Jason Ekstrand
2021-06-09 21:29 ` Jason Ekstrand
2021-06-16 12:47 ` kernel test robot [this message]
2021-06-16 12:47 ` [Intel-gfx] " kernel test robot
2021-06-16 12:47 ` kernel test robot
2021-06-09 21:29 ` [Intel-gfx] [PATCH 5/5] DONOTMERGE: dma-buf: Get rid of dma_fence_get_rcu_safe Jason Ekstrand
2021-06-09 21:29 ` Jason Ekstrand
2021-06-10 6:51 ` [Intel-gfx] " Christian König
2021-06-10 6:51 ` Christian König
2021-06-10 13:59 ` [Intel-gfx] " Jason Ekstrand
2021-06-10 13:59 ` Jason Ekstrand
2021-06-10 15:13 ` [Intel-gfx] " Daniel Vetter
2021-06-10 15:13 ` Daniel Vetter
2021-06-10 16:24 ` [Intel-gfx] " Jason Ekstrand
2021-06-10 16:24 ` Jason Ekstrand
2021-06-10 16:37 ` [Intel-gfx] " Daniel Vetter
2021-06-10 16:37 ` Daniel Vetter
2021-06-10 16:52 ` [Intel-gfx] " Jason Ekstrand
2021-06-10 16:52 ` Jason Ekstrand
2021-06-10 17:06 ` [Intel-gfx] " Daniel Vetter
2021-06-10 17:06 ` Daniel Vetter
2021-06-10 16:54 ` [Intel-gfx] " Christian König
2021-06-10 16:54 ` Christian König
2021-06-10 17:11 ` [Intel-gfx] " Daniel Vetter
2021-06-10 17:11 ` Daniel Vetter
2021-06-10 18:12 ` Christian König
2021-06-10 18:12 ` [Intel-gfx] " Christian König
2021-06-16 16:38 ` kernel test robot
2021-06-16 16:38 ` kernel test robot
2021-06-16 16:38 ` kernel test robot
2021-06-09 21:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for dma-fence, i915: Stop allowing SLAB_TYPESAFE_BY_RCU for dma_fence Patchwork
2021-06-09 21:54 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-06-09 22:22 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-06-09 22:22 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2021-06-10 9:29 ` [Intel-gfx] [PATCH 0/5] " Tvrtko Ursulin
2021-06-10 9:29 ` Tvrtko Ursulin
2021-06-10 9:39 ` Christian König
2021-06-10 9:39 ` Christian König
2021-06-10 11:29 ` Daniel Vetter
2021-06-10 11:29 ` Daniel Vetter
2021-06-10 11:53 ` Daniel Vetter
2021-06-10 11:53 ` Daniel Vetter
2021-06-10 13:07 ` Tvrtko Ursulin
2021-06-10 13:07 ` Tvrtko Ursulin
2021-06-10 13:35 ` Jason Ekstrand
2021-06-10 13:35 ` Jason Ekstrand
2021-06-10 20:09 ` Jason Ekstrand
2021-06-10 20:09 ` Jason Ekstrand
2021-06-10 20:42 ` Daniel Vetter
2021-06-10 20:42 ` Daniel Vetter
2021-06-11 6:55 ` Christian König
2021-06-11 6:55 ` Christian König
2021-06-11 7:20 ` Daniel Vetter
2021-06-11 7:20 ` Daniel Vetter
2021-06-11 7:42 ` Christian König
2021-06-11 7:42 ` Christian König
2021-06-11 9:33 ` Daniel Vetter
2021-06-11 9:33 ` Daniel Vetter
2021-06-11 10:03 ` Christian König
2021-06-11 10:03 ` Christian König
2021-06-11 15:08 ` Daniel Vetter
2021-06-11 15:08 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202106162053.tvp2I6JR-lkp@intel.com \
--to=lkp@intel.com \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jason@jlekstrand.net \
--cc=kbuild-all@lists.01.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.