From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> To: Cristian Ciocaltea <cristian.ciocaltea@gmail.com> Cc: "Stephen Boyd" <sboyd@kernel.org>, "Rob Herring" <robh+dt@kernel.org>, "Andreas Färber" <afaerber@suse.de>, "Michael Turquette" <mturquette@baylibre.com>, "Edgar Bernardi Righi" <edgar.righi@lsitec.org.br>, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 2/6] clk: actions: Fix SD clocks factor table on Owl S500 SoC Date: Thu, 10 Jun 2021 19:59:53 +0530 [thread overview] Message-ID: <20210610142953.GA315240@thinkpad> (raw) In-Reply-To: <ca94fddbb790d2c4de25213c65e306f497e119e7.1622119892.git.cristian.ciocaltea@gmail.com> On Thu, May 27, 2021 at 04:16:40PM +0300, Cristian Ciocaltea wrote: > Drop the unsupported entries in the factor table used for the SD[0-2] > clocks definitions on the Actions Semi Owl S500 SoC. > > Fixes: ed6b4795ece4 ("clk: actions: Add clock driver for S500 SoC") > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > --- > Changes in v2: > - Re-added entry "{ 24, 1, 25 }" to sd_factor_table, according to the > datasheet (V1.8+), this is a valid divider > > drivers/clk/actions/owl-s500.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/actions/owl-s500.c b/drivers/clk/actions/owl-s500.c > index 75b7186185b0..42abdf964044 100644 > --- a/drivers/clk/actions/owl-s500.c > +++ b/drivers/clk/actions/owl-s500.c > @@ -127,8 +127,7 @@ static struct clk_factor_table sd_factor_table[] = { > { 12, 1, 13 }, { 13, 1, 14 }, { 14, 1, 15 }, { 15, 1, 16 }, > { 16, 1, 17 }, { 17, 1, 18 }, { 18, 1, 19 }, { 19, 1, 20 }, > { 20, 1, 21 }, { 21, 1, 22 }, { 22, 1, 23 }, { 23, 1, 24 }, > - { 24, 1, 25 }, { 25, 1, 26 }, { 26, 1, 27 }, { 27, 1, 28 }, > - { 28, 1, 29 }, { 29, 1, 30 }, { 30, 1, 31 }, { 31, 1, 32 }, > + { 24, 1, 25 }, > > /* bit8: /128 */ > { 256, 1, 1 * 128 }, { 257, 1, 2 * 128 }, { 258, 1, 3 * 128 }, { 259, 1, 4 * 128 }, > @@ -137,8 +136,7 @@ static struct clk_factor_table sd_factor_table[] = { > { 268, 1, 13 * 128 }, { 269, 1, 14 * 128 }, { 270, 1, 15 * 128 }, { 271, 1, 16 * 128 }, > { 272, 1, 17 * 128 }, { 273, 1, 18 * 128 }, { 274, 1, 19 * 128 }, { 275, 1, 20 * 128 }, > { 276, 1, 21 * 128 }, { 277, 1, 22 * 128 }, { 278, 1, 23 * 128 }, { 279, 1, 24 * 128 }, > - { 280, 1, 25 * 128 }, { 281, 1, 26 * 128 }, { 282, 1, 27 * 128 }, { 283, 1, 28 * 128 }, > - { 284, 1, 29 * 128 }, { 285, 1, 30 * 128 }, { 286, 1, 31 * 128 }, { 287, 1, 32 * 128 }, > + { 280, 1, 25 * 128 }, > { 0, 0, 0 }, > }; > > -- > 2.31.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> To: Cristian Ciocaltea <cristian.ciocaltea@gmail.com> Cc: "Stephen Boyd" <sboyd@kernel.org>, "Rob Herring" <robh+dt@kernel.org>, "Andreas Färber" <afaerber@suse.de>, "Michael Turquette" <mturquette@baylibre.com>, "Edgar Bernardi Righi" <edgar.righi@lsitec.org.br>, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 2/6] clk: actions: Fix SD clocks factor table on Owl S500 SoC Date: Thu, 10 Jun 2021 19:59:53 +0530 [thread overview] Message-ID: <20210610142953.GA315240@thinkpad> (raw) In-Reply-To: <ca94fddbb790d2c4de25213c65e306f497e119e7.1622119892.git.cristian.ciocaltea@gmail.com> On Thu, May 27, 2021 at 04:16:40PM +0300, Cristian Ciocaltea wrote: > Drop the unsupported entries in the factor table used for the SD[0-2] > clocks definitions on the Actions Semi Owl S500 SoC. > > Fixes: ed6b4795ece4 ("clk: actions: Add clock driver for S500 SoC") > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > --- > Changes in v2: > - Re-added entry "{ 24, 1, 25 }" to sd_factor_table, according to the > datasheet (V1.8+), this is a valid divider > > drivers/clk/actions/owl-s500.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/actions/owl-s500.c b/drivers/clk/actions/owl-s500.c > index 75b7186185b0..42abdf964044 100644 > --- a/drivers/clk/actions/owl-s500.c > +++ b/drivers/clk/actions/owl-s500.c > @@ -127,8 +127,7 @@ static struct clk_factor_table sd_factor_table[] = { > { 12, 1, 13 }, { 13, 1, 14 }, { 14, 1, 15 }, { 15, 1, 16 }, > { 16, 1, 17 }, { 17, 1, 18 }, { 18, 1, 19 }, { 19, 1, 20 }, > { 20, 1, 21 }, { 21, 1, 22 }, { 22, 1, 23 }, { 23, 1, 24 }, > - { 24, 1, 25 }, { 25, 1, 26 }, { 26, 1, 27 }, { 27, 1, 28 }, > - { 28, 1, 29 }, { 29, 1, 30 }, { 30, 1, 31 }, { 31, 1, 32 }, > + { 24, 1, 25 }, > > /* bit8: /128 */ > { 256, 1, 1 * 128 }, { 257, 1, 2 * 128 }, { 258, 1, 3 * 128 }, { 259, 1, 4 * 128 }, > @@ -137,8 +136,7 @@ static struct clk_factor_table sd_factor_table[] = { > { 268, 1, 13 * 128 }, { 269, 1, 14 * 128 }, { 270, 1, 15 * 128 }, { 271, 1, 16 * 128 }, > { 272, 1, 17 * 128 }, { 273, 1, 18 * 128 }, { 274, 1, 19 * 128 }, { 275, 1, 20 * 128 }, > { 276, 1, 21 * 128 }, { 277, 1, 22 * 128 }, { 278, 1, 23 * 128 }, { 279, 1, 24 * 128 }, > - { 280, 1, 25 * 128 }, { 281, 1, 26 * 128 }, { 282, 1, 27 * 128 }, { 283, 1, 28 * 128 }, > - { 284, 1, 29 * 128 }, { 285, 1, 30 * 128 }, { 286, 1, 31 * 128 }, { 287, 1, 32 * 128 }, > + { 280, 1, 25 * 128 }, > { 0, 0, 0 }, > }; > > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-10 14:31 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-27 13:16 [PATCH v2 0/6] Improve clock support for Actions S500 SoC Cristian Ciocaltea 2021-05-27 13:16 ` Cristian Ciocaltea 2021-05-27 13:16 ` [PATCH v2 1/6] clk: actions: Fix UART clock dividers on Owl " Cristian Ciocaltea 2021-05-27 13:16 ` Cristian Ciocaltea 2021-05-27 13:16 ` [PATCH v2 2/6] clk: actions: Fix SD clocks factor table " Cristian Ciocaltea 2021-05-27 13:16 ` Cristian Ciocaltea 2021-06-10 14:29 ` Manivannan Sadhasivam [this message] 2021-06-10 14:29 ` Manivannan Sadhasivam 2021-05-27 13:16 ` [PATCH v2 3/6] clk: actions: Fix bisp_factor_table based clocks " Cristian Ciocaltea 2021-05-27 13:16 ` Cristian Ciocaltea 2021-06-10 14:32 ` Manivannan Sadhasivam 2021-06-10 14:32 ` Manivannan Sadhasivam 2021-05-27 13:16 ` [PATCH v2 4/6] clk: actions: Fix AHPPREDIV-H-AHB clock chain " Cristian Ciocaltea 2021-05-27 13:16 ` Cristian Ciocaltea 2021-06-10 14:34 ` Manivannan Sadhasivam 2021-06-10 14:34 ` Manivannan Sadhasivam 2021-06-10 20:10 ` Cristian Ciocaltea 2021-06-10 20:10 ` Cristian Ciocaltea 2021-05-27 13:16 ` [PATCH v2 5/6] dt-bindings: clock: Add NIC and ETHERNET bindings for Actions " Cristian Ciocaltea 2021-05-27 13:16 ` Cristian Ciocaltea 2021-06-10 14:34 ` Manivannan Sadhasivam 2021-06-10 14:34 ` Manivannan Sadhasivam 2021-05-27 13:16 ` [PATCH v2 6/6] clk: actions: Add NIC and ETHERNET clock support " Cristian Ciocaltea 2021-05-27 13:16 ` Cristian Ciocaltea 2021-06-10 14:35 ` Manivannan Sadhasivam 2021-06-10 14:35 ` Manivannan Sadhasivam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210610142953.GA315240@thinkpad \ --to=manivannan.sadhasivam@linaro.org \ --cc=afaerber@suse.de \ --cc=cristian.ciocaltea@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=edgar.righi@lsitec.org.br \ --cc=linux-actions@lists.infradead.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.