All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Dave Martin <Dave.Martin@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Szabolcs Nagy <szabolcs.nagy@arm.com>,
	Jeremy Linton <jeremy.linton@arm.com>,
	"H . J . Lu" <hjl.tools@gmail.com>,
	Yu-cheng Yu <yu-cheng.yu@intel.com>,
	linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	libc-alpha@sourceware.org
Subject: Re: [PATCH v1 1/2] elf: Allow architectures to parse properties on the main executable
Date: Thu, 3 Jun 2021 19:52:36 +0100	[thread overview]
Message-ID: <20210603185236.GG4257@sirena.org.uk> (raw)
In-Reply-To: <20210603154018.GG4187@arm.com>

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

On Thu, Jun 03, 2021 at 04:40:24PM +0100, Dave Martin wrote:
> On Fri, May 21, 2021 at 03:46:20PM +0100, Mark Brown wrote:

> > -		if (system_supports_bti() &&
> > +		if (system_supports_bti() && is_interp &&

> Won't this cause BTI to be forced off for static binaries?

> Perhaps this should be (has_interp == is_interp), as for
> arch_elf_adjust_prot().  Seems gross though, since has_interp would
> become useless after the next patch.  If there's no sensible way to
> keep this bisectable, perhaps the patches can be merged instead.

Ugh, right.  I only tested the finished result.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Dave Martin <Dave.Martin@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Szabolcs Nagy <szabolcs.nagy@arm.com>,
	Jeremy Linton <jeremy.linton@arm.com>,
	"H . J . Lu" <hjl.tools@gmail.com>,
	Yu-cheng Yu <yu-cheng.yu@intel.com>,
	linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	libc-alpha@sourceware.org
Subject: Re: [PATCH v1 1/2] elf: Allow architectures to parse properties on the main executable
Date: Thu, 3 Jun 2021 19:52:36 +0100	[thread overview]
Message-ID: <20210603185236.GG4257@sirena.org.uk> (raw)
In-Reply-To: <20210603154018.GG4187@arm.com>


[-- Attachment #1.1: Type: text/plain, Size: 587 bytes --]

On Thu, Jun 03, 2021 at 04:40:24PM +0100, Dave Martin wrote:
> On Fri, May 21, 2021 at 03:46:20PM +0100, Mark Brown wrote:

> > -		if (system_supports_bti() &&
> > +		if (system_supports_bti() && is_interp &&

> Won't this cause BTI to be forced off for static binaries?

> Perhaps this should be (has_interp == is_interp), as for
> arch_elf_adjust_prot().  Seems gross though, since has_interp would
> become useless after the next patch.  If there's no sensible way to
> keep this bisectable, perhaps the patches can be merged instead.

Ugh, right.  I only tested the finished result.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-03 18:52 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21 14:46 [PATCH v1 0/2] arm64: Enable BTI for the executable as well as the interpreter Mark Brown
2021-05-21 14:46 ` Mark Brown
2021-05-21 14:46 ` [PATCH v1 1/2] elf: Allow architectures to parse properties on the main executable Mark Brown
2021-05-21 14:46   ` Mark Brown
2021-06-03 15:40   ` Dave Martin
2021-06-03 15:40     ` Dave Martin
2021-06-03 18:52     ` Mark Brown [this message]
2021-06-03 18:52       ` Mark Brown
2021-05-21 14:46 ` [PATCH v1 2/2] arm64: Enable BTI for main executable as well as the interpreter Mark Brown
2021-05-21 14:46   ` Mark Brown
2021-06-03 15:40   ` Dave Martin
2021-06-03 15:40     ` Dave Martin
2021-06-03 16:51     ` Mark Brown
2021-06-03 16:51       ` Mark Brown
2021-06-03 18:04       ` Catalin Marinas
2021-06-03 18:04         ` Catalin Marinas
2021-06-07 11:25         ` Dave Martin
2021-06-07 11:25           ` Dave Martin
2021-06-07 18:12           ` Catalin Marinas
2021-06-07 18:12             ` Catalin Marinas
2021-06-08 11:33             ` Mark Brown
2021-06-08 11:33               ` Mark Brown
2021-06-08 15:19               ` Dave Martin
2021-06-08 15:19                 ` Dave Martin
2021-06-08 15:42                 ` Jeremy Linton
2021-06-08 15:42                   ` Jeremy Linton
2021-06-10 10:33                   ` Dave Martin
2021-06-10 10:33                     ` Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210603185236.GG4257@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=Dave.Martin@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=hjl.tools@gmail.com \
    --cc=jeremy.linton@arm.com \
    --cc=libc-alpha@sourceware.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=szabolcs.nagy@arm.com \
    --cc=will@kernel.org \
    --cc=yu-cheng.yu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.