about summary refs log tree commit homepage
path: root/lib/dtas/partstats.rb
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2021-05-25 10:22:34 +0000
committerEric Wong <e@80x24.org>2021-05-25 10:24:36 +0000
commite97a5c2b9d26db2e1dda3422d39711a1801e34a3 (patch)
treeaab99a89521d0a462dea4696cc330cdba181da6d /lib/dtas/partstats.rb
parent96c43ff8f26cf89934198d2387cddef1f119a271 (diff)
downloaddtas-e97a5c2b9d26db2e1dda3422d39711a1801e34a3.tar.gz
This allows dtas-player to play files with wonky filenames
when piping ffmpeg (or avconv) to sox.  SoX-only code
dtas-player paths are not affected since they don't require
an extra Bourne shell.

All of our internal shell pipelines quote "$INFILE",
anyways, so there was never any need to escape for those.

This may cause compatibility problems for splitfx users, but
splitfx is probably too esoteric to have any users besides
myself.  And I expect anybody editing audio with dtas-splitfx to
pick shell-friendly filenames.

dtas-player is far more general, and likely to encounter
shell-unfriendly filenames which require quoting.
Diffstat (limited to 'lib/dtas/partstats.rb')
-rw-r--r--lib/dtas/partstats.rb3
1 files changed, 1 insertions, 2 deletions
diff --git a/lib/dtas/partstats.rb b/lib/dtas/partstats.rb
index 75f9236..45eff34 100644
--- a/lib/dtas/partstats.rb
+++ b/lib/dtas/partstats.rb
@@ -3,7 +3,6 @@
 # License: GPL-3.0+ <https://www.gnu.org/licenses/gpl-3.0.txt>
 # frozen_string_literal: true
 require_relative '../dtas'
-require_relative 'xs'
 require_relative 'process'
 require_relative 'sigevent'
 
@@ -56,7 +55,7 @@ class DTAS::PartStats # :nodoc:
     rd, wr = IO.pipe
     env = opts[:env]
     env = env ? env.dup : {}
-    env["INFILE"] = xs(@infile)
+    env["INFILE"] = @infile
     env["TRIMFX"] = "trim #{trim_part.tbeg}s #{trim_part.tlen}s"
     opts = { pgroup: true, close_others: true, err: wr }
     pid = spawn(env, CMD, opts)