From e97a5c2b9d26db2e1dda3422d39711a1801e34a3 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 25 May 2021 10:22:34 +0000 Subject: do not shell-quote filenames for environment This allows dtas-player to play files with wonky filenames when piping ffmpeg (or avconv) to sox. SoX-only code dtas-player paths are not affected since they don't require an extra Bourne shell. All of our internal shell pipelines quote "$INFILE", anyways, so there was never any need to escape for those. This may cause compatibility problems for splitfx users, but splitfx is probably too esoteric to have any users besides myself. And I expect anybody editing audio with dtas-splitfx to pick shell-friendly filenames. dtas-player is far more general, and likely to encounter shell-unfriendly filenames which require quoting. --- lib/dtas/partstats.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'lib/dtas/partstats.rb') diff --git a/lib/dtas/partstats.rb b/lib/dtas/partstats.rb index 75f9236..45eff34 100644 --- a/lib/dtas/partstats.rb +++ b/lib/dtas/partstats.rb @@ -3,7 +3,6 @@ # License: GPL-3.0+ # frozen_string_literal: true require_relative '../dtas' -require_relative 'xs' require_relative 'process' require_relative 'sigevent' @@ -56,7 +55,7 @@ class DTAS::PartStats # :nodoc: rd, wr = IO.pipe env = opts[:env] env = env ? env.dup : {} - env["INFILE"] = xs(@infile) + env["INFILE"] = @infile env["TRIMFX"] = "trim #{trim_part.tbeg}s #{trim_part.tlen}s" opts = { pgroup: true, close_others: true, err: wr } pid = spawn(env, CMD, opts) -- cgit v1.2.3-24-ge0c7