* Unwanted trim after source edit @ 2020-05-23 11:05 Rene Maurer [not found] ` <20200523140525.yprijrqoq6kwilll@gmail.com> 0 siblings, 1 reply; 3+ messages in thread From: Rene Maurer @ 2020-05-23 11:05 UTC (permalink / raw) To: dtas-all Hello I have added an additional parameter (LPASS) to the sox source using "dtas-sourceedit sox". After this my sox source is as follows: --- command: exec sox "$INFILE" $SOXFMT - $TRIMFX $RGFX $LPASS env: LPASS: sinc 0-900 tryorder: 0 When I now add a song to the queue with dtas-enq, the applied filter works and I can see it with ps: pts/1 SL 0:00 play -q -ts32 -c2 -r44100 - pts/1 S 0:00 sox /home/x/ori.flac -ts32 -c2 -r44100 - sinc 0-900 When I change the additional parameter (LPASS) while a song is played the applied filter changes but in the output of ps I see that also some kind of trim is active: pts/1 SL 0:01 play -q -ts32 -c2 -r44100 - pts/1 S 0:00 sox /home/x/ori.flac -ts32 -c2 -r44100 - trim 1228800s sinc 0-999 This happens when I use "dtas-sourceedit sox" and also when I use "dtas-ctl source ed sox env.LPASS="sinc 0-999”” to change the parameter. Do I use the source in a completely wrong way (should I use sink instead?) or what is the reason for this trim? Thanks René ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20200523140525.yprijrqoq6kwilll@gmail.com>]
* Re: Unwanted trim after source edit [not found] ` <20200523140525.yprijrqoq6kwilll@gmail.com> @ 2020-05-23 14:09 ` James Rowe 2020-05-23 15:19 ` Rene Maurer 0 siblings, 1 reply; 3+ messages in thread From: James Rowe @ 2020-05-23 14:09 UTC (permalink / raw) To: dtas-all [-- Attachment #1: Type: text/plain, Size: 1075 bytes --] [Resent to the list, because I’m a fool. Rene, sorry if you get a dupe.] * Rene Maurer (rm@cumparsita.ch) wrote: > Do I use the source in a completely wrong way (should I use sink instead?) or > what is the reason for this trim? The trim exists because sox is restarted when you edit the source in order to apply your changes, you can see this by checking the PID of the running sox command after editing. In order to take in to account your current position in the track when you edited the source the trim effect is added to continue playback from the right place. You can see it in action if you: dtas-ctl play_pause; dtas-ctl play_pause; dtas-ctl current In the large YAML dump it emits you’ll see the TRIMFX setting, and also current_initial value. > Do I use the source in a completely wrong way (should I use sink instead?) or > what is the reason for this trim? So — assuming I’ve read your mail correctly — you’ve done nothing wrong at all and are just noticing an implementation detail. Thanks, James [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Unwanted trim after source edit 2020-05-23 14:09 ` James Rowe @ 2020-05-23 15:19 ` Rene Maurer 0 siblings, 0 replies; 3+ messages in thread From: Rene Maurer @ 2020-05-23 15:19 UTC (permalink / raw) To: dtas-all James Rowe <jnrowe@gmail.com> wrote: > So — assuming I’ve read your mail correctly — you’ve done nothing > wrong at all and are just noticing an implementation detail. Perfect. Thank you for your exciting answer! René ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-23 15:20 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-05-23 11:05 Unwanted trim after source edit Rene Maurer [not found] ` <20200523140525.yprijrqoq6kwilll@gmail.com> 2020-05-23 14:09 ` James Rowe 2020-05-23 15:19 ` Rene Maurer
Code repositories for project(s) associated with this public inbox https://80x24.org/dtas.git/ This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).