Unwanted trim after source edit

Unwanted trim after source edit

[Rene Maurer]

Hello

I have added an additional parameter (LPASS) to the sox source using
"dtas-sourceedit sox". After this my sox source is as follows:

---
command: exec sox "$INFILE" $SOXFMT - $TRIMFX $RGFX $LPASS
env:
   LPASS: sinc 0-900
tryorder: 0

When I now add a song to the queue with dtas-enq, the applied filter works and
I can see it with ps:

pts/1  SL  0:00 play -q -ts32 -c2 -r44100 -
pts/1  S   0:00 sox /home/x/ori.flac -ts32 -c2 -r44100 - sinc 0-900

When I change the additional parameter (LPASS) while a song is played the
applied filter changes but in the output of ps I see that also some kind of
trim is active:

pts/1  SL  0:01 play -q -ts32 -c2 -r44100 -
pts/1  S   0:00 sox /home/x/ori.flac -ts32 -c2 -r44100 - trim 1228800s sinc 0-999

This happens when I use "dtas-sourceedit sox" and also when I use "dtas-ctl
source ed sox env.LPASS="sinc 0-999”” to change the parameter.

Do I use the source in a completely wrong way (should I use sink instead?) or
what is the reason for this trim?

Thanks René

Re: Unwanted trim after source edit

[James Rowe]

[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]

[Resent to the list, because I’m a fool.  Rene, sorry if you get
a dupe.]

* Rene Maurer (rm@cumparsita.ch) wrote:
> Do I use the source in a completely wrong way (should I use sink instead?) or
> what is the reason for this trim?

  The trim exists because sox is restarted when you edit the source in
order to apply your changes, you can see this by checking the PID of the
running sox command after editing.  In order to take in to account your
current position in the track when you edited the source the trim effect
is added to continue playback from the right place.

  You can see it in action if you:

    dtas-ctl play_pause; dtas-ctl play_pause; dtas-ctl current

  In the large YAML dump it emits you’ll see the TRIMFX setting, and
also current_initial value.

> Do I use the source in a completely wrong way (should I use sink instead?) or
> what is the reason for this trim?

  So — assuming I’ve read your mail correctly — you’ve done nothing
wrong at all and are just noticing an implementation detail.

Thanks,

James

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Unwanted trim after source edit

[Rene Maurer]

James Rowe <jnrowe@gmail.com> wrote:

>   So — assuming I’ve read your mail correctly — you’ve done nothing
> wrong at all and are just noticing an implementation detail.

Perfect. Thank you for your exciting answer!

René