From: Eric Wong <e@80x24.org>
To: <dtas-all@nongnu.org>
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH] splitfx: fix typo for dither application
Date: Sun, 10 May 2015 08:52:04 +0000 [thread overview]
Message-ID: <1431247924-23906-1-git-send-email-e@80x24.org> (raw)
We do not need to dither unless we output to 16-bit or less.
This bug caused us to unnecessarily apply dither on 24-bit
output files. Oops!
---
lib/dtas/splitfx.rb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dtas/splitfx.rb b/lib/dtas/splitfx.rb
index 6271fb0..208ff67 100644
--- a/lib/dtas/splitfx.rb
+++ b/lib/dtas/splitfx.rb
@@ -184,7 +184,7 @@ class DTAS::SplitFX # :nodoc:
# add noise-shaped dither for 16-bit (sox manual seems to recommend this)
if opts[:no_dither]
env["SOX_OPTS"] = "#{ENV["SOX_OPTS"]} -D"
- else outfmt.bits && outfmt.bits <= 16
+ elsif outfmt.bits && outfmt.bits <= 16
env["DITHERFX"] = "dither -s"
end
comments = Tempfile.new(%W(dtas-splitfx-#{t.comments["TRACKNUMBER"]} .txt))
--
EW
reply other threads:[~2015-05-10 8:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://80x24.org/dtas/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431247924-23906-1-git-send-email-e@80x24.org \
--to=e@80x24.org \
--cc=dtas-all@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/dtas.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).