everything related to duct tape audio suite (dtas)
 help / color / mirror / code / Atom feed
* [PATCH] splitfx: fix typo for dither application
@ 2015-05-10  8:52 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2015-05-10  8:52 UTC (permalink / raw)
  To: dtas-all; +Cc: Eric Wong

We do not need to dither unless we output to 16-bit or less.
This bug caused us to unnecessarily apply dither on 24-bit
output files.  Oops!
---
 lib/dtas/splitfx.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/dtas/splitfx.rb b/lib/dtas/splitfx.rb
index 6271fb0..208ff67 100644
--- a/lib/dtas/splitfx.rb
+++ b/lib/dtas/splitfx.rb
@@ -184,7 +184,7 @@ class DTAS::SplitFX # :nodoc:
     # add noise-shaped dither for 16-bit (sox manual seems to recommend this)
     if opts[:no_dither]
       env["SOX_OPTS"] = "#{ENV["SOX_OPTS"]} -D"
-    else outfmt.bits && outfmt.bits <= 16
+    elsif outfmt.bits && outfmt.bits <= 16
       env["DITHERFX"] = "dither -s"
     end
     comments = Tempfile.new(%W(dtas-splitfx-#{t.comments["TRACKNUMBER"]} .txt))
-- 
EW



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-05-10  8:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-10  8:52 [PATCH] splitfx: fix typo for dither application Eric Wong

Code repositories for project(s) associated with this inbox:

	../../../dtas.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).