From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 208.118.235.0/24 X-Spam-Status: No, score=-2.3 required=3.0 tests=AWL,BAYES_00 shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: dtas-all@80x24.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 863891FAC6 for ; Sun, 10 May 2015 08:52:15 +0000 (UTC) Received: from localhost ([::1]:33026 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrMy6-0000KF-UN for dtas-all@80x24.org; Sun, 10 May 2015 04:52:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrMy3-0000K1-UN for dtas-all@nongnu.org; Sun, 10 May 2015 04:52:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrMxz-0003M3-Gu for dtas-all@nongnu.org; Sun, 10 May 2015 04:52:11 -0400 Received: from dcvr.yhbt.net ([64.71.152.64]:55368) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrMxz-0003Lx-BJ for dtas-all@nongnu.org; Sun, 10 May 2015 04:52:07 -0400 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 0E8B11FAC8; Sun, 10 May 2015 08:52:06 +0000 (UTC) From: Eric Wong To: Subject: [PATCH] splitfx: fix typo for dither application Date: Sun, 10 May 2015 08:52:04 +0000 Message-Id: <1431247924-23906-1-git-send-email-e@80x24.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 64.71.152.64 Cc: Eric Wong X-BeenThere: dtas-all@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dtas-all-bounces+dtas-all=80x24.org@nongnu.org Sender: dtas-all-bounces+dtas-all=80x24.org@nongnu.org We do not need to dither unless we output to 16-bit or less. This bug caused us to unnecessarily apply dither on 24-bit output files. Oops! --- lib/dtas/splitfx.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dtas/splitfx.rb b/lib/dtas/splitfx.rb index 6271fb0..208ff67 100644 --- a/lib/dtas/splitfx.rb +++ b/lib/dtas/splitfx.rb @@ -184,7 +184,7 @@ class DTAS::SplitFX # :nodoc: # add noise-shaped dither for 16-bit (sox manual seems to recommend this) if opts[:no_dither] env["SOX_OPTS"] = "#{ENV["SOX_OPTS"]} -D" - else outfmt.bits && outfmt.bits <= 16 + elsif outfmt.bits && outfmt.bits <= 16 env["DITHERFX"] = "dither -s" end comments = Tempfile.new(%W(dtas-splitfx-#{t.comments["TRACKNUMBER"]} .txt)) -- EW