From: Eric Wong <e@80x24.org>
To: spew@80x24.org
Subject: [PATCH 01/13] view: remove "subject dummy" references
Date: Wed, 5 Oct 2016 01:46:50 +0000 [thread overview]
Message-ID: <20161005014702.12626-2-e@80x24.org> (raw)
In-Reply-To: <20161005014702.12626-1-e@80x24.org>
We will not care for inexact threading by subject or pruning.
---
lib/PublicInbox/View.pm | 8 --------
1 file changed, 8 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 9359209..a3b2681 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -723,8 +723,6 @@ sub anchor_for {
sub ghost_parent {
my ($upfx, $mid) = @_;
- # 'subject dummy' is used internally by Mail::Thread
- return '[no common parent]' if ($mid eq 'subject dummy');
$mid = PublicInbox::Hval->new_msgid($mid);
my $href = $mid->{href};
@@ -838,12 +836,6 @@ sub skel_dump {
my $dst = $ctx->{dst};
my $mapping = $ctx->{mapping};
my $map = $mapping->{$mid} if $mapping;
- if ($mid eq 'subject dummy') {
- my $ncp = "\t[no common parent]\n";
- $map->[1] = $ncp if $map;
- $$dst .= $ncp;
- return;
- }
my $d = $ctx->{pct} ? ' [irrelevant] ' # search result
: ' [not found] ';
$d .= indent_for($level) . th_pfx($level);
--
EW
next prev parent reply other threads:[~2016-10-05 1:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 1:46 [WIP 0/13] mail threading speedups Eric Wong
2016-10-05 1:46 ` Eric Wong [this message]
2016-10-05 1:46 ` [PATCH 02/13] thread: remove Mail::Thread dependency Eric Wong
2016-10-05 1:46 ` [PATCH 03/13] thread: pass array refs instead of entire arrays Eric Wong
2016-10-05 1:46 ` [PATCH 04/13] thread: remove accessor usage in internals Eric Wong
2016-10-05 1:46 ` [PATCH 05/13] inbox: ghost smsg Eric Wong
2016-10-05 1:46 ` [PATCH 06/13] thread: remove Email::Abstract wrapping Eric Wong
2016-10-05 1:46 ` [PATCH 07/13] thread: remove rootset accessor method Eric Wong
2016-10-05 1:46 ` [PATCH 08/13] thread: simplify Eric Wong
2016-10-05 1:46 ` [PATCH 09/13] thread: remove iterate_down Eric Wong
2016-10-05 1:46 ` [PATCH 10/13] thread: avoid incrementing undefined value Eric Wong
2016-10-05 1:47 ` [PATCH 11/13] thread: order_children no longer cares about depth Eric Wong
2016-10-05 1:47 ` [PATCH 12/13] thread: inline and remove recurse_down logic Eric Wong
2016-10-05 1:47 ` [PATCH 13/13] thread: fix sorting without topmost Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161005014702.12626-2-e@80x24.org \
--to=e@80x24.org \
--cc=spew@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).