dumping ground for random patches and texts
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: spew@80x24.org
Subject: [PATCH 11/13] thread: order_children no longer cares about depth
Date: Wed,  5 Oct 2016 01:47:00 +0000	[thread overview]
Message-ID: <20161005014702.12626-12-e@80x24.org> (raw)
In-Reply-To: <20161005014702.12626-1-e@80x24.org>

We never use the depth anywhere in this sub
---
 lib/PublicInbox/SearchThread.pm | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/lib/PublicInbox/SearchThread.pm b/lib/PublicInbox/SearchThread.pm
index ba31f43..2e7b79a 100644
--- a/lib/PublicInbox/SearchThread.pm
+++ b/lib/PublicInbox/SearchThread.pm
@@ -203,7 +203,6 @@ sub order_children {
 	my ($walk, $ordersub) = @_;
 
 	my %seen;
-	my $depth = 0;
 	my @visited;
 	while ($walk) {
 		push @visited, $walk;
@@ -222,17 +221,13 @@ sub order_children {
 		}
 
 		# go down, or across
-		if ($child) {
-			$next = $child;
-			++$depth;
-		}
+		$next = $child if $child;
 
 		# no next?  look up
 		if (!$next) {
 			my $up = $walk;
 			while ($up && !$next) {
 				$up = $up->{parent};
-				--$depth;
 				$next = $up->{next} if $up;
 			}
 		}
-- 
EW


  parent reply	other threads:[~2016-10-05  1:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-05  1:46 [WIP 0/13] mail threading speedups Eric Wong
2016-10-05  1:46 ` [PATCH 01/13] view: remove "subject dummy" references Eric Wong
2016-10-05  1:46 ` [PATCH 02/13] thread: remove Mail::Thread dependency Eric Wong
2016-10-05  1:46 ` [PATCH 03/13] thread: pass array refs instead of entire arrays Eric Wong
2016-10-05  1:46 ` [PATCH 04/13] thread: remove accessor usage in internals Eric Wong
2016-10-05  1:46 ` [PATCH 05/13] inbox: ghost smsg Eric Wong
2016-10-05  1:46 ` [PATCH 06/13] thread: remove Email::Abstract wrapping Eric Wong
2016-10-05  1:46 ` [PATCH 07/13] thread: remove rootset accessor method Eric Wong
2016-10-05  1:46 ` [PATCH 08/13] thread: simplify Eric Wong
2016-10-05  1:46 ` [PATCH 09/13] thread: remove iterate_down Eric Wong
2016-10-05  1:46 ` [PATCH 10/13] thread: avoid incrementing undefined value Eric Wong
2016-10-05  1:47 ` Eric Wong [this message]
2016-10-05  1:47 ` [PATCH 12/13] thread: inline and remove recurse_down logic Eric Wong
2016-10-05  1:47 ` [PATCH 13/13] thread: fix sorting without topmost Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161005014702.12626-12-e@80x24.org \
    --to=e@80x24.org \
    --cc=spew@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).