imap: case-insensitive mailbox name comparisons

IMAP RFC 3501 stipulates case-insensitive comparisons, and so
does RFC 977 (NNTP).  However, INN (nnrpd) uses case-sensitive
comparisons, so we've always used case-sensitive comparisons for
NNTP to match nnrpd behavior.

Unfortunately, some IMAP clients insist on sending "INBOX" with
caps, which causes problems for us.  Since NNTP group names are
typically all lowercase anyways, just force all comparisons to
lowercase for IMAP and warn admins if uppercase-containing
newsgroups won't be accessible over IMAP.

This ensures our existing -nntpd behavior remains unchanged
while being compatible with the expectations of real-world IMAP
clients.

1 files changed, 7 insertions, 0 deletions

diff --git a/lib/PublicInbox/IMAPD.pm b/lib/PublicInbox/IMAPD.pm
index a3a25986..966879d8 100644
--- a/lib/PublicInbox/IMAPD.pm
+++ b/lib/PublicInbox/IMAPD.pm
@@ -25,6 +25,13 @@ sub refresh_inboxlist ($) {
         my ($self) = @_;
         my @names = map { $_->{newsgroup} } @{delete $self->{grouplist}};
         my %ns; # "\Noselect \HasChildren"
+
+        if (my @uc = grep(/[A-Z]/, @names)) {
+                warn "Uppercase not allowed for IMAP newsgroup(s):\n",
+                        map { "\t$_\n" } @uc;
+                my %uc = map { $_ => 1 } @uc;
+                @names = grep { !$uc{$_} } @names;
+        }
         for (@names) {
                 my $up = $_;
                 while ($up =~ s/\.[^\.]+\z//) {