about summary refs log tree commit homepage
path: root/lib/PublicInbox/XapHelper.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2024-04-24 06:44:45 +0000
committerEric Wong <e@80x24.org>2024-04-24 21:34:46 +0000
commit8e4426e3ff9e3dde861d4722b73b5a21c42910d4 (patch)
tree8140d1a666bdb2504640c66d510c0d2bc1b2af05 /lib/PublicInbox/XapHelper.pm
parent5aa2ba6d74c3f6a7f62a091e5df8346bb6d5b35a (diff)
downloadpublic-inbox-8e4426e3ff9e3dde861d4722b73b5a21c42910d4.tar.gz
Retrieving Xapian document terms, data (and possibly values) and
transferring to the Perl side would be an increase in complexity
and I/O both the Perl and C++ sides.  It would require more I/O
in C++ and transient memory use on the Perl side where slow mset
iteration gives an opportunity to dictate memory release rate.

So lets ignore the document-related stuff here for now for
ease-of-development.  We can reconsider this change if dropping
Xapian Perl bindings entirely and relying on JAOT C++ ever
becomes a possibility.
Diffstat (limited to 'lib/PublicInbox/XapHelper.pm')
-rw-r--r--lib/PublicInbox/XapHelper.pm5
1 files changed, 0 insertions, 5 deletions
diff --git a/lib/PublicInbox/XapHelper.pm b/lib/PublicInbox/XapHelper.pm
index 8c7732f5..27d98ba1 100644
--- a/lib/PublicInbox/XapHelper.pm
+++ b/lib/PublicInbox/XapHelper.pm
@@ -150,11 +150,6 @@ sub mset_iter ($$) {
         eval {
                 my $buf = $it->get_docid;
                 $buf .= "\0".$it->get_percent if $req->{p};
-                my $doc = ($req->{A} || $req->{D}) ? $it->get_document : undef;
-                for my $p (@{$req->{A}}) {
-                        $buf .= "\0".$p.$_ for xap_terms($p, $doc);
-                }
-                $buf .= "\0".$doc->get_data if $req->{D};
                 say { $req->{0} } $buf;
         };
         $@ ? iter_retry_check($req) : 0;