treewide: use warn() or carp() instead of env->{psgi.errors}

Large chunks of our codebase and 3rd-party dependencies do not
use ->{psgi.errors}, so trying to standardize on it was a
fruitless endeavor.  Since warn() and carp() are standard
mechanism within Perl, just use that instead and simplify a
bunch of existing code.

1 files changed, 2 insertions, 5 deletions

diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
index e74ddb90..a42867c5 100644
--- a/lib/PublicInbox/SearchView.pm
+++ b/lib/PublicInbox/SearchView.pm
@@ -102,11 +102,8 @@ sub mset_summary {
 
         foreach my $m ($mset->items) {
                 my $num = shift @nums;
-                my $smsg = delete($num2msg{$num}) or do {
-                        eval {
-                                $m = "$m $num expired\n";
-                                $ctx->{env}->{'psgi.errors'}->print($m);
-                        };
+                my $smsg = delete($num2msg{$num}) // do {
+                        warn "$m $num expired\n";
                         next;
                 };
                 my $mid = $smsg->{mid};