about summary refs log tree commit homepage
path: root/lib/PublicInbox/NNTPD.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2020-12-08 21:21:27 +0000
committerEric Wong <e@80x24.org>2020-12-09 21:13:34 +0000
commit0d38f65c490466837ae091afa7a7b6f59d04ce7c (patch)
tree8c838c12ce3c28ef1c15a15dd6584e0d0d831a34 /lib/PublicInbox/NNTPD.pm
parent416d1c3f6d5e5a857760ffc1b679e86a070bdbd4 (diff)
downloadpublic-inbox-0d38f65c490466837ae091afa7a7b6f59d04ce7c.tar.gz
{pi_config} may be confused with the documented `PI_CONFIG'
environment variable, and we'll favor vowel-removal to be
consistent with our usage of object references.

The `pi_' prefix may stay in some places, for now; since a
separate namespace may come into this codebase for local/private
client-tooling.

For InboxIdle, we'll also remove an invalid comment about
holding a reference to the PublicInbox::Config object, too.
Diffstat (limited to 'lib/PublicInbox/NNTPD.pm')
-rw-r--r--lib/PublicInbox/NNTPD.pm16
1 files changed, 8 insertions, 8 deletions
diff --git a/lib/PublicInbox/NNTPD.pm b/lib/PublicInbox/NNTPD.pm
index 03c56db3..953228d0 100644
--- a/lib/PublicInbox/NNTPD.pm
+++ b/lib/PublicInbox/NNTPD.pm
@@ -12,8 +12,8 @@ use PublicInbox::InboxIdle;
 
 sub new {
         my ($class) = @_;
-        my $pi_config = PublicInbox::Config->new;
-        my $name = $pi_config->{'publicinbox.nntpserver'};
+        my $pi_cfg = PublicInbox::Config->new;
+        my $name = $pi_cfg->{'publicinbox.nntpserver'};
         if (!defined($name) or $name eq '') {
                 $name = hostname;
         } elsif (ref($name) eq 'ARRAY') {
@@ -24,7 +24,7 @@ sub new {
                 groups => {},
                 err => \*STDERR,
                 out => \*STDOUT,
-                pi_config => $pi_config,
+                pi_cfg => $pi_cfg,
                 servername => $name,
                 greet => \"201 $name ready - post via email\r\n",
                 # accept_tls => { SSL_server => 1, ..., SSL_reuse_ctx => ... }
@@ -34,9 +34,9 @@ sub new {
 
 sub refresh_groups {
         my ($self, $sig) = @_;
-        my $pi_config = $sig ? PublicInbox::Config->new : $self->{pi_config};
-        my $groups = $pi_config->{-by_newsgroup}; # filled during each_inbox
-        $pi_config->each_inbox(sub {
+        my $pi_cfg = $sig ? PublicInbox::Config->new : $self->{pi_cfg};
+        my $groups = $pi_cfg->{-by_newsgroup}; # filled during each_inbox
+        $pi_cfg->each_inbox(sub {
                 my ($ibx) = @_;
                 my $ngname = $ibx->{newsgroup};
                 if (defined($ngname) && $ibx->nntp_usable) {
@@ -54,11 +54,11 @@ sub refresh_groups {
         });
         $self->{groupnames} = [ sort(keys %$groups) ];
         # this will destroy old groups that got deleted
-        $self->{pi_config} = $pi_config;
+        $self->{pi_cfg} = $pi_cfg;
 }
 
 sub idler_start {
-        $_[0]->{idler} //= PublicInbox::InboxIdle->new($_[0]->{pi_config});
+        $_[0]->{idler} //= PublicInbox::InboxIdle->new($_[0]->{pi_cfg});
 }
 
 1;