spawn: drop IO layer support from redirects

When setting up stdin for commands, the write_file API is
convenient enough nowadays to not be worth having special
support with process spawning.

When reading stdout of commands, we should probably be using
utf8_maybe everywhere since there'll always be legacy encodings
in git repos.

Reading regular files with :utf8 also results in worse memory
management since the file size cannot be used as a hint.

1 files changed, 2 insertions, 1 deletions

diff --git a/lib/PublicInbox/MailDiff.pm b/lib/PublicInbox/MailDiff.pm
index e4e262ef..125360fe 100644
--- a/lib/PublicInbox/MailDiff.pm
+++ b/lib/PublicInbox/MailDiff.pm
@@ -65,6 +65,7 @@ sub next_smsg ($) {
 sub emit_msg_diff {
         my ($bref, $self) = @_; # bref is `git diff' output
         require PublicInbox::Hval;
+        PublicInbox::Hval::utf8_maybe($$bref);
 
         # will be escaped to `•' in HTML
         $self->{ctx}->{ibx}->{obfuscate} and
@@ -81,7 +82,7 @@ sub do_diff {
         my $dir = "$self->{tmp}/$n";
         $self->dump_eml($dir, $eml);
         my $cmd = [ qw(git diff --no-index --no-color -- a), $n ];
-        my $opt = { -C => "$self->{tmp}", quiet => 1, 1 => [':utf8', \my $o] };
+        my $opt = { -C => "$self->{tmp}", quiet => 1 };
         my $qsp = PublicInbox::Qspawn->new($cmd, undef, $opt);
         $qsp->psgi_qx($self->{ctx}->{env}, undef, \&emit_msg_diff, $self);
 }