diff options
| author | Eric Wong <e@80x24.org> | 2023-09-30 15:20:39 +0000 |
|---|---|---|
| committer | Eric Wong <e@80x24.org> | 2023-10-01 07:05:23 +0000 |
| commit | 9b068be88b252355c1c62f804d4f081e9a20570d (patch) | |
| tree | 4cf3ab9eebd8361bd9a3857c4d307783997be63c /lib/PublicInbox/LeiToMail.pm | |
| parent | bf929e8ddfb9359a97cd8be3d3017c038564d52d (diff) | |
| download | public-inbox-9b068be88b252355c1c62f804d4f081e9a20570d.tar.gz | |
The benefit of 1MB potential pipe buffer size (on Linux) doesn't seem noticeable when reading from git (unlike when writing to v2 shards), so Unix stream sockets seem fine, here. This allows us to simplify our process management by using the same socket FD for reads and writes and enables us to use our ProcessPipe class for reaping (as we can do with Gcf2Client). Gcf2Client no longer relies on PublicInbox::DS for write buffering, and instead just waits for requests to complete once the number of inflight requests hits the MAX_INFLIGHT threshold as we do with PublicInbox::Git. We reuse the existing MAX_INFLIGHT limit (18) that was determined by the minimum allowed PIPE_BUF (512). (AFAIK) Unix stream sockets have no analogy to PIPE_BUF, but all *BSDs and Linux I've checked have default SO_RCVBUF and SO_SNDBUF values larger than the previously-required PIPE_BUF size of 512 bytes.
Diffstat (limited to 'lib/PublicInbox/LeiToMail.pm')
| -rw-r--r-- | lib/PublicInbox/LeiToMail.pm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/LeiToMail.pm b/lib/PublicInbox/LeiToMail.pm index 2dddf00b..98d0ac19 100644 --- a/lib/PublicInbox/LeiToMail.pm +++ b/lib/PublicInbox/LeiToMail.pm @@ -133,7 +133,7 @@ sub eml2mboxcl2 { sub git_to_mail { # git->cat_async callback my ($bref, $oid, $type, $size, $smsg) = @_; my $self = delete $smsg->{l2m} // die "BUG: no l2m"; - $type // return; # called by git->async_abort + $type // return; # called by PublicInbox::Git::close eval { if ($type eq 'missing' && ($bref = $self->{-lms_rw}->local_blob($oid, 1))) { |