diff options
| author | Eric Wong <e@yhbt.net> | 2020-06-23 23:21:12 +0000 |
|---|---|---|
| committer | Eric Wong <e@yhbt.net> | 2020-06-25 05:37:59 +0000 |
| commit | 10ee3548084c125f20fe2c830faea2a43413be92 (patch) | |
| tree | cb71ebd707af3b6b5e7a2854de35039af16cb5bf /lib/PublicInbox/IMAP.pm | |
| parent | f977826a17f8735e6947dd2da380df8c6d0b38d8 (diff) | |
| download | public-inbox-10ee3548084c125f20fe2c830faea2a43413be92.tar.gz | |
While this circular reference was carefully managed to not leak memory; it was still triggering a warning at -imapd/-nntpd shutdown due to the EPOLL_CTL_DEL op failing after the $Epoll FD gets closed. So remove the circular reference by providing a ref to `undef', instead.
Diffstat (limited to 'lib/PublicInbox/IMAP.pm')
| -rw-r--r-- | lib/PublicInbox/IMAP.pm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/IMAP.pm b/lib/PublicInbox/IMAP.pm index dec10d61..0a6993c6 100644 --- a/lib/PublicInbox/IMAP.pm +++ b/lib/PublicInbox/IMAP.pm @@ -1294,7 +1294,7 @@ sub long_step { } elsif ($more) { # $self->{wbuf}: $self->update_idle_time; - # control passed to $more may be a GitAsyncCat object + # control passed to git_async_cat if $more == \undef requeue_once($self) if !ref($more); } else { # all done! delete $self->{long_cb}; |