about summary refs log tree commit homepage
path: root/lib/PublicInbox/GitAsyncCat.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2022-09-12 16:04:48 +0000
committerEric Wong <e@80x24.org>2022-09-12 17:09:05 +0000
commit598dcdbead54e1d4746dea762c2c3cf292e796fc (patch)
treeb70321cb1c61aa70b47ace426d98b3405c17f602 /lib/PublicInbox/GitAsyncCat.pm
parent66eb1f1d9d7eb8fe892e328f6a5e656d1df7836b (diff)
downloadpublic-inbox-598dcdbead54e1d4746dea762c2c3cf292e796fc.tar.gz
We don't want to be holding references to temporary directories
longer than necessary, an Gcf is intended to be long-lived.
Diffstat (limited to 'lib/PublicInbox/GitAsyncCat.pm')
-rw-r--r--lib/PublicInbox/GitAsyncCat.pm3
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/PublicInbox/GitAsyncCat.pm b/lib/PublicInbox/GitAsyncCat.pm
index c12c4ec2..b32c2fd3 100644
--- a/lib/PublicInbox/GitAsyncCat.pm
+++ b/lib/PublicInbox/GitAsyncCat.pm
@@ -51,7 +51,8 @@ sub ibx_async_cat ($$$$) {
         # {topdir} means ExtSearch (likely [extindex "all"]) with potentially
         # 100K alternates.  git(1) has a proposed patch for 100K alternates:
         # <https://lore.kernel.org/git/20210624005806.12079-1-e@80x24.org/>
-        if (!defined($ibx->{topdir}) && ($GCF2C //= eval {
+        if (!defined($ibx->{topdir}) && !defined($git->{-tmp}) &&
+                ($GCF2C //= eval {
                 require PublicInbox::Gcf2Client;
                 PublicInbox::Gcf2Client::new();
         } // 0)) { # 0: do not retry if libgit2 or Inline::C are missing