about summary refs log tree commit homepage
path: root/lib/PublicInbox/Git.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2023-01-17 07:19:04 +0000
committerEric Wong <e@80x24.org>2023-01-18 23:25:59 +0000
commit2d95420e2255db25c0a5d9ec1dfee13aef1dcff6 (patch)
treec1af37128a03b751f85eb0b6579d136d2b9edb6e /lib/PublicInbox/Git.pm
parent6bb2079cf610585176d23344047a048f4f8bf3dc (diff)
downloadpublic-inbox-2d95420e2255db25c0a5d9ec1dfee13aef1dcff6.tar.gz
This is a trivial change compared to Qspawn in the previous
commit.
Diffstat (limited to 'lib/PublicInbox/Git.pm')
-rw-r--r--lib/PublicInbox/Git.pm10
1 files changed, 5 insertions, 5 deletions
diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index 96627daa..c9ed48be 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -21,7 +21,7 @@ use PublicInbox::Tmpfile;
 use IO::Poll qw(POLLIN);
 use Carp qw(croak carp);
 use Digest::SHA ();
-use PublicInbox::DS qw(dwaitpid);
+use PublicInbox::DS qw(awaitpid);
 our @EXPORT_OK = qw(git_unquote git_quote);
 our $PIPE_BUFSIZ = 65536; # Linux default
 our $in_cleanup;
@@ -138,7 +138,7 @@ sub _bidi_pipe {
                 $rdr->{2} = $fh;
         }
         my ($in_r, $p) = popen_rd(\@cmd, undef, $rdr);
-        $self->{$pid} = $p;
+        awaitpid($self->{$pid} = $p, undef);
         $self->{"$pid.owner"} = $$;
         $out_w->autoflush(1);
         if ($^O eq 'linux') { # 1031: F_SETPIPE_SZ
@@ -357,9 +357,9 @@ sub _destroy {
         delete @$self{($rbuf, $in, $out)};
         delete $self->{$err} if $err; # `err_c'
 
-        # GitAsyncCat::event_step may delete {pid}
-        my $p = delete $self->{$pid} or return;
-        dwaitpid($p) if $$ == $self->{"$pid.owner"};
+        # GitAsyncCat::event_step may delete {$pid}
+        my $p = delete($self->{$pid}) // return;
+        awaitpid($p) if $$ == $self->{"$pid.owner"};
 }
 
 sub async_abort ($) {