about summary refs log tree commit homepage
path: root/lib/PublicInbox/ExtSearch.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2021-09-22 09:45:17 +0000
committerEric Wong <e@80x24.org>2021-09-23 04:52:06 +0000
commit356439a571c536eaa487031802b436d087113f4f (patch)
treecab628111eefa6f5a059cbc405d8e01a2ccb8670 /lib/PublicInbox/ExtSearch.pm
parent7d2f9f7caf63256bab7b3342c52a1d97c889ada4 (diff)
downloadpublic-inbox-356439a571c536eaa487031802b436d087113f4f.tar.gz
Check for unlinked mmap-ed files via /proc/$PID/maps every 60s
or so.

ExtSearch (extindex) is compatible-enough with Inbox objects to
be wired into the old per-inbox code, but the startup cost is
projected to be much higher down the line when there's >30K
inboxes, so we scan /proc/$PID/maps for deleted files before
unlinking.  With old Inbox objects, it was (and is) simpler to
just kill processes w/o checking due to the low startup cost
(and non-portability of checking).

Reported-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Link: https://public-inbox.org/meta/20210921144754.gulkneuulzo27qbw@meerkat.local/
Diffstat (limited to 'lib/PublicInbox/ExtSearch.pm')
-rw-r--r--lib/PublicInbox/ExtSearch.pm10
1 files changed, 8 insertions, 2 deletions
diff --git a/lib/PublicInbox/ExtSearch.pm b/lib/PublicInbox/ExtSearch.pm
index bd301158..cd7cba2e 100644
--- a/lib/PublicInbox/ExtSearch.pm
+++ b/lib/PublicInbox/ExtSearch.pm
@@ -33,12 +33,18 @@ sub misc {
 # same as per-inbox ->over, for now...
 sub over {
         my ($self) = @_;
-        $self->{over} //= PublicInbox::Over->new("$self->{xpfx}/over.sqlite3");
+        $self->{over} //= do {
+                PublicInbox::Inbox::_cleanup_later($self);
+                PublicInbox::Over->new("$self->{xpfx}/over.sqlite3");
+        };
 }
 
 sub git {
         my ($self) = @_;
-        $self->{git} //= PublicInbox::Git->new("$self->{topdir}/ALL.git");
+        $self->{git} //= do {
+                PublicInbox::Inbox::_cleanup_later($self);
+                PublicInbox::Git->new("$self->{topdir}/ALL.git");
+        };
 }
 
 # returns a hashref of { $NEWSGROUP_NAME => $ART_NO } using the `xref3' table