about summary refs log tree commit
diff options
context:
space:
mode:
authorDavid Mitchell <davem@iabyn.com>2014-12-08 12:43:04 +0000
committerSteve Hay <steve.m.hay@googlemail.com>2015-01-12 23:47:23 +0000
commit24e5c36815378c124ada71c86867deef25278665 (patch)
treecf8926b5cb567697cd272a41ad0d1c3a1d90194c
parent4953a0fc9e74bae849344e60b77df72c018f598e (diff)
downloadperl-libnet-24e5c36815378c124ada71c86867deef25278665.tar.gz
libnet: less test noise on STDERR
Change the tests so that information about the port a server has started
on etc, goes to to STDOUT rather than STDERR - which should be reserved for
when things have gone wrong.
-rw-r--r--t/nntp_ipv6.t6
-rw-r--r--t/nntp_ssl.t4
-rw-r--r--t/pop3_ipv6.t6
-rw-r--r--t/pop3_ssl.t4
-rw-r--r--t/smtp_ipv6.t6
-rw-r--r--t/smtp_ssl.t4
6 files changed, 15 insertions, 15 deletions
diff --git a/t/nntp_ipv6.t b/t/nntp_ipv6.t
index fbb1458..1992618 100644
--- a/t/nntp_ipv6.t
+++ b/t/nntp_ipv6.t
@@ -28,7 +28,7 @@ my $srv = $inet6class->new(
 plan skip_all => "cannot create listener on ::1: $!" if ! $srv;
 my $host = $srv->sockhost;
 my $port = $srv->sockport;
-diag("server on $host port $port");
+note("server on $host port $port");
 
 plan tests => 1;
 
@@ -36,7 +36,7 @@ defined( my $pid = fork()) or die "fork failed: $!";
 exit(nntp_server()) if ! $pid;
 
 my $cl = Net::NNTP->new(Host => $host, Port => $port,, Debug => $debug);
-diag("created Net::NNTP object");
+note("created Net::NNTP object");
 if (!$cl) {
   fail("IPv6 NNTP connect failed");
 } else {
@@ -62,5 +62,5 @@ sub nntp_server {
       print "500 unknown cmd\r\n";
     }
   }
-  diag("NNTP dialog done");
+  note("NNTP dialog done");
 }
diff --git a/t/nntp_ssl.t b/t/nntp_ssl.t
index 66789fb..387899f 100644
--- a/t/nntp_ssl.t
+++ b/t/nntp_ssl.t
@@ -73,7 +73,7 @@ sub nntp_client {
     Debug => $debug,
     %sslopt,
   );
-  diag("created Net::NNTP object");
+  note("created Net::NNTP object");
   if (!$cl) {
     fail( ($ssl ? "SSL ":"" )."NNTP connect failed");
   } elsif ($ssl) {
@@ -125,5 +125,5 @@ sub nntp_server {
     }
   }
 
-  diag("NNTP dialog done");
+  note("NNTP dialog done");
 }
diff --git a/t/pop3_ipv6.t b/t/pop3_ipv6.t
index 004a642..5100951 100644
--- a/t/pop3_ipv6.t
+++ b/t/pop3_ipv6.t
@@ -27,7 +27,7 @@ my $srv = $inet6class->new(
 );
 plan skip_all => "cannot create listener on ::1: $!" if ! $srv;
 my $saddr = "[".$srv->sockhost."]".':'.$srv->sockport;
-diag("server on $saddr");
+note("server on $saddr");
 
 plan tests => 1;
 
@@ -35,7 +35,7 @@ defined( my $pid = fork()) or die "fork failed: $!";
 exit(pop3_server()) if ! $pid;
 
 my $cl = Net::POP3->new($saddr, Debug => $debug);
-diag("created Net::POP3 object");
+note("created Net::POP3 object");
 if (!$cl) {
   fail("IPv6 POP3 connect failed");
 } else {
@@ -62,5 +62,5 @@ sub pop3_server {
     }
   }
 
-  diag("POP3 dialog done");
+  note("POP3 dialog done");
 }
diff --git a/t/pop3_ssl.t b/t/pop3_ssl.t
index 31b2bbd..3eca064 100644
--- a/t/pop3_ssl.t
+++ b/t/pop3_ssl.t
@@ -67,7 +67,7 @@ sub pop3_client {
   );
   $sslopt{SSL} = 1 if $ssl;
   my $cl = Net::POP3->new($saddr, %sslopt, Debug => $debug);
-  diag("created Net::POP3 object");
+  note("created Net::POP3 object");
   if (!$cl) {
     fail( ($ssl ? "SSL ":"" )."POP3 connect failed");
   } elsif ($ssl) {
@@ -121,5 +121,5 @@ sub pop3_server {
     }
   }
 
-  diag("POP3 dialog done");
+  note("POP3 dialog done");
 }
diff --git a/t/smtp_ipv6.t b/t/smtp_ipv6.t
index 78a14fe..48c7246 100644
--- a/t/smtp_ipv6.t
+++ b/t/smtp_ipv6.t
@@ -27,7 +27,7 @@ my $srv = $inet6class->new(
 );
 plan skip_all => "cannot create listener on ::1: $!" if ! $srv;
 my $saddr = "[".$srv->sockhost."]".':'.$srv->sockport;
-diag("server on $saddr");
+note("server on $saddr");
 
 plan tests => 1;
 
@@ -35,7 +35,7 @@ defined( my $pid = fork()) or die "fork failed: $!";
 exit(smtp_server()) if ! $pid;
 
 my $cl = Net::SMTP->new($saddr, Debug => $debug);
-diag("created Net::SMTP object");
+note("created Net::SMTP object");
 if (!$cl) {
   fail("IPv6 SMTP connect failed");
 } else {
@@ -64,5 +64,5 @@ sub smtp_server {
     }
   }
 
-  diag("SMTP dialog done");
+  note("SMTP dialog done");
 }
diff --git a/t/smtp_ssl.t b/t/smtp_ssl.t
index 108d094..e91cc9b 100644
--- a/t/smtp_ssl.t
+++ b/t/smtp_ssl.t
@@ -67,7 +67,7 @@ sub smtp_client {
   );
   $sslopt{SSL} = 1 if $ssl;
   my $cl = Net::SMTP->new($saddr, %sslopt, Debug => $debug);
-  diag("created Net::SMTP object");
+  note("created Net::SMTP object");
   if (!$cl) {
     fail( ($ssl ? "SSL ":"" )."SMTP connect failed");
   } elsif ($ssl) {
@@ -123,5 +123,5 @@ sub smtp_server {
     }
   }
 
-  diag("SMTP dialog done");
+  note("SMTP dialog done");
 }