use macro to quiet uninitialized and unused variable warnings

This allows us to avoid some #ifdefs inside function bodies.
This cleanup comes from the Ruby version.

1 files changed, 8 insertions, 6 deletions

diff --git a/Mwrap.xs b/Mwrap.xs
index bec4664..10139fc 100644
--- a/Mwrap.xs
+++ b/Mwrap.xs
@@ -153,14 +153,18 @@ __attribute__((constructor)) static void resolve_malloc(void)
         --locating;
 }
 
+#ifdef NDEBUG
+#define QUIET_CC_WARNING(var) (void)var;
+#else
+#define QUIET_CC_WARNING(var)
+#endif
+
 static void
 mutex_lock(pthread_mutex_t *m)
 {
         int err = pthread_mutex_lock(m);
         assert(err == 0);
-#ifdef NDEBUG
-        (void)err; /* quiet gcc warning */
-#endif
+        QUIET_CC_WARNING(err)
 }
 
 static void
@@ -168,9 +172,7 @@ mutex_unlock(pthread_mutex_t *m)
 {
         int err = pthread_mutex_unlock(m);
         assert(err == 0);
-#ifdef NDEBUG
-        (void)err; /* quiet gcc warning */
-#endif
+        QUIET_CC_WARNING(err)
 }
 
 #ifndef HAVE_MEMPCPY